From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by sourceware.org (Postfix) with ESMTPS id 7105F3858409 for ; Mon, 13 Dec 2021 17:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7105F3858409 Received: from DB7PR05CA0014.eurprd05.prod.outlook.com (2603:10a6:10:36::27) by AM0PR08MB3841.eurprd08.prod.outlook.com (2603:10a6:208:106::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec 2021 17:37:42 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::ca) by DB7PR05CA0014.outlook.office365.com (2603:10a6:10:36::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14 via Frontend Transport; Mon, 13 Dec 2021 17:37:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Mon, 13 Dec 2021 17:37:41 +0000 Received: ("Tessian outbound f493ab4f1fb8:v110"); Mon, 13 Dec 2021 17:37:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 77cff0e55187650a X-CR-MTA-TID: 64aa7808 Received: from fc27b32ad78d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A9FF6571-A0A6-4769-97FB-C35F144260DF.1; Mon, 13 Dec 2021 17:37:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc27b32ad78d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Dec 2021 17:37:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGlzOqUv6Z1TkmBiSwxTyuOzIANgL8DQynyIPBz/447jJrsKtPoNvlMDK+TapPpT4CvQvG4bRFyJZ8KYLy66W67TDuW7WGMKcmBGzb/sZM+0wXqi3PsiNJayJgDBl7wLFK8XzVYCN9afVlCsR6lMBw8EAD8sTJiZ1gk/H0yiwDYL9KwSrV4Fgsxx/SjJQTdVly/zBaZMOYdUqxJVpeqvSAOZVx3fHJe4ihtjbXdv4pE49rZrgLVvyTcjH/IodRAIUduT9IKP0+xz0VcGS1fNbComrUdZmiwtf0bsNdIn9wTtBQoCO5c3Ir/AT9ijte7wecI67KE3SX/EqSXTboAMHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RWjrq/2YzNG1DRWFGPtoorXjU0OVeGg2KbAIhzCqRG0=; b=Vw4VypFpMyrUuRNwyY7sy1twiEdBSnGR2HCQ2h17sCYVhT90CyHLLwReC1XiVqSstBNaUCVQiWzGccOcZR8Xu4uNVTAI6U5BGNPcp6kCUV9aE2SmRTQysMuf/uL5t+yKmlcjncJLuEKFMffLHCUNghoBbdVrHafhgULWgqMm1bVsA+34376NLBIinXlupeUE4MEl2WOyLYWeUuEim69cejoi9Eb90Ga6VqnR35YSemmfEMOGwIfw4H5arQGkeQY9cQ83RL+AAodD3bIIpj+AIHi+fOz2Gkqbpw+ggs+Tc75cgDUqGQvG3h7qAxUa3A26sNciNOJWVDi5DfMIDPAwjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DU0PR08MB7415.eurprd08.prod.outlook.com (2603:10a6:10:353::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Mon, 13 Dec 2021 17:37:22 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::25f9:a7e6:422a:da43%7]) with mapi id 15.20.4778.018; Mon, 13 Dec 2021 17:37:22 +0000 Date: Mon, 13 Dec 2021 17:37:20 +0000 From: Szabolcs Nagy To: Rongwei Wang Cc: Andreas Schwab , fweimer@redhat.com, xuyu@linux.alibaba.com, Rongwei Wang via Libc-alpha , gavin.dg@linux.alibaba.com Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] Message-ID: <20211213173720.GX3294453@arm.com> References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-1-rongwei.wang@linux.alibaba.com> <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> <87h7bczq0q.fsf@igel.home> <20211213115211.GV3294453@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0243.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::15) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c8493418-fa5a-46cf-bbe3-08d9be5f43b6 X-MS-TrafficTypeDiagnostic: DU0PR08MB7415:|DB5EUR03FT047:EE_|AM0PR08MB3841:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zG0KQ2dWxb3tbvzad0h4kgxdyc/jnKit7xUiZLKwhHxoCe5o6dyKazZluTyey/EXbA21sXAZdZbLlRfe6Cf+tAd/snxewtKiUKb2QUiDWDYj/oWbldor6Wfsot8ldniJ31F61mtt5rngDJQ8m0KSQyGxvuufnnTmtfXZBrPnxJF2OC0nFpddcPiNfKPTyhhy43p+zWENE7Dd3kWUomzg5tRIpNxwN1/qw84tWF+afATTaTJQiOnQRFhcquHgoRhDRLu1GiUTcU/TAM18w/5fD/40qPLYL2+0mRfd1sGGCoI04+zrInDRo2UdGZEoAyb/N9IjNltgM1PeivBn7Hf1qdYApjtOwsnqnYOnDtt9jozuXpeCtYtG27v5MmuoWgsj93hmUGuD+47FwUPNUJxWfXm4GyDnqfPN1QBSEgmvFo+kWJb8AUYYTkiDyJH+bV7ykVcH5sYovF6eFU6EzW0/IlyKHNgyL8ayc6BPqw1O+fxMwLa4o+E3jpRuJGignc4vKkGOmt3q8cH3B0AWFZCIGHmdfuOmAhpD/fgSkpXAUW8WCcJaV5fZQwEbOxpmAQ350xG0F6YdIVYYu3+1oENsrAgtZbLCbwDRuQm/vk/1Oz42d4awgLEA/d8tj3surieQPDzpsq/ml0f9cszahw0ysANN8e+h8+aL94kPVBxZ/sztq0BLC3Js25NP2gb3RGtPcL6x+KDpQA81o3ImLdhgWA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(84040400005)(38350700002)(38100700002)(1076003)(86362001)(6506007)(26005)(66946007)(6916009)(53546011)(66556008)(2616005)(52116002)(44832011)(2906002)(8936002)(508600001)(8676002)(186003)(5660300002)(83380400001)(4326008)(36756003)(33656002)(66476007)(316002)(6486002)(54906003)(6512007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7415 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 341d0745-c2c3-497d-830d-08d9be5f383e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XYxeBwV4aeNN0IsfuLzagaf5c7tZg0crwDZw1UBNyNptSSdFyjNZdvl2ygm6Y8MkEVInAn6/vGFxfScDzZYmchkDUfWgclHZPu3ewpUP0My/yoKlLnXKacBQCpSH2/bHBzqNNiYFDLz2gOcwex4S2plCS7A27ft+LXpm7xMiEqoEOaTr+DZYl6blPl2yvnut2BkxLlh0PizbEWz9SeeQj++kRfz4GNu2XzaRZTlGmV+k/SMYEAgliysN1+rr8VBGvWv+PkDZkzl1mLoNhgzvBMu4WJnzrXb5p9aH9+4YZhrdbsnoGLKm+Iim1jwC72cBb8Vy8/axeb13XwNyQMGlm1CUos5hupk5NPhgTOotQmcyAeP1MRVPZWWzPLQ+Ja5tW9jUQs+Cvb4s+Dmvt7RQxd1Mh+9HHNO4LGOKTkSzyLsYAFbpW0+N9GsrWhPwbHDBWi6PjLQAirVQcMKEaJZMNuGdQSJC4500X5jMQvv4bWg5GMIBGfiqHT/tzUYZHR1VUiRH+vMVSpHc8dTS4dYVhtq1s+M/7tQ+WTdd1lQYHtY15KdjLNxIHvLn0HbOLKD1ZLuoCTNrUiY9hwkyBWfQdZsJZmr7KheoAxmMguDP7JF1OoLG4m1PrmzNtuvrluVi6c9SovFc3MmebYWZTfQECLj3HmQLuYJFA+cvXMO/k0LRmGJA1QR2tRluEG1YeSIwn2wh1yIDgrRNwOh9KoF8ClSN/Y4lmqORXHB0J5ifeq5ibdlGLKDjL9s0ozrhdmyK81K9pWXfUpGvto2ezPVAsQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(84040400005)(36840700001)(46966006)(40470700001)(1076003)(47076005)(33656002)(83380400001)(54906003)(4326008)(186003)(356005)(6486002)(26005)(508600001)(44832011)(40460700001)(316002)(6512007)(336012)(8936002)(8676002)(36860700001)(5660300002)(2906002)(53546011)(6506007)(6862004)(86362001)(70206006)(82310400004)(70586007)(2616005)(36756003)(107886003)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 17:37:41.6855 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8493418-fa5a-46cf-bbe3-08d9be5f43b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3841 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 17:37:53 -0000 The 12/13/2021 22:51, Rongwei Wang wrote: > On 12/13/21 7:52 PM, Szabolcs Nagy via Libc-alpha wrote: > > The 12/13/2021 12:46, Andreas Schwab wrote: > > > On Dez 13 2021, Rongwei Wang via Libc-alpha wrote: > > > > > > > + else > > > > + { > > > > + /* Unmap the unused regions. */ > > > > + ElfW(Addr) delta = map_start_aligned - map_start; > > > > + if (delta) > > > > + __munmap ((void *) map_start, delta); > > > > + ElfW(Addr) map_end = map_start_aligned + maplength; > > > > + delta = map_start + maplen - map_end; > > > > + if (delta) > > > > + __munmap ((void *) map_end, delta); > > > > > > I don't think map_end is guaranteed to be page-aligned. > > > > indeed i see failing munmap syscalls in strace > Hi, Szabolcs > > Thanks for your test! I have no arm32 environment, and ignoring this test. > > It seems the 'map_end' need to be page-aligned before calling munmap. > The following code only update the first line to fix this bug: > > + ElfW(Addr) map_end = ALIGN_UP(map_start_aligned + maplength, > GLRO(dl_pagesize)); > + delta = map_start + maplen - map_end; > + if (delta) > + __munmap ((void *) map_end, delta); > > Can you help me test this new code again if available? yes, the ALIGN_UP works. note that the issue is observable on aarch64 too (with 4k pagesize) and likely x86_64 too, it just does not cause enough vm fragmentation there to run out of memory. you can verify it by using strace -e munmap before and after. thanks.