From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: [PATCH v7 4/4] elf: Add a test for PT_LOAD segments with invalid p_align [BZ #28688]
Date: Mon, 3 Jan 2022 15:04:33 -0800 [thread overview]
Message-ID: <20220103230433.1907240-5-hjl.tools@gmail.com> (raw)
In-Reply-To: <20220103230433.1907240-1-hjl.tools@gmail.com>
Build tst-p_alignmod3.so with 256 byte page size and verify that it is
rejected with a proper error message.
---
elf/Makefile | 11 +++++++++++
elf/tst-p_align3.c | 27 +++++++++++++++++++++++++++
elf/tst-p_align3.sh | 26 ++++++++++++++++++++++++++
elf/tst-p_alignmod3.c | 22 ++++++++++++++++++++++
4 files changed, 86 insertions(+)
create mode 100644 elf/tst-p_align3.c
create mode 100755 elf/tst-p_align3.sh
create mode 100644 elf/tst-p_alignmod3.c
diff --git a/elf/Makefile b/elf/Makefile
index e4be3fa518..eca730ae8f 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -409,6 +409,10 @@ tests += \
tst-p_alignmod2-edit \
tst-p_align1 \
tst-p_align2 \
+ tst-p_align3 \
+
+modules-names += \
+ tst-p_alignmod3 \
endif
@@ -2110,3 +2114,10 @@ $(objpfx)tst-p_alignmod2.so: $(objpfx)tst-p_alignmod2-edit \
cp $(objpfx)tst-alignmod3.so $@
$(test-wrapper-env) $(run-program-env) $(rtld-prefix) \
$(objpfx)tst-p_alignmod2-edit $@
+
+LDFLAGS-tst-p_alignmod3.so += -Wl,-z,max-page-size=0x100,-z,common-page-size=0x100
+
+$(objpfx)tst-p_align3: $(objpfx)tst-p_alignmod3.so
+$(objpfx)tst-p_align3.out: tst-p_align3.sh $(objpfx)tst-p_align3
+ $(SHELL) $< $(common-objpfx) '$(test-program-prefix)'; \
+ $(evaluate-test)
diff --git a/elf/tst-p_align3.c b/elf/tst-p_align3.c
new file mode 100644
index 0000000000..61c616ac3b
--- /dev/null
+++ b/elf/tst-p_align3.c
@@ -0,0 +1,27 @@
+/* Check invalid p_align of PT_LOAD segments in a shared library.
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+extern int do_load_test (void);
+
+static int
+do_test (void)
+{
+ return do_load_test ();
+}
+
+#include <support/test-driver.c>
diff --git a/elf/tst-p_align3.sh b/elf/tst-p_align3.sh
new file mode 100755
index 0000000000..11572aa217
--- /dev/null
+++ b/elf/tst-p_align3.sh
@@ -0,0 +1,26 @@
+#!/bin/sh
+# Check invalid p_align of PT_LOAD segments in a shared library.
+# Copyright (C) 2021 Free Software Foundation, Inc.
+# This file is part of the GNU C Library.
+
+# The GNU C Library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+
+# The GNU C Library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# Lesser General Public License for more details.
+
+# You should have received a copy of the GNU Lesser General Public
+# License along with the GNU C Library; if not, see
+# <https://www.gnu.org/licenses/>.
+
+common_objpfx=$1; shift
+test_program_prefix=$1; shift
+
+${test_program_prefix} \
+ ${common_objpfx}elf/tst-p_align3 \
+ 2> ${common_objpfx}elf/tst-p_align3.out && exit 1
+grep "ELF load command address/offset not page-aligned" ${common_objpfx}elf/tst-p_align3.out
diff --git a/elf/tst-p_alignmod3.c b/elf/tst-p_alignmod3.c
new file mode 100644
index 0000000000..90f3af467e
--- /dev/null
+++ b/elf/tst-p_alignmod3.c
@@ -0,0 +1,22 @@
+/* Check invalid p_align of PT_LOAD segment in a shared library.
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+void
+do_load_test (void)
+{
+}
--
2.33.1
next prev parent reply other threads:[~2022-01-03 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 23:04 [PATCH v7 0/4] Properly align all PT_LOAD segments with tests H.J. Lu
2022-01-03 23:04 ` [PATCH v7 1/4] elf: Properly align all PT_LOAD segments [BZ #28676] H.J. Lu
2022-01-18 17:48 ` Adhemerval Zanella
2022-01-18 21:46 ` H.J. Lu
2022-01-03 23:04 ` [PATCH v7 2/4] elf: Add a test for PT_LOAD segments with mixed p_align " H.J. Lu
2022-01-18 16:25 ` Adhemerval Zanella
2022-01-18 21:53 ` H.J. Lu
2022-01-03 23:04 ` [PATCH v7 3/4] elf: Add a test for PT_LOAD segments with p_align == 1 [BZ #28688] H.J. Lu
2022-01-18 16:32 ` Adhemerval Zanella
2022-01-18 16:36 ` Adhemerval Zanella
2022-01-18 21:55 ` H.J. Lu
2022-01-03 23:04 ` H.J. Lu [this message]
2022-01-18 18:05 ` [PATCH v7 4/4] elf: Add a test for PT_LOAD segments with invalid p_align " Adhemerval Zanella
2022-01-18 21:50 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103230433.1907240-5-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).