* [PATCH] timezone: Fix tst-bz28707 Makefile rule
@ 2022-01-10 13:18 Adhemerval Zanella
2022-01-12 12:51 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2022-01-10 13:18 UTC (permalink / raw)
To: libc-alpha
The $(testdata)/XT5 rule is ambiguous and it may not be correct
evaluated.
---
timezone/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/timezone/Makefile b/timezone/Makefile
index 4e7f68a8fc..a789c22d26 100644
--- a/timezone/Makefile
+++ b/timezone/Makefile
@@ -124,7 +124,8 @@ $(testdata)/XT%: testdata/XT%
$(make-target-directory)
cp $< $@
-$(testdata)/XT%: testdata/gen-XT%.sh
+$(testdata)/XT5: testdata/gen-XT5.sh
+ $(make-target-directory)
$(SHELL) $< > $@.tmp
mv $@.tmp $@
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] timezone: Fix tst-bz28707 Makefile rule
2022-01-10 13:18 [PATCH] timezone: Fix tst-bz28707 Makefile rule Adhemerval Zanella
@ 2022-01-12 12:51 ` Adhemerval Zanella
2022-01-12 13:37 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2022-01-12 12:51 UTC (permalink / raw)
To: libc-alpha
I am seeing make check completion failure without this issue and I
will install this shortly if no one opposes it.
On 10/01/2022 10:18, Adhemerval Zanella wrote:
> The $(testdata)/XT5 rule is ambiguous and it may not be correct
> evaluated.
> ---
> timezone/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/timezone/Makefile b/timezone/Makefile
> index 4e7f68a8fc..a789c22d26 100644
> --- a/timezone/Makefile
> +++ b/timezone/Makefile
> @@ -124,7 +124,8 @@ $(testdata)/XT%: testdata/XT%
> $(make-target-directory)
> cp $< $@
>
> -$(testdata)/XT%: testdata/gen-XT%.sh
> +$(testdata)/XT5: testdata/gen-XT5.sh
> + $(make-target-directory)
> $(SHELL) $< > $@.tmp
> mv $@.tmp $@
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] timezone: Fix tst-bz28707 Makefile rule
2022-01-12 12:51 ` Adhemerval Zanella
@ 2022-01-12 13:37 ` Florian Weimer
0 siblings, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2022-01-12 13:37 UTC (permalink / raw)
To: Adhemerval Zanella via Libc-alpha
* Adhemerval Zanella via Libc-alpha:
> I am seeing make check completion failure without this issue and I
> will install this shortly if no one opposes it.
Yes, please check it in.
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-12 13:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 13:18 [PATCH] timezone: Fix tst-bz28707 Makefile rule Adhemerval Zanella
2022-01-12 12:51 ` Adhemerval Zanella
2022-01-12 13:37 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).