From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: libc-alpha@sourceware.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, commit-hurd@gnu.org
Subject: [hurd,commited] hurd: Fix exec() leak on proc_task2proc failure
Date: Sat, 15 Jan 2022 21:59:40 +0100 [thread overview]
Message-ID: <20220115205940.516933-1-samuel.thibault@ens-lyon.org> (raw)
env is allocated after args, so should be freed before it.
---
hurd/hurdexec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hurd/hurdexec.c b/hurd/hurdexec.c
index 546cc69960..d5a20cb9b0 100644
--- a/hurd/hurdexec.c
+++ b/hurd/hurdexec.c
@@ -469,10 +469,10 @@ retry:
/* Got a signal while inside an RPC of the critical section, retry again */
goto retry;
- outargs:
- free (args);
outenv:
free (env);
+ outargs:
+ free (args);
return err;
}
libc_hidden_def (_hurd_exec_paths)
--
2.34.1
reply other threads:[~2022-01-15 20:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115205940.516933-1-samuel.thibault@ens-lyon.org \
--to=samuel.thibault@ens-lyon.org \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).