From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sourceware.org (Postfix) with ESMTPS id E54E03850428 for ; Thu, 27 Jan 2022 17:15:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E54E03850428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aquilenet.fr Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=aquilenet.fr X-IronPort-AV: E=Sophos;i="5.88,321,1635199200"; d="scan'208";a="18322324" Received: from nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr (HELO begin) ([194.199.1.52]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 18:15:57 +0100 Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1nD8NJ-008jcs-Fm; Thu, 27 Jan 2022 18:15:57 +0100 Date: Thu, 27 Jan 2022 18:15:57 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np Message-ID: <20220127171557.kseob4ysn5tgcsg4@begin> References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 17:16:01 -0000 Hello, Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit: > On 27/01/2022 13:11, Florian Weimer wrote: > > * Adhemerval Zanella: > > > >> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the > >> controlling terminal), so it would make more sense to actually fit > >> it on the file actions API. > >> > >> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is > >> implicit by the presence of tcsetpgrp file action. > >> > >> The posix/tst-spawn6.c is also fixed when TTY can is not present. > >> > >> Checked on x86_64-linux-gnu and i686-linux-gnu. > > > > This has an ABI check failure on Hurd: > > > > --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 > > +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 > > @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt > > -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F > > -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F > > > > The changes look okay to me. A second review is probably warranted at > > this stage. > > Thanks. It is really annoying that hurd make update-abi adds a bunch of files > and requires manual edit to get it right. I don't think I understand. How is it different in the linux case? Samuel