From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 122B53857C72 for ; Thu, 27 Jan 2022 18:10:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 122B53857C72 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aquilenet.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aquilenet.fr Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 83CEA293; Thu, 27 Jan 2022 19:10:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yRuIo7mc3dWu; Thu, 27 Jan 2022 19:10:38 +0100 (CET) Received: from begin.home (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C3A3916C; Thu, 27 Jan 2022 19:10:38 +0100 (CET) Received: from samy by begin.home with local (Exim 4.95) (envelope-from ) id 1nD9ED-008lIR-RB; Thu, 27 Jan 2022 19:10:37 +0100 Date: Thu, 27 Jan 2022 19:10:37 +0100 From: Samuel Thibault To: Adhemerval Zanella Cc: Florian Weimer , libc-alpha@sourceware.org Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np Message-ID: <20220127181037.hbu7mpoefq23qewq@begin> References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> <20220127171557.kseob4ysn5tgcsg4@begin> <9cba4ff5-49c6-e597-85f5-45be0021bfa7@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cba4ff5-49c6-e597-85f5-45be0021bfa7@linaro.org> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 83CEA293 X-Spamd-Result: default: False [0.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; MID_RHS_NOT_FQDN(0.50)[] X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 18:10:42 -0000 Adhemerval Zanella, le jeu. 27 janv. 2022 15:09:29 -0300, a ecrit: > > > On 27/01/2022 14:15, Samuel Thibault wrote: > > Hello, > > > > Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit: > >> On 27/01/2022 13:11, Florian Weimer wrote: > >>> * Adhemerval Zanella: > >>> > >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the > >>>> controlling terminal), so it would make more sense to actually fit > >>>> it on the file actions API. > >>>> > >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is > >>>> implicit by the presence of tcsetpgrp file action. > >>>> > >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present. > >>>> > >>>> Checked on x86_64-linux-gnu and i686-linux-gnu. > >>> > >>> This has an ABI check failure on Hurd: > >>> > >>> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 > >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 > >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt > >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F > >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F > >>> > >>> The changes look okay to me. A second review is probably warranted at > >>> this stage. > >> > >> Thanks. It is really annoying that hurd make update-abi adds a bunch of files > >> and requires manual edit to get it right. > > > > I don't think I understand. How is it different in the linux case? > > A 'make update-abi' with a default 'configure --prefix=/usr' creates two > files on source: > > $ git status > On branch master > Your branch is up to date with 'origin/master'. > > Changes not staged for commit: > (use "git add ..." to update what will be committed) > (use "git restore ..." to discard changes in working directory) > modified: sysdeps/mach/hurd/i386/libc.abilist > modified: sysdeps/mach/hurd/libhurduser.abilist > modified: sysdeps/mach/libmachuser.abilist > > And the libc.abilist is jsut annoying by the fact Hurd seems to use a different > default path than Linux ports (which generates an _nl_default_dirname with > different size). > > Am I doing something wrong with the Hurd build? Probably not, I didn't even know about the update-abi target. Samuel