From: Samuel Thibault <samuel.thibault@gnu.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: commit-hurd@gnu.org, GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [hurd,commited] hurd: Fix static-PIE startup
Date: Tue, 1 Feb 2022 01:58:27 +0100 [thread overview]
Message-ID: <20220201005827.nkkoafc6vip4anmj@begin> (raw)
In-Reply-To: <CAMe9rOowdnJaNWug534CcE0etzprDRT0r6Kj0nJU690RRPo6nw@mail.gmail.com>
H.J. Lu via Libc-alpha, le lun. 31 janv. 2022 16:53:19 -0800, a ecrit:
> On Mon, Jan 31, 2022 at 4:49 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > H.J. Lu, le lun. 31 janv. 2022 16:14:59 -0800, a ecrit:
> > > > +#define SET_RELHOOK(NAME, HOOK) \
> > > > + asm(".section " #NAME",\"aR\"\n" \
> > > > + ".quad "#HOOK" - .\n" \
> > > > + ".section .text");
> > > > +
> > > > +#endif /* set_hooks_arch.h */
> > >
> > > SET_RELHOOK is used only for hurd which doesn't support x86-64.
> >
> > We plan to support x86-64 relatively soon.
> >
>
> Then please put it under the x86-64 directory for hurd. It doesn't
> belong to sysdeps/x86_64.
Why not? The problem is the same for all x86-64 ports, it's not
specific to the Hurd port. It happens that DEFINE_HOOK is not widely
used in the glibc, and notably not for initialization steps that are
before the csu relocation. But that's still something that could happen
someday. Why hiding this solution behind a hurd/ directory?
Samuel
next prev parent reply other threads:[~2022-02-01 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:42 Samuel Thibault
2022-02-01 0:14 ` H.J. Lu
2022-02-01 0:49 ` Samuel Thibault
2022-02-01 0:53 ` H.J. Lu
2022-02-01 0:58 ` Samuel Thibault [this message]
2022-02-01 14:19 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201005827.nkkoafc6vip4anmj@begin \
--to=samuel.thibault@gnu.org \
--cc=commit-hurd@gnu.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).