From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40071.outbound.protection.outlook.com [40.107.4.71]) by sourceware.org (Postfix) with ESMTPS id 6535C3858D35 for ; Thu, 3 Feb 2022 18:34:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6535C3858D35 Received: from AM6P195CA0050.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::27) by DB6PR0802MB2165.eurprd08.prod.outlook.com (2603:10a6:4:86::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb 2022 18:34:33 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::43) by AM6P195CA0050.outlook.office365.com (2603:10a6:209:87::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11 via Frontend Transport; Thu, 3 Feb 2022 18:34:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend Transport; Thu, 3 Feb 2022 18:34:33 +0000 Received: ("Tessian outbound 2877e54fe176:v113"); Thu, 03 Feb 2022 18:34:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 605d7cd8b9bb6f6b X-CR-MTA-TID: 64aa7808 Received: from 0501d80e3c7a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA0BC165-F06E-4B65-AA22-A34DE91CE046.1; Thu, 03 Feb 2022 18:34:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0501d80e3c7a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Feb 2022 18:34:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M29z+1G4T82GsJZh8yrzGBewh6aYZaZHYd6Zr0OTbhJi1G33HHECK2BQbXdqJ34xDba8yo/2u9YjugCQIHMYsFm3OZOAnUvBUeGRKbWG9rGIdNlyPq0kSD7R8nG9lmJLt1LxPnexWI33/wPmugJUgPoHyrs7HJS2LEu2XDaoWLq8oPGXoNy/qRzvMihBL9IO8Yizhfx3kXUc19quHwf5CUUgNFkhBuYvlUbswktUSWspyt4AfbR7WWjukfWo5N6ZRxriUFt6rhLOrh4XEcsVgWhm6PAa/JDgLdelK6lBFzo12MnJs/VZef6qguEoAWjxaMzcwJAxPHCw27AOytcy/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q9dl5MlsEj8V5tLlbyW59NsTj1p2mTg0dGCCgLTXKV4=; b=gnT4a8stSc6huyiydAEsxFpdcE4YK9m1G7u43IvoUKPNULkmccBPFhkum8szssiC24EAVW/VMQq0geFwrUpPJHnWMWLSX1S//lJF1g9WZub4sG/wnJc7bnNEs0LFaFs/HxgA4Sq5VQEr3Uo5agI002z4VbbXOjWgMe8m0SmRZHaeU6zziJyneSJ5QWSS9k4rY5nIaifif/KwuGBGWFhhY1XS3BshJUoQlWnEH1MnVidX5I6WlQguqf8ONo0fBQk4hEgOka/vV2C9P8mE0ICHwyEheH2Q31ITv2RK2WfkMvadI/dfrom0uz46xTCwJ/JzrLdQY9/UWA1xuDb2LvHxjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by VI1PR0801MB1711.eurprd08.prod.outlook.com (2603:10a6:800:4e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb 2022 18:34:10 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::dca:9146:2814:3f63]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::dca:9146:2814:3f63%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 18:34:09 +0000 Date: Thu, 3 Feb 2022 18:34:02 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Florian Weimer Subject: Re: [PATCH v6 3/3] Linux: Only generate 64 bit timestamps for 64 bit time_t recvmsg/recvmmsg Message-ID: <20220203183402.GN1989194@arm.com> References: <20220128175043.161446-1-adhemerval.zanella@linaro.org> <20220128175043.161446-4-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220128175043.161446-4-adhemerval.zanella@linaro.org> X-ClientProxiedBy: SN7PR04CA0060.namprd04.prod.outlook.com (2603:10b6:806:120::35) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6bbf5514-dee2-4138-a644-08d9e743d2e1 X-MS-TrafficTypeDiagnostic: VI1PR0801MB1711:EE_|AM5EUR03FT014:EE_|DB6PR0802MB2165:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: F+29oyX3Cv3zi1sRmRmMHscbS+uJ5hPAUR5jGpv5vmqN8d25ycKVVgJm2c9k4l4x9+KINu3aDoIzBQwIeE8jzBaUdaQH8JkkV66SotXjJRcc9pvU9j3kyJYVb5sibYLS9xeiAkXej5whugsMIT8CV+RnznYRotKBdrFAsa5xrXWuxx3zw1QiLaDi24shcrTJsDdAM5tsHaA1DmpR0Td0cR4BbnyinMOvie167HXpUrMWnegEAvvv6XAX5Qhx2/ToVVwIREyWCB4u8OOB58lPRxfl/PRSqKm5tOfsQcfIMm8QXmQ90aRY9UHq1ZyXmRjU6ZQAxQoXn6aMHHR5W+m0UnhmISkJz47tB5++wy890LZKstbtYKXtGQvAbleM7xBWbhXZICwpMj6Fijs1a639teq9PNqPvoKfTnP4q95+/kqeFapuSvhMVRDqkto3Ksd+6A7+ejdBqyXAeC0jkdMD4w15+vxqGckfknUtnlausbjkikbau2iPhmewXvdqGZXY1VtHKKF4PQAL03NjMZHcl82pPXPKnAfKXabUYhtkP9YhBA8nPuAuuaQudt+mmxntt3jfA70euBEKQM9mlshJlMnZcy4SyvRzt4DWPii9xf98FRq2f0514K5Rrh08MTmVRqQatQXkEnuOb2pTvI/dSdXJqLv/puUNU6CvqvgvSLb5V0w71KcmJ9AZL4WJiV8C1anrUSYRNcpTW7pNgrKPKr9QdGmgr06X3GTaizpCwV8xseVFYzcTFocBitxuMWpmMKiXnyA6xdxLB85KenEZ0yvyC7MCx4kPi6JWRVax5BPCTZhoNxQ5R7i4VN8Wrtxo X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(2616005)(966005)(6486002)(33656002)(6512007)(2906002)(186003)(1076003)(86362001)(26005)(6666004)(6506007)(52116002)(36756003)(66556008)(66476007)(8936002)(8676002)(4326008)(66946007)(5660300002)(6916009)(38350700002)(38100700002)(44832011)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1711 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5510516d-ee5f-4298-0eef-08d9e743c4a2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AFNkabwMxQvcNEA+mGKzP0kGegASJK8w/s8ULmBeGwQyhh956UdM2hpGb4KzCWudtzilWvd6mbfUTddtDcYZMAOJl9NMCD0I2DwL0VBH9BDsyIGu6fOzRvzC3Jb0ljmgEswtpjuihMqOym25X7lmVTR+6IbFx2M9dcLCdK2PYLUHdhAK1A6hefRB9JpW2hoqjMXZD/iUgbHNvu9s3yU7NIjvWj1G4lwOF1a++W7yagKaphLY+aSvxNloOh9VKQOOKiAW8pFFmLZB61fgO03EaYVv50/kKHyl9EsIw6GJsvmE3g6rbKaqrUAsyzJH8kK/E4F1UpNxtZyn1Sb/sldmi/2MVFnWoYUDAazhzJJ91jBNDmWSmk1AjlWR7Ev4q/jMGytIUkufhc6MBXkx0BLuerxAfWLfjLhR1ntIVqHeeYHExbts8ySBY31eoQWOvJLc1u54oI0FnXfCo5OropWjrKoPwZJ7WBYxO1diVyewjvnfK76vjUacoI6GGRZQJnDutTMmlTixXqyJDxmGLyRp3QuzVUIm6NDe+KhRhaqo8BW99b318ZDkUOrI8DrgghXQPEf1g0HA3nvYAl27jJt6MY7K8kpnBtgQ68LJn7+phXBVfsrHTzp6F3Yd9mDJK/Mzfzk0ffZ941AmAg9TaWcdZbtm0cv51MbXwVK0T1sFyZHfmxI4ye0NJtaN5+5+CHdEpzYqFb8kfaQ4Rp3AP66M4zW4lc+oqfoL4yvF+JAXqx2tD9YSnRXf9g09Ff0I12jA6jhVijU4k/jFO2g6KpvvyZ9Yyf/AOwLDc/NyWnR6igc= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(40460700003)(4326008)(8936002)(8676002)(47076005)(44832011)(70586007)(36860700001)(2906002)(316002)(81166007)(508600001)(82310400004)(70206006)(6512007)(6666004)(6506007)(107886003)(5660300002)(33656002)(6862004)(356005)(336012)(6486002)(36756003)(26005)(966005)(186003)(2616005)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 18:34:33.5527 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6bbf5514-dee2-4138-a644-08d9e743d2e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2165 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2022 18:34:46 -0000 The 01/28/2022 14:50, Adhemerval Zanella via Libc-alpha wrote: > The timestamps created by __convert_scm_timestamps only make sense for > 64 bit time_t programs, 32 bit time_t programs will ignore 64 bit time_t > timestamps since SO_TIMESTAMP will be defined to old values (either by > glibc or kernel headers). > > Worse, if the buffer is not suffice MSG_CTRUNC is set to indicate it > (which breaks some programs [1]). > > This patch makes only 64 bit time_t recvmsg and recvmmsg to call > __convert_scm_timestamps. Also, the assumption to called it is changed > from __ASSUME_TIME64_SYSCALLS to __TIMESIZE != 64 since the setsockopt > might be called by libraries built without __TIME_BITS=64. The > MSG_CTRUNC is only set for the 64 bit symbols, it should happen only > if 64 bit time_t programs run older kernels. > > Checked on x86_64-linux-gnu and i686-linux-gnu. > > [1] https://github.com/systemd/systemd/pull/20567 i think this can cause a build issue on 32bit timesize targets: https://sourceware.org/bugzilla/show_bug.cgi?id=28860