From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00086.outbound.protection.outlook.com [40.107.0.86]) by sourceware.org (Postfix) with ESMTPS id 2B3213858416 for ; Mon, 21 Feb 2022 16:39:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B3213858416 Received: from DB6PR0202CA0012.eurprd02.prod.outlook.com (2603:10a6:4:29::22) by DBBPR08MB6188.eurprd08.prod.outlook.com (2603:10a6:10:1f6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Mon, 21 Feb 2022 16:39:29 +0000 Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::db) by DB6PR0202CA0012.outlook.office365.com (2603:10a6:4:29::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26 via Frontend Transport; Mon, 21 Feb 2022 16:39:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.20 via Frontend Transport; Mon, 21 Feb 2022 16:39:29 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Mon, 21 Feb 2022 16:39:29 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9133a1f197ca5922 X-CR-MTA-TID: 64aa7808 Received: from ebd2852f9c1a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0F87F34B-5DD5-4C7C-A166-FE6D641BB67D.1; Mon, 21 Feb 2022 16:39:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ebd2852f9c1a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Feb 2022 16:39:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elr+CUWGYBQNPD1OAcdTBcn+wnkMbNc27UrrJtq3rSV1FlPKpZ7uaJodNvHWQPu3eksLohhGvYViSvwwf79SFEUCYWZ9S3DKnnqXHnleRyfDlH18cmB24RNKgH/nqnDut8tR7Is5aW+yp4aZWUreIn3T97z9wKBIiF80wtw6vg58QlpVuIe1xZHxGLtkL14DYHtO/KEfluLMQEzLk3Sk1sxQtaKUP3S1NDl0fePBvoTQjAqYXwu8FpcEDcvsDysoUuyv+un0NRPrJjB1azTi6L+s2UJBByV8rshw1fc4wiQL1jBhMu3o8REj1IqVRELQlygtXUQoFXiCo8dDELBIOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Jq6F8jW/4eRNQpi/RNY11EIRZ6BrIkIoHBKMQq5kIo=; b=YypCrLL511kA1+IHYRVgcZ4QMG7AJdamnBkExdIAW6GiVyPERJpFsmkvcBc4345X78oZoUXsYIM+M7KI0y9OPLtHU5O3OnpgUz+AcqGq+55LX3gdBe6xpc/Xs1HSXOhDQF4zfpPe9T+NcmacXzPEipd74XwnUeSYzUIanMNAxkWlubQ3bJK4iEYd3ajGMtj32mEKpSGJCt5jKi5yzXI/UcxdbUa67VD3IfklRF0H0iLi9UBlYgZlu7MNqJQl9kW1/mkQpnRssKqM2TYK9cmUofLhR5c6OvGjRD3NmOjI6zzg5rVmBstazhDq3A4oGaCgowH6U9mZ9vqV2CkxyeDMLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by VI1PR08MB4574.eurprd08.prod.outlook.com (2603:10a6:803:e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Mon, 21 Feb 2022 16:39:12 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::dca:9146:2814:3f63]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::dca:9146:2814:3f63%7]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 16:39:11 +0000 Date: Mon, 21 Feb 2022 16:39:04 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Wilco Dijkstra , "H . J . Lu" , Noah Goldstein Subject: Re: [PATCH 00/12] Remove bcopy and bzero optimizations Message-ID: <20220221163904.GL2692478@arm.com> References: <20220210195838.1036012-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220210195838.1036012-1-adhemerval.zanella@linaro.org> X-ClientProxiedBy: SA0PR11CA0190.namprd11.prod.outlook.com (2603:10b6:806:1bc::15) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b39d5165-2bdf-4c68-7d9f-08d9f558bb17 X-MS-TrafficTypeDiagnostic: VI1PR08MB4574:EE_|DB5EUR03FT010:EE_|DBBPR08MB6188:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VzaagW1wYzj3SL5xzaUa6E+5/XGXRBK5+gBOmRYekSPo3SjtZoPs2urv2Jd0q3O5wyz3pV+F3pPixl6bgs1NspAXBqP+VHvhnWBfcRHNCUBhFO/uev6X+K9dspPwSBfC+O9JJtGEgVtqe/Car6sFD0F/10DgSzRacKunluxT1lMw6cc8ZdxY7MZXI2Zb9OjHncEb+q43qeWzf42qkhjy2SWahZEZpVqoNzfPkrVueg7VlgaHhmPD5FzJ8gxDeAP9P7+ULimDnkxBuKgKgwYnzvV6QMKH/0Dw0Iur9d4WU8fHmJeyfAQY727ma3D+dPQC5J9v8tedqMcDmhk6fKuKDbF9+1NsL9c0L5woC0+K8uWVAFDRex8LWNhUmAqmvWjq6ad5fZapkWOPY95MGBij3TKfJDnctPlVXUIpNYlJo+JOzcTLSkB3cjnXR4KPDYh3QnV7sbGnesbl0kKgE+kMiXqNi/FUb4HO8sQcO5xm6v0oat7fEYc4XlN6XAvHKj0xt+Ihm8/SguN5M3X2907HYw1LxSb6j7Z2pcLtISBuJOJ0aeJDsdV+OSKgEyyn2KV2qa4cONu/uGkPpygeebqcETNAiHSIU4FYB6aya6B9IdMb4aywIY+bzDXcqP+YP8z8VIZWJx8JGZNTu9YiyF8CP6xfP9He2grU9J5jZHbbHOhfs1LriEriF6k7WaNGyMFMBdDF6ni5v3p8AzLa/M6BNA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52116002)(186003)(66556008)(66946007)(6512007)(54906003)(6916009)(2616005)(1076003)(6506007)(26005)(6486002)(8676002)(508600001)(316002)(6666004)(66476007)(86362001)(4326008)(38100700002)(38350700002)(5660300002)(8936002)(33656002)(2906002)(44832011)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4574 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03ec11c9-f94c-4926-8d6d-08d9f558b036 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vJ/Mqi4MoNRUQ9cQHxnJelL1hjhC4w9MUDTRWFYJu74EUkegYGe3QRsphYmh0Hi5bMAEmDrHk6BZPwvL9SXFtznVjNutj8yzr5fMl/vwx9YQbIaB+t5S3/HfVtrn/AO7Eo0rFVRkQe+acFSg5fxYtgyClfadgZ/iuyvc/Ie2msb+cO3wYYTZlvlZqE5wPmCisw2/Clp9DkVHxXKNrW6pXDyNjSgeTtn7TK/Bi2xOJCyrXp6dz/sgboUpCcl4vJtxQcOkTLul2m97f+RbgWZdGYeryq/YSt2qEDzh2ExObTslq67ua13E9b39bEqDu9BmIkAK8HAIohw8pxXFL2Tk19in4bHknoJNNcaV0F4Rfcni0PTCew3Pg+m1quYHNuXZHli+3Vj14EmUglRLMqJenetGsSu8frvDPemhskoDkawNWFhLU8oQm0kNfAEQ9iZrYBInve5FlO4oMOev8UdTI1NPTWyRQG7I3kUimFw5xag19uOFtmZKsDhv5uR+S6FKNbopargBAoKbtwPXrtwb9QXNs2OcQNhFLJuHuwpFJTVBmg05xVDxBaLq5SLsLb0Ujqp566cjG6nzk8aKnagX7G5A/fXWSyLflaQewUZ1+k5tZq/ljkGUCdiRYfjBjSue9hP3OAWA88rnbTpd5gZxGCH6cD45tcGrJBz7TDDNbBVv/aw99xaEzWorkkMJV0/1 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(36756003)(33656002)(6666004)(508600001)(40460700003)(6506007)(6486002)(6512007)(107886003)(47076005)(36860700001)(2616005)(2906002)(5660300002)(1076003)(186003)(8676002)(4326008)(54906003)(26005)(8936002)(316002)(44832011)(356005)(82310400004)(86362001)(336012)(81166007)(70586007)(70206006)(6862004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 16:39:29.4372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b39d5165-2bdf-4c68-7d9f-08d9f558bb17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6188 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 16:39:42 -0000 The 02/10/2022 16:58, Adhemerval Zanella via Libc-alpha wrote: > Both symbols are marked as legacy in POSIX.1-2001 and removed on > POSIX.1-2008, although the prototypes are defined for _GNU_SOURCE > or _DEFAULT_SOURCE. > > Most architectures just route bcopy/bzero to internal memmove/memset > implementation, however some do implement iFUNC variants when memset > or memmove are also provided through iFUNC. > > However, gcc already replaces bcopy with a memmove and bzero with memset > on default configuration (to actually get a bstring libc call the code > requires to omit string.h inclusion and built with --fno-builtin), so > it is highly unlikely programs are actually calling libc bcopy or > bzero symbols. ... > So there is point in keeping such optimization. > > Adhemerval Zanella (12): > ia64: Remove bcopy > powerpc: Remove bcopy optimizations > i386: Remove bcopy optimizations > x86_64: Remove bcopy optimizations > alpha: Remove bzero optimization > ia64: Remove bzero optimization > Remove bzero optimization > powerpc: Remove powerpc32 bzero optimizations > powerpc: Remove powerpc64 bzero optimizations > s390: Remove bzero optimizations > i686: Remove bzero optimizations > x86_64: Remove bzero optimizations i see this does not affect aarch64, but i agree with the principle. (there was a comment about the x86 bzero code that if __memsetzero is accepted then it's easier to rename the bzero optimization instead of removing and readding.)