From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F9753948450 for ; Thu, 24 Feb 2022 21:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F9753948450 Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-Y6RlVWlFOxCteZLymEVysw-1; Thu, 24 Feb 2022 16:46:23 -0500 X-MC-Unique: Y6RlVWlFOxCteZLymEVysw-1 Received: by mail-qv1-f71.google.com with SMTP id kl13-20020a056214518d00b0042cb237f86bso4305487qvb.0 for ; Thu, 24 Feb 2022 13:46:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jBXgVh6kM7V4ytu8dlrK41asw8gYrrzCoa+W5NnVvUw=; b=Q28MjDJNlyciPscft725rk6ANygmbfdh1nGVTwa2u33GvXQsTdAtbnRisnIDg1maXv 3YZpcsFBSDv7yBFs4vm2ER8FmGjeMpgoCS7oqOSde6btGJhmYcp4oSmXvckaK9I/oZEe YjztYh3qs0zkoUZHGOCC1cx1Lvck3009Xj4uJuv2hShhj88ZbHhh7/X8LGECZfZqdwsy 6SQk2bxB25gBP8tFOJRDQ6aKieUYhiblFbOK7VGU+Lx+kGAfZR3crpGe4K7qtGYBRpFa asapV88zQrMoAnk/4+PtWk/kxjeCOEEbSuu4cFh8v5gZQDh10jbeo7bly7vrJSk3OQWc xy4g== X-Gm-Message-State: AOAM531feBe++RpnJs7FkMJukbHqcqFNgb1WWxEyG1/SijTt+6L5Rhue ORoh2qoE0/UTXXaw8UZ1p/8fw24Rmjv9FsDzzfr4goGeVNBFInjU2R3Kf2nGrj+vIENdAqjpyRd 9wguw6XmXPjQEpXGIBbA0LTIJpLRFF7Lu19QxwBdU7E1bJVaDDxYBTkFTVr5i+C2NKxL2rw== X-Received: by 2002:ae9:e501:0:b0:62c:efb6:bbfe with SMTP id w1-20020ae9e501000000b0062cefb6bbfemr3054445qkf.429.1645739183093; Thu, 24 Feb 2022 13:46:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwp19fNzFLlHAf/7sKKzyO0CUuTKtRh0JpDeOP6kCFdCEjvqt4st5lJKZq1mnSSUy8b1Xn39Q== X-Received: by 2002:ae9:e501:0:b0:62c:efb6:bbfe with SMTP id w1-20020ae9e501000000b0062cefb6bbfemr3054427qkf.429.1645739182818; Thu, 24 Feb 2022 13:46:22 -0800 (PST) Received: from athas.redhat.com (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id f7-20020a05622a104700b002d4b318692esm316117qte.31.2022.02.24.13.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 13:46:22 -0800 (PST) From: Carlos O'Donell To: libc-alpha@sourceware.org, dj@redhat.com Subject: [PATCH v2 2/2] localedata: Do not generate output if warnings were present. Date: Thu, 24 Feb 2022 16:45:47 -0500 Message-Id: <20220224214547.911386-3-carlos@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220224214547.911386-1-carlos@redhat.com> References: <20220224214547.911386-1-carlos@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 21:46:27 -0000 With LC_MONETARY parsing fixed we can now generate locales without forcing output with '-c'. Removing '-c' from localedef invocation is the equivalent of using -Werror for localedef. The glibc locale sources should always be clean and free from warnings. We remove '-c' from both test locale generation and the targets used for installing locales e.g. install-locale-archive, and install-locale-files. Tested on x86_64 and i686 without regressions. Tested with install-locale-archive target. Tested with install-locale-files target. Reviewed-by: DJ Delorie --- localedata/Makefile | 4 ++-- localedata/gen-locale.sh | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/localedata/Makefile b/localedata/Makefile index 9ae2e5c161..7741ac3b5e 100644 --- a/localedata/Makefile +++ b/localedata/Makefile @@ -468,11 +468,11 @@ define build-one-locale endef $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir - @flags="-c"; \ + @flags=""; \ $(build-one-locale) $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir - @flags="-c --no-archive --no-hard-links"; \ + @flags="--no-archive --no-hard-links"; \ $(build-one-locale) tst-setlocale-ENV = LC_ALL=ja_JP.EUC-JP diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh index 7fce35f212..8053c816a6 100644 --- a/localedata/gen-locale.sh +++ b/localedata/gen-locale.sh @@ -54,8 +54,14 @@ modifier=`echo $locfile|sed 's|[^.]*[.]\([^@ ]*\)\(@[^ ]*\)\?/LC_CTYPE|\2|'` echo "Generating locale $locale.$charmap: this might take a while..." -# Run quietly and force output. -flags="--quiet -c" +# Do not force output with '-c', all locales should compile without +# warning or errors. There is likewise no need to run quietly with +# '--quiet' since all locales should compile without additional +# diagnostics. If there are messages printed then we want to see +# them, fix them, and the associated error or warning. During +# development it may be beneficialy to put '--quiet -c' here to allow +# you to develop in-progress locales. +flags="" # For SJIS the charmap is SHIFT_JIS. We just want the locale to have # a slightly nicer name instead of using "*.SHIFT_SJIS", but that -- 2.34.1