From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 62C153858D37 for ; Wed, 2 Mar 2022 19:31:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62C153858D37 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 222IlfPl018929; Wed, 2 Mar 2022 19:31:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3eje5ygt6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Mar 2022 19:31:03 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 222JV2do009134; Wed, 2 Mar 2022 19:31:02 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3eje5ygt60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Mar 2022 19:31:02 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 222JHGFr005777; Wed, 2 Mar 2022 19:31:00 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04wdc.us.ibm.com with ESMTP id 3eftrrrw3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Mar 2022 19:31:00 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 222JUwC729950256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Mar 2022 19:30:58 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F2BE11207D; Wed, 2 Mar 2022 19:30:58 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF343112065; Wed, 2 Mar 2022 19:30:56 +0000 (GMT) Received: from workbox (unknown [9.160.111.131]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTPS; Wed, 2 Mar 2022 19:30:56 +0000 (GMT) Date: Wed, 2 Mar 2022 16:30:48 -0300 From: Raoni Fassina Firmino To: Adhemerval Zanella Cc: "Lucas A. M. Magalhaes" , libc-alpha@sourceware.org, fweimer@redhat.com, tuliom@linux.ibm.com Subject: Re: [PATCH] powerpc: Use FLAG_ELF_LIBC6 for 32-bit known libraries Message-ID: <20220302193048.laaynlw7k3dzcz67@workbox> Mail-Followup-To: Adhemerval Zanella , "Lucas A. M. Magalhaes" , libc-alpha@sourceware.org, fweimer@redhat.com, tuliom@linux.ibm.com References: <20211022211201.983646-1-lamm@linux.ibm.com> <20211104181039.97106-1-lamm@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hXTEJsU3v0crwqXCZBCDEoDjzHm7-my6 X-Proofpoint-GUID: 4oZFyhVM1OIF8ovLvy311f63X891qLjO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-02_12,2022-02-26_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 clxscore=1011 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203020082 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 19:31:09 -0000 On Fri, Dec 03, 2021 at 11:51:29AM -0300, AL glibc-alpha wrote: > > > On 04/11/2021 15:10, Lucas A. M. Magalhaes via Libc-alpha wrote: > > In systems with more versions of the known libraries, i.e. on IBM > > Advance Toolchain, ldconfig will order them incorrectly on ld.cache. > > > > The issue only occurs with 32-bit libraries that don't depend on libc or > > libm. That's because process_elf32_file check if the elf depends on one > > of the libraries at known_libs to select the elf flag. For example, as > > libc.so.6 don't depend on itself or on libm it will be flagged as > > FLAG_ELF instead of FLAG_ELF_LIBC6 as expected. > > Wouldn't be simpler to check if the DT_SONAME matches any on 'known_libs' after > dynamic section parsing and set the appropriated flag on generic 'process_file'? But then it would touch every architecture, I think since this is only a problem affecting powerpc (BE 32bits) I don't think it is worth touch the generic code if will not help any other architecture. > (also powerpc SYSDEP_KNOWN_LIBRARY_NAMES seems redundant). Seems to be the same as every other arch except i386. Lookin at Lucas's RFC for removal of libc.5 and libc.4 compatibility, maybe it being diferent in i386 is just that it was never really used anymore, and so never updated. o/ Raoni