From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id 2C5D53858D35 for ; Sun, 6 Mar 2022 19:28:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C5D53858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aquilenet.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aquilenet.fr Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 52834205; Sun, 6 Mar 2022 20:28:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P16dqH5ZTxZp; Sun, 6 Mar 2022 20:28:47 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 3065AEE; Sun, 6 Mar 2022 20:28:47 +0100 (CET) Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1nQwYg-0010sX-ME; Sun, 06 Mar 2022 20:28:46 +0100 Date: Sun, 6 Mar 2022 20:28:46 +0100 From: Samuel Thibault To: Florian Weimer Cc: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [hurd] update-abi Message-ID: <20220306192846.2citaihjzkbnnf2h@begin> References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> <20220127171557.kseob4ysn5tgcsg4@begin> <9cba4ff5-49c6-e597-85f5-45be0021bfa7@linaro.org> <20220128000731.ri4cbzkoxmyrft5o@begin> <877d9dondw.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877d9dondw.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 52834205 X-Spamd-Result: default: False [0.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; MID_RHS_NOT_FQDN(0.50)[] X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2022 19:28:53 -0000 Florian Weimer, le mar. 01 mars 2022 13:42:03 +0100, a ecrit: > * Samuel Thibault: > > > Adhemerval Zanella, le jeu. 27 janv. 2022 15:09:29 -0300, a ecrit: > >> On 27/01/2022 14:15, Samuel Thibault wrote: > >> > Adhemerval Zanella via Libc-alpha, le jeu. 27 janv. 2022 14:04:28 -0300, a ecrit: > >> >> On 27/01/2022 13:11, Florian Weimer wrote: > >> >>> * Adhemerval Zanella: > >> >>> > >> >>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the > >> >>>> controlling terminal), so it would make more sense to actually fit > >> >>>> it on the file actions API. > >> >>>> > >> >>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is > >> >>>> implicit by the presence of tcsetpgrp file action. > >> >>>> > >> >>>> The posix/tst-spawn6.c is also fixed when TTY can is not present. > >> >>>> > >> >>>> Checked on x86_64-linux-gnu and i686-linux-gnu. > >> >>> > >> >>> This has an ABI check failure on Hurd: > >> >>> > >> >>> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 > >> >>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 > >> >>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt > >> >>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F > >> >>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F > >> >>> > >> >>> The changes look okay to me. A second review is probably warranted at > >> >>> this stage. > >> >> > >> >> Thanks. It is really annoying that hurd make update-abi adds a bunch of files > >> >> and requires manual edit to get it right. > >> > > >> > I don't think I understand. How is it different in the linux case? > >> > >> A 'make update-abi' with a default 'configure --prefix=/usr' creates two > >> files on source: > > > >> modified: sysdeps/mach/hurd/libhurduser.abilist > >> modified: sysdeps/mach/libmachuser.abilist > > > > Ok, would the attached patch be ok? We do not track ABI on these libs. > > Why is there no tracking? Because the libmachuser and libhurduser content is generated from the .defs files provided by the gnumach and hurd sources (you can think of this as a list of system calls), so they are moving at their own pace, and the precise list will depend on the precise hurd upstream version that one is using, not on the glibc source. Yes, this is suboptimal for symbol tracking, but more flexible for development than hardlisting everything. https://sourceware.org/bugzilla/show_bug.cgi?id=23286 Samuel