From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 51DDF3899427 for ; Mon, 21 Mar 2022 21:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51DDF3899427 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-dda559a410so112740fac.3 for ; Mon, 21 Mar 2022 14:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6OIb8Zov1Gm7UqKBymxUdiEC8CmG2TRj2weOyPIihDk=; b=OXlkiHC5us5JMx64nucXk+JqiZGKOWUHMCD8bNIvo15mbH34niFs3jTbEvMTPFHh4V uKcLFYBktZq1LJIPukbztMkTbLQ9SvE3etrMqWGsxooYGtbmNDO86fjWJ7kQpYGtMLu4 slpi9je+ghnhkThHXcse8FiNt4VaYvh4OWRCbjnI5HSiycIL9W0EXK9zXZUPz4Jfgohe fjQiYdaaKZIMMPs+du4WaXb9baugB5w/lO5DE2tFI3S5ZJ25TOQ/a5p0zPOAgLFirSeG oDvAkmv/zb8zOHAz/8x8WnxqEI9Sn8rd7Xn/KXllsOcrmTOHQ8ADrjzZK+970lvmaHaZ tbTg== X-Gm-Message-State: AOAM533Mfp0g9lvP+do/0pwVgNa15UA++aiKPM8WyNZJhL/MRqUXUKFo u9A05NNUhta7RJDJy+yd5/uRsiNmFCWnVg== X-Google-Smtp-Source: ABdhPJyNq2ijiew3Wx87SMGNUwS2lLvK3JxiJazzFyBVuKkFXhaDUi4VEkFO0Oie9HuXnyJ/9n3fFA== X-Received: by 2002:a05:6870:d0c4:b0:dd:c7f6:2d62 with SMTP id k4-20020a056870d0c400b000ddc7f62d62mr424477oaa.99.1647897568089; Mon, 21 Mar 2022 14:19:28 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:2d55:d5f9:2c96:1f30:1f58]) by smtp.gmail.com with ESMTPSA id c37-20020a9d27a8000000b005b23cf22e23sm7925256otb.42.2022.03.21.14.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 14:19:27 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Paul Eggert Subject: [PATCH v5 6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) Date: Mon, 21 Mar 2022 18:19:12 -0300 Message-Id: <20220321211913.2347924-7-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220321211913.2347924-1-adhemerval.zanella@linaro.org> References: <20220321211913.2347924-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 21:19:30 -0000 There is no easy solution as described on first comment in bug report, and some code (like busybox) assumes facilitynames existance when SYSLOG_NAMES is defined (so we can't just remove it as suggested in comment #2). So use the easier solution and guard it with __USE_MISC. --- misc/sys/syslog.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/sys/syslog.h b/misc/sys/syslog.h index dc3b0e7ef8..d933fea104 100644 --- a/misc/sys/syslog.h +++ b/misc/sys/syslog.h @@ -62,7 +62,7 @@ #define LOG_PRI(p) ((p) & LOG_PRIMASK) #define LOG_MAKEPRI(fac, pri) ((fac) | (pri)) -#ifdef SYSLOG_NAMES +#if defined SYSLOG_NAMES && defined __USE_MISC #define INTERNAL_NOPRI 0x10 /* the "no priority" priority */ /* mark "facility" */ #define INTERNAL_MARK LOG_MAKEPRI(LOG_NFACILITIES << 3, 0) @@ -118,7 +118,7 @@ CODE prioritynames[] = /* facility of pri */ #define LOG_FAC(p) (((p) & LOG_FACMASK) >> 3) -#ifdef SYSLOG_NAMES +#if defined SYSLOG_NAMES && defined __USE_MISC CODE facilitynames[] = { { "auth", LOG_AUTH }, -- 2.32.0