From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id A87283858C50 for ; Wed, 30 Mar 2022 00:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A87283858C50 Received: by mail-pj1-x1033.google.com with SMTP id mp6-20020a17090b190600b001c6841b8a52so492731pjb.5 for ; Tue, 29 Mar 2022 17:27:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zAdyvfkIy5BcHBVScMszB7RKorbD/yqKciWXJ2GUJ4A=; b=pzpZK58mHHz5yauKU32rZdzJSbptj0xzImRgzDdBlY8wNL3OYdjHm0HCArFlaeqG1v hJXl6udnYnwn9QHc4i7Ec2kjOQ/ZQva72455VNkmQiGN8pYRuYa5DsYVJNiz4vnnjBIe xGc0aIhA9Nm4mCPXj3TdLOtKy68d3QCkH/Gk2CCyX2esbVq5EYpjD8CGmMPKOzpF+b0f 7GIakcZfSAJvkheUbvUCxIQIvYVI0EbgL4JMwBUuFdDTrYhpguDFTnBGEN5JHImRmDMQ LQAA/1VCCrvukLm6Ug7PJLWIc47NlbKTNUXsbQGh9iO4tD+8DSlkHbvhmk/93YIQDxM6 KDHA== X-Gm-Message-State: AOAM533QIsz2YrgyBTTl/Qs+5lUxfpZpmHGEN9c7DtBehqGTvWJR1rg9 45pBRSAatRJmrZscx7aLnDTQWkLyp50M4A== X-Google-Smtp-Source: ABdhPJyKyhwu+KgG79UtrGwYyBdVFOw9GKNX74ONh+eptK4OMQ+C3uwDhMKIrJhPOva/zZ6DqIgcQQ== X-Received: by 2002:a17:902:f70b:b0:14d:643d:9c99 with SMTP id h11-20020a170902f70b00b0014d643d9c99mr33514139plo.18.1648600023468; Tue, 29 Mar 2022 17:27:03 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:230b:6b73:c457:905c]) by smtp.gmail.com with ESMTPSA id i7-20020a628707000000b004fa6eb33b02sm20035687pfe.49.2022.03.29.17.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 17:27:02 -0700 (PDT) Date: Tue, 29 Mar 2022 17:26:59 -0700 From: Fangrui Song To: Noah Goldstein Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v1] Add .clang-format style file Message-ID: <20220330002659.wsttraxocz2o4av3@google.com> References: <20220328191254.913833-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220328191254.913833-1-goldstein.w.n@gmail.com> X-Spam-Status: No, score=-26.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 00:27:07 -0000 On 2022-03-28, Noah Goldstein via Libc-alpha wrote: >Went with version >= 9.0 since it covers most of the major features >and should be pretty universally accessibly. Why not 10.0? clang-format 10.0.0 has been there for two years. Using it will remove some clang-format >= 10.0 below. Related: Linux kernel now requires Clang >= 11.0. Since this patch introduces new tool, we can require higher versions. Installing new clang-format isn't so difficult for old systems. There are prebuilt packages even if the distro stops upgrading them. >There are some issues, particularly indention of preprocessor >directives. Unfortunately there doesn't appear to be a switch for >a seperate 'IndentWidth' for preprocessor directives vs. normal >code so we are stuck either not indenting the directives or >over-indenting them. https://github.com/llvm/llvm-project/issues/42264 "Feature request: Two different indentation width options, one for code, one for pre-processor directives" :( >Chose to over-indent as it generally seems easier >to script halving all pre-processor indentations than counting the >nested depth and indenting from scratch. Yeah, I picked over-indent for compiler-rt sanitizers as well https://reviews.llvm.org/D100238 >Other than the pre-processor directives most of the changes it makes >are cleaning up inconsistencies that already existed. >--- > .clang-format | 164 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 164 insertions(+) > create mode 100644 .clang-format > >diff --git a/.clang-format b/.clang-format >new file mode 100644 >index 0000000000..121b475dbd >--- /dev/null >+++ b/.clang-format >@@ -0,0 +1,164 @@ >+# clang-format file for GLIBC >+# Copyright (C) 2022 Free Software Foundation, Inc. >+# This file is part of the GNU C Library. >+# >+# The GNU C Library is free software; you can redistribute it and/or >+# modify it under the terms of the GNU Lesser General Public >+# License as published by the Free Software Foundation; either >+# version 2.1 of the License, or (at your option) any later version. >+# >+# The GNU C Library is distributed in the hope that it will be useful, >+# but WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >+# Lesser General Public License for more details. >+# >+# You should have received a copy of the GNU Lesser General Public >+# License along with the GNU C Library; if not, see >+# . >+# >+# Requires clang-format version >= 9.0 >+# >+# For more information, see: >+# >+# Documentation/process/clang-format.rst >+# https://clang.llvm.org/docs/ClangFormat.html >+# https://clang.llvm.org/docs/ClangFormatStyleOptions.html >+# >+# There are some known cases that this doesn't produce the desired >+# style (i.e Preprocessor Directives are over-indented and not >+# auto-commented). As a result, this is meant to be a utility to make >+# formatting easier, not a definitive standard. >+--- >+# BasedOnStyle: GNU >+AccessModifierOffset: -2 >+AlignAfterOpenBracket: Align >+AlignConsecutiveMacros: false >+AlignConsecutiveAssignments: false >+#AlignConsecutiveBitFields: false # clang-format >= 11.0 >+AlignConsecutiveDeclarations: false >+AlignEscapedNewlines: Right >+AlignOperands: true >+AlignTrailingComments: true >+AllowAllArgumentsOnNextLine: true >+AllowAllConstructorInitializersOnNextLine: true >+AllowAllParametersOfDeclarationOnNextLine: true >+#AllowShortEnumsOnASingleLine: true # clang-format >= 11.0 >+AllowShortBlocksOnASingleLine: false >+AllowShortCaseLabelsOnASingleLine: false >+AllowShortFunctionsOnASingleLine: All >+AllowShortLambdasOnASingleLine: All >+AllowShortIfStatementsOnASingleLine: Never >+AllowShortLoopsOnASingleLine: false >+AlwaysBreakAfterDefinitionReturnType: All >+AlwaysBreakAfterReturnType: AllDefinitions >+AlwaysBreakBeforeMultilineStrings: false >+AlwaysBreakTemplateDeclarations: MultiLine >+BinPackArguments: true >+BinPackParameters: true >+BraceWrapping: >+ AfterCaseLabel: true >+ AfterClass: true >+ AfterControlStatement: true >+ AfterEnum: true >+ AfterFunction: true >+ AfterNamespace: true >+ AfterStruct: true >+ AfterUnion: true >+ AfterExternBlock: true >+ BeforeCatch: true >+ BeforeElse: true >+ #BeforeWhile: true # clang-format >= 11.0 >+ IndentBraces: true >+ SplitEmptyFunction: true >+ SplitEmptyRecord: true >+ SplitEmptyNamespace: true >+BreakBeforeBinaryOperators: All >+BreakBeforeBraces: GNU >+BreakBeforeInheritanceComma: false >+BreakInheritanceList: BeforeColon >+BreakBeforeTernaryOperators: true >+BreakConstructorInitializersBeforeComma: false >+BreakConstructorInitializers: BeforeColon >+BreakStringLiterals: true >+ColumnLimit: 79 >+CommentPragmas: '^ IWYU pragma:' >+CompactNamespaces: false >+ConstructorInitializerAllOnOneLineOrOnePerLine: false >+ConstructorInitializerIndentWidth: 4 >+ContinuationIndentWidth: 4 >+Cpp11BracedListStyle: false >+#DeriveLineEnding: true # clang-format >= 10.0 >+DerivePointerAlignment: false >+DisableFormat: false >+ExperimentalAutoDetectBinPacking: false >+FixNamespaceComments: false >+ForEachMacros: >+ - foreach >+ - Q_FOREACH >+ - BOOST_FOREACH >+IncludeBlocks: Preserve >+IncludeCategories: >+ - Regex: '^"(llvm|llvm-c|clang|clang-c)/' >+ Priority: 2 >+ - Regex: '^(<|"(gtest|gmock|isl|json)/)' >+ Priority: 3 >+ - Regex: '.*' >+ Priority: 1 >+IncludeIsMainRegex: '(Test)?$' >+IndentCaseLabels: false >+#IndentCaseBlocks: false # clang-format >= 11.0 >+#IndentGotoLabels: true # clang-format >= 10.0 >+IndentWidth: 2 >+IndentPPDirectives: AfterHash >+#IndentExternBlock: AfterExternBlock # clang-format >= 11.0 >+IndentWrappedFunctionNames: false >+#InsertTrailingCommas: None # clang-format >= 11.0 >+KeepEmptyLinesAtTheStartOfBlocks: true >+MacroBlockBegin: '' >+MacroBlockEnd: '' >+MaxEmptyLinesToKeep: 1 >+NamespaceIndentation: None >+PenaltyBreakAssignment: 2 >+PenaltyBreakBeforeFirstCallParameter: 19 >+PenaltyBreakComment: 300 >+PenaltyBreakFirstLessLess: 120 >+PenaltyBreakString: 1000 >+PenaltyBreakTemplateDeclaration: 10 >+PenaltyExcessCharacter: 1000000 >+PenaltyReturnTypeOnItsOwnLine: 60 >+PointerAlignment: Right >+ReflowComments: true >+SortIncludes: false >+SortUsingDeclarations: true >+SpaceAfterCStyleCast: true >+SpaceAfterLogicalNot: false >+SpaceAfterTemplateKeyword: true >+SpaceBeforeAssignmentOperators: true >+SpaceBeforeCpp11BracedList: false >+SpaceBeforeCtorInitializerColon: true >+SpaceBeforeInheritanceColon: true >+SpaceBeforeParens: Always >+SpaceBeforeRangeBasedForLoopColon: true >+#SpaceInEmptyBlock: false # clang-format >= 10.0 >+SpaceInEmptyParentheses: false >+SpacesBeforeTrailingComments: 1 >+SpacesInAngles: false >+#SpacesInConditionalStatement: false # clang-format >= 10.0 >+SpacesInContainerLiterals: true >+SpacesInCStyleCastParentheses: false >+SpacesInParentheses: false >+SpacesInSquareBrackets: false >+#SpaceBeforeSquareBrackets: false # clang-format >= 10.0 >+Standard: Cpp03 >+StatementMacros: >+ - Q_UNUSED >+ - QT_REQUIRE_VERSION >+TabWidth: 8 >+UseTab: Never >+ForEachMacros: >+ - 'FOR_EACH_IMPL' >+ - 'list_for_each' >+ - 'list_for_each_prev' >+ - 'list_for_each_prev_safe' >+... >+ >-- >2.25.1 >