From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 42F2F3858405 for ; Wed, 30 Mar 2022 21:32:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42F2F3858405 Received: by mail-pj1-x1033.google.com with SMTP id o3-20020a17090a3d4300b001c6bc749227so1488586pjf.1 for ; Wed, 30 Mar 2022 14:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kUZ/ItoAjw2VICLkFohHovEe4nzhBsULXKB59BIyekE=; b=2+4BVi0gbWRjjpDmd/z1CVA4XQkKwJMZYzn33KS0kROmyv9eCwaDK3ePxcN+vzZf7J 5W5vTCBidwQE7/op5GxgNuztZFE1gTbZoTcw3winuBowFYr3qhAg+p5NQmgmBVZk0hNJ o7zPGMH40XYi+nIxqrPVrAVatBnOlYVb096abMO9UOqKm87DxvjVS7AdViq2Wf2OtiIT PEkyJic6zzgx7/+ASlJ6pWAiv8gx85JNHarpumJsb3XGKzvSLreycnu4AGgIiom/aZ5l ybM6UV57xd4jHHrw8J3UdFoROkMaLZh9yrSkC0HXu9YNpa+fFJhYRe0xrzB571qdkatn XjIw== X-Gm-Message-State: AOAM531vL0oJgxF1c6SZtyVm3zQWR0bxVsmv9XAbStyOVeJgiH/Qv8AU zPM2AHt+WTzA7pT2xEs4Qudk7g== X-Google-Smtp-Source: ABdhPJwht8lI7IoqdORjDzvecIOMvmzdHBlY77HsAmy7U6+DXOb3PQGZj1m6Pj3E7dcnAZ3UmIKCXQ== X-Received: by 2002:a17:90b:3e8c:b0:1c7:3001:f359 with SMTP id rj12-20020a17090b3e8c00b001c73001f359mr1786868pjb.179.1648675950027; Wed, 30 Mar 2022 14:32:30 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:925f:e947:f685:7815]) by smtp.gmail.com with ESMTPSA id k13-20020aa7820d000000b004fa72a52040sm24212302pfi.172.2022.03.30.14.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 14:32:29 -0700 (PDT) Date: Wed, 30 Mar 2022 14:32:25 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: Joseph Myers , GNU C Library Subject: Re: [PATCH v6 3/5] Add GLIBC_ABI_DT_RELR for DT_RELR support Message-ID: <20220330213225.xh6bepxgirlpppmy@google.com> References: <20220310200329.1935466-1-hjl.tools@gmail.com> <20220310200329.1935466-4-hjl.tools@gmail.com> <066eedff-b1d4-ec3c-3716-5846e2646f9a@linaro.org> <5f32b52c-508b-dcba-af9b-7ff248cc3c1d@linaro.org> <6ab38c98-b698-32a8-a9b9-6b70d59f745d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <6ab38c98-b698-32a8-a9b9-6b70d59f745d@linaro.org> X-Spam-Status: No, score=-21.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 21:32:32 -0000 On 2022-03-30, Adhemerval Zanella via Libc-alpha wrote: > > >On 30/03/2022 16:22, Joseph Myers wrote: >> On Wed, 30 Mar 2022, Adhemerval Zanella via Libc-alpha wrote: >> >>> But it still does not fail when the architecture does not actually implement >>> RELR even when static linker does: >> >> The dynamic linker is supposed to support executing binaries using RELR >> relocations on all architectures - there's not meant to be anything >> architecture-specific about that support. What's architecture-specific is >> the static linker support (thus, if missing in the static linker used to >> build and test glibc, then (a) the dynamic linker could still run binaries >> using RELR if they were built using some other static linker, but (b) none >> of the glibc binaries, either installed or test, will contain any RELR >> relocations themselves). >> > >Indeed, I was confused by the expected support. This part seems ok H.J. Agree. Having the generic support helps GNU ld developers to contribute RELR for non-x86. When I first seen "Add --disable-default-dt-relr" I was thinking whether it is necessary to add this so early, but then I realized that this essentially turns the whole glibc testsuite into tests for GNU ld's RELR support. binutils itself has very few run-time tests and bugs tend to be difficult to surface.