From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [COMMITTED] stdlib: Fix tst-getrandom memcmp call
Date: Thu, 31 Mar 2022 09:15:48 -0300 [thread overview]
Message-ID: <20220331121548.1551709-1-adhemerval.zanella@linaro.org> (raw)
The idea is to check if the up sizeof (buf) are equal, not only
the first byte.
Checked on x86_64-linux-gnu and i686-linux-gnu.
---
stdlib/tst-getrandom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stdlib/tst-getrandom.c b/stdlib/tst-getrandom.c
index 608fc4746e..61c3cae92e 100644
--- a/stdlib/tst-getrandom.c
+++ b/stdlib/tst-getrandom.c
@@ -189,7 +189,7 @@ test_getentropy (void)
/* The probability that these two buffers are equal is very
small. */
- if (memcmp (buf, buf2, sizeof (buf) == 0))
+ if (memcmp (buf, buf2, sizeof (buf)) == 0)
{
printf ("error: getentropy appears to return constant bytes\n");
errors = true;
--
2.32.0
reply other threads:[~2022-03-31 12:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331121548.1551709-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).