From: Yang Yanchao <yangyanchao6@huawei.com>
To: <libc-alpha@sourceware.org>
Cc: <linfeilong@huawei.com>, <fweimer@redhat.com>, <schwab@linux-m68k.org>
Subject: [PATCH v3] elf: fixes compile error when both enable -Werror and -DNDEBUG
Date: Sat, 2 Apr 2022 17:51:52 +0800 [thread overview]
Message-ID: <20220402095152.3063-1-yangyanchao6@huawei.com> (raw)
Use -Werror and -DNDEBUG at the same time will
causes the following compilation errors:
cache.c: In function 'save_cache':
cache.c:758:15: error: unused variable 'old_offset' [-Werror=unused-variable]
758 | off64_t old_offset = lseek64 (fd, extension_offset, SEEK_SET);
| ^~~~~~~~~~
-DNDEBUG will disables the assertion.
Therefore, only the variables used by assertions do not take effect.
Fooling the Compiler with Type Conversions.
---
elf/cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/elf/cache.c b/elf/cache.c
index dbf4c83a7a..68cd4d0828 100644
--- a/elf/cache.c
+++ b/elf/cache.c
@@ -754,6 +754,7 @@ save_cache (const char *cache_name)
{
/* Align file position to 4. */
off64_t old_offset = lseek64 (fd, extension_offset, SEEK_SET);
+ (void) old_offset;
assert ((unsigned long long int) (extension_offset - old_offset) < 4);
write_extensions (fd, str_offset, extension_offset);
}
--
2.33.0
next reply other threads:[~2022-04-02 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 9:51 Yang Yanchao [this message]
2022-04-11 14:29 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220402095152.3063-1-yangyanchao6@huawei.com \
--to=yangyanchao6@huawei.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linfeilong@huawei.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).