[PATCH] x86: Remove fabs{f} implementation

[PATCH] x86: Remove fabs{f} implementation

[Adhemerval Zanella]

For x86_64 is the same as the generic implementation, while for i686
the builtin generates the same code.
---
 sysdeps/i386/fpu/s_fabs.S    | 10 ----------
 sysdeps/i386/fpu/s_fabsf.S   | 10 ----------
 sysdeps/x86_64/fpu/s_fabs.c  | 27 ---------------------------
 sysdeps/x86_64/fpu/s_fabsf.c | 27 ---------------------------
 4 files changed, 74 deletions(-)
 delete mode 100644 sysdeps/i386/fpu/s_fabs.S
 delete mode 100644 sysdeps/i386/fpu/s_fabsf.S
 delete mode 100644 sysdeps/x86_64/fpu/s_fabs.c
 delete mode 100644 sysdeps/x86_64/fpu/s_fabsf.c

diff --git a/sysdeps/i386/fpu/s_fabs.S b/sysdeps/i386/fpu/s_fabs.S
deleted file mode 100644
index c623eb526c..0000000000
--- a/sysdeps/i386/fpu/s_fabs.S
+++ /dev/null
@@ -1,10 +0,0 @@
-#include <sysdep.h>
-#include <libm-alias-double.h>
-
-	.text
-ENTRY(__fabs)
-	fldl	4(%esp)
-	fabs
-	ret
-END(__fabs)
-libm_alias_double (__fabs, fabs)
diff --git a/sysdeps/i386/fpu/s_fabsf.S b/sysdeps/i386/fpu/s_fabsf.S
deleted file mode 100644
index 3185946ec1..0000000000
--- a/sysdeps/i386/fpu/s_fabsf.S
+++ /dev/null
@@ -1,10 +0,0 @@
-#include <sysdep.h>
-#include <libm-alias-float.h>
-
-	.text
-ENTRY(__fabsf)
-	flds	4(%esp)
-	fabs
-	ret
-END(__fabsf)
-libm_alias_float (__fabs, fabs)
diff --git a/sysdeps/x86_64/fpu/s_fabs.c b/sysdeps/x86_64/fpu/s_fabs.c
deleted file mode 100644
index 6e716a23f9..0000000000
--- a/sysdeps/x86_64/fpu/s_fabs.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/* Absolute value of floating point number.
-   Copyright (C) 2002-2022 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <math.h>
-#include <libm-alias-double.h>
-
-double
-__fabs (double x)
-{
-  return __builtin_fabs (x);
-}
-libm_alias_double (__fabs, fabs)
diff --git a/sysdeps/x86_64/fpu/s_fabsf.c b/sysdeps/x86_64/fpu/s_fabsf.c
deleted file mode 100644
index 501bc87d3c..0000000000
--- a/sysdeps/x86_64/fpu/s_fabsf.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/* Absolute value of floating point number.
-   Copyright (C) 2002-2022 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <math.h>
-#include <libm-alias-float.h>
-
-float
-__fabsf (float x)
-{
-  return __builtin_fabsf (x);
-}
-libm_alias_float (__fabs, fabs)
-- 
2.32.0

Re: [PATCH] x86: Remove fabs{f} implementation

[Adhemerval Zanella]

It should have been marked as 'COMMITTED'.

On 04/04/2022 16:30, Adhemerval Zanella wrote:
> For x86_64 is the same as the generic implementation, while for i686
> the builtin generates the same code.
> ---
>  sysdeps/i386/fpu/s_fabs.S    | 10 ----------
>  sysdeps/i386/fpu/s_fabsf.S   | 10 ----------
>  sysdeps/x86_64/fpu/s_fabs.c  | 27 ---------------------------
>  sysdeps/x86_64/fpu/s_fabsf.c | 27 ---------------------------
>  4 files changed, 74 deletions(-)
>  delete mode 100644 sysdeps/i386/fpu/s_fabs.S
>  delete mode 100644 sysdeps/i386/fpu/s_fabsf.S
>  delete mode 100644 sysdeps/x86_64/fpu/s_fabs.c
>  delete mode 100644 sysdeps/x86_64/fpu/s_fabsf.c