From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id D201E3858D28 for ; Sat, 9 Apr 2022 00:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D201E3858D28 Received: by mail-pl1-x634.google.com with SMTP id n9so9269697plc.4 for ; Fri, 08 Apr 2022 17:19:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CFUy/n+rBFX5ol9eLnnaA3vA/XDY0Rmifeoah4pIzhY=; b=tCN8y/BtECJnZi6kepBhE297pV+5CvTuSHJnssiLldLt7JEv7o1ejXxvhyXxMs6pYY oRABOOKfgBSU3vk0l4QAcSaCe57ELT20Dzd/9/Zszo7S3QXK07h238Ni888WTrpkht/E Ht6kxY5i9HfZ6pGoCJiYbjGuRuqX41QC+vVDr8vSZWBKopHpaYtNL/MsVD5FKS1SSTka TbXEZVfTR4iwIMMGDwbkIoMiMVjFyGnNqs2m+l/jm1l+pJpQHgEkdQ3fDtX1gFS2FZGj ot3YjmSV6kpTdkJ8LV8Dcd435sN1lyM79cEP4mja5wzPTcU/Xg+XuHklXQubAcptkmq/ GONg== X-Gm-Message-State: AOAM532h/4qtkFhN7MvuWjpWbgV01xyfgq1lyO9D4LfKArrFBr/Crw9P fxbc8FFtMgneXqpUv4CSl7FeqAheywZJyg== X-Google-Smtp-Source: ABdhPJzASMevA8Jf6nvqcFxksArvrztN6UEcDaedXq5wzxlhSV87SBDpMdqZIL7FltMLwEKaAwSk3w== X-Received: by 2002:a17:90a:c253:b0:1c9:ada2:f28d with SMTP id d19-20020a17090ac25300b001c9ada2f28dmr24366155pjx.17.1649463598758; Fri, 08 Apr 2022 17:19:58 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2443:f355:75c:3d6b]) by smtp.gmail.com with ESMTPSA id bh3-20020a056a02020300b00378b62df320sm22367034pgb.73.2022.04.08.17.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 17:19:58 -0700 (PDT) Date: Fri, 8 Apr 2022 17:19:53 -0700 From: Fangrui Song To: "H.J. Lu" Cc: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH v7 1/6] elf: Define DT_RELR related macros and types Message-ID: <20220409001953.esrixb26kcpxgxvr@google.com> References: <20220331163858.95516-1-hjl.tools@gmail.com> <20220331163858.95516-2-hjl.tools@gmail.com> <73a619a3-0939-1f13-f819-30a65d47c97d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <73a619a3-0939-1f13-f819-30a65d47c97d@linaro.org> X-Spam-Status: No, score=-26.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Apr 2022 00:20:01 -0000 On 2022-04-04, Adhemerval Zanella wrote: >LGTM, thanks. > >Reviewed-by: Adhemerval Zanella > >On 31/03/2022 13:38, H.J. Lu wrote: >> --- >> elf/elf.h | 13 +++++++++++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/elf/elf.h b/elf/elf.h >> index 0735f6b579..0195029188 100644 >> --- a/elf/elf.h >> +++ b/elf/elf.h >> @@ -443,7 +443,8 @@ typedef struct >> #define SHT_PREINIT_ARRAY 16 /* Array of pre-constructors */ >> #define SHT_GROUP 17 /* Section group */ >> #define SHT_SYMTAB_SHNDX 18 /* Extended section indices */ >> -#define SHT_NUM 19 /* Number of defined types. */ >> +#define SHT_RELR 19 /* RELR relative relocations */ >> +#define SHT_NUM 20 /* Number of defined types. */ >> #define SHT_LOOS 0x60000000 /* Start OS-specific. */ >> #define SHT_GNU_ATTRIBUTES 0x6ffffff5 /* Object attributes. */ >> #define SHT_GNU_HASH 0x6ffffff6 /* GNU-style hash table. */ >> @@ -662,6 +663,11 @@ typedef struct >> Elf64_Sxword r_addend; /* Addend */ >> } Elf64_Rela; >> >> +/* RELR relocation table entry */ >> + >> +typedef Elf32_Word Elf32_Relr; >> +typedef Elf64_Xword Elf64_Relr; >> + >> /* How to extract and insert information held in the r_info field. */ >> >> #define ELF32_R_SYM(val) ((val) >> 8) >> @@ -887,7 +893,10 @@ typedef struct >> #define DT_PREINIT_ARRAY 32 /* Array with addresses of preinit fct*/ >> #define DT_PREINIT_ARRAYSZ 33 /* size in bytes of DT_PREINIT_ARRAY */ >> #define DT_SYMTAB_SHNDX 34 /* Address of SYMTAB_SHNDX section */ >> -#define DT_NUM 35 /* Number used */ >> +#define DT_RELRSZ 35 /* Total size of RELR relative relocations */ >> +#define DT_RELR 36 /* Address of RELR relative relocations */ >> +#define DT_RELRENT 37 /* Size of one RELR relative relocaction */ >> +#define DT_NUM 38 /* Number used */ >> #define DT_LOOS 0x6000000d /* Start of OS-specific */ >> #define DT_HIOS 0x6ffff000 /* End of OS-specific */ >> #define DT_LOPROC 0x70000000 /* Start of processor-specific */ Obviously LGTM to me as well since I suggested the comments. Reviewed-by: Fangrui Song