Re: [PATCH,hurd] Fix arbitrary error code

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Florian Weimer, le mar. 12 avril 2022 11:53:01 +0200, a ecrit:
> > +++ b/nss/nss_test_errno.c
> > @@ -28,7 +28,13 @@ static void __attribute__ ((constructor))
> >  init (void)
> >  {
> >    /* An arbitrary error code which is otherwise not used.  */
> > +#if defined(__linux__)
> >    errno = ELIBBAD;
> > +#elif defined(__GNU__)
> > +  errno = EGRATUITOUS;
> > +#else
> > +#error missing arbitrary error code
> > +#endif
> >  }
> >  
> >  /* Lookup functions for pwd follow that do not return any data.  */
> 
> I don't see a build failure because of this?

The build failure happens during make check, not during make.

> Maybe we can pick another shared error code?

Yep, sure, I'm just not sure what should be used.

> Related question: Would it be possible to add ELIBEXEC to Hurd some day?

That should be easy to implement, yes. We can already just enable its
definition in glibc, and we'll be able to implement it in Hurd's exec
server.

Samuel