From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 2E96A3857C4D for ; Tue, 12 Apr 2022 09:57:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E96A3857C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 022FE20148; Tue, 12 Apr 2022 11:57:43 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QE-bZq90Fi5M; Tue, 12 Apr 2022 11:57:42 +0200 (CEST) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id E0AFC20147; Tue, 12 Apr 2022 11:57:42 +0200 (CEST) Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1neDHK-009TJt-Hz; Tue, 12 Apr 2022 11:57:42 +0200 Date: Tue, 12 Apr 2022 11:57:42 +0200 From: Samuel Thibault To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH,hurd] Fix arbitrary error code Message-ID: <20220412095742.ebmvavh2rhr63kcj@begin> References: <20220412094434.nqpydlozpprrkg6r@begin> <87h76yhblu.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h76yhblu.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 09:57:45 -0000 Florian Weimer, le mar. 12 avril 2022 11:53:01 +0200, a ecrit: > > +++ b/nss/nss_test_errno.c > > @@ -28,7 +28,13 @@ static void __attribute__ ((constructor)) > > init (void) > > { > > /* An arbitrary error code which is otherwise not used. */ > > +#if defined(__linux__) > > errno = ELIBBAD; > > +#elif defined(__GNU__) > > + errno = EGRATUITOUS; > > +#else > > +#error missing arbitrary error code > > +#endif > > } > > > > /* Lookup functions for pwd follow that do not return any data. */ > > I don't see a build failure because of this? The build failure happens during make check, not during make. > Maybe we can pick another shared error code? Yep, sure, I'm just not sure what should be used. > Related question: Would it be possible to add ELIBEXEC to Hurd some day? That should be easy to implement, yes. We can already just enable its definition in glibc, and we'll be able to implement it in Hurd's exec server. Samuel