From: Fangrui Song <maskray@google.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Fangrui Song via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Remove fallback to the start of DT_STRTAB for dladdr
Date: Mon, 2 May 2022 09:06:12 -0700 [thread overview]
Message-ID: <20220502160612.nxhqkwodah4zgqwv@google.com> (raw)
In-Reply-To: <87bkwg8hac.fsf@oldenburg.str.redhat.com>
On 2022-05-02, Florian Weimer wrote:
>* Fangrui Song via Libc-alpha:
>
>> + /* In the absence of a hash table, as if the object has no symbol. */
>
>Could you rephrase that a bit, maybe “treat the object as if it has no
>symbol”?
>
>Rest looks okay to me.
>
>Reviewed-by: Florian Weimer <fweimer@redhat.com>
>
>Thanks,
>Florian
>
Thanks for the suggestion!
prev parent reply other threads:[~2022-05-02 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 21:50 Fangrui Song
2022-05-02 6:56 ` Florian Weimer
2022-05-02 7:04 ` Fangrui Song
2022-05-02 7:21 ` Florian Weimer
2022-05-02 7:30 ` Fangrui Song
2022-05-02 8:26 ` Florian Weimer
2022-05-02 8:34 ` Florian Weimer
2022-05-02 16:06 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502160612.nxhqkwodah4zgqwv@google.com \
--to=maskray@google.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).