From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by sourceware.org (Postfix) with ESMTPS id 5E6C73857806; Thu, 5 May 2022 03:01:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E6C73857806 Received: from canpemm500006.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ktz3R6GSQzhYwC; Thu, 5 May 2022 11:00:51 +0800 (CST) Received: from use12-sp2.huawei.com (10.67.189.174) by canpemm500006.china.huawei.com (7.192.105.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 11:01:13 +0800 From: Xiaoming Ni To: , , , , , , CC: , , Subject: [PATCH v2 0/4] time: Use __nonnull to avoid null pointer Date: Thu, 5 May 2022 11:01:07 +0800 Message-ID: <20220505030111.111197-1-nixiaoming@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220428122529.108208-1-nixiaoming@huawei.com> References: <20220428122529.108208-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.189.174] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500006.china.huawei.com (7.192.105.130) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_MANYTO, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 03:01:18 -0000 Some external interface codes do not check whether the pointer parameter is null. If the parameter is null, the program crashes (BZ#27662). Therefore, add a __nonull statement to the function declaration to avoid null pointers. Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27662 Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29084 The __nonull declaration is added for the following interfaces: adjtimex() adjtimex64() ntp_gettime() ntp_gettime64() ntp_gettimex() ntp_gettimex64() ntp_adjtime() clock_settime() clock_settime64() clock_gettime() clock_gettime64() clock_adjtime() clock_adjtime64() -- v2: fix the compilation error caused by missing semicolons. Thanks Siddhesh Poyarekar for the review. v1: https://public-inbox.org/libc-alpha/20220428122529.108208-1-nixiaoming@huawei.com/ -- Xiaoming Ni (4): adjtimex/adjtimex64: Use __nonnull to avoid null pointer ntp_xxxtimex: Use __nonnull to avoid null pointer clock_adjtime: Use __nonnull to avoid null pointer clock_settime/clock_gettime: Use __nonnull to avoid null pointer include/time.h | 4 ++-- sysdeps/unix/sysv/linux/bits/time.h | 4 ++-- sysdeps/unix/sysv/linux/include/sys/timex.h | 10 +++++----- sysdeps/unix/sysv/linux/sys/timex.h | 16 ++++++++-------- time/time.h | 11 +++++++---- 5 files changed, 24 insertions(+), 21 deletions(-) -- 2.27.0