From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id E2F373857405 for ; Thu, 12 May 2022 17:07:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E2F373857405 Received: by mail-pj1-x1036.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so8403728pjb.3 for ; Thu, 12 May 2022 10:07:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bTgH0110kStb+MIM3fv/FGNIlvKmLADo76rLLwR3Ifk=; b=T0qMHXAiXaq5mD7EO/BWIg/G1OnXuYAQGOXlEHewqaRG8m0/Hhbz3jysohcfGgad7d W5t7Yf14XwnVHiFVfAwZBtKs9ImRMBqdacCq0VO7Q/+H6qDGrEQXQUwOheByc+rMTD+H Ek7m+fzzWFAyngG5o9vcSsWAHpSoOQKVN+kdR/kqP8GmNzNbu2RUywUpTkDxZKzRyibs i7PnJ9Y1lsuT4yux9NWy/Jf0//RVDVWaZWuPqnw+6n+bHd6p0LGb9HiWQFsV/3fyY8mu XxeQXu4juJ2N4vua807X2dYGcvkpXFSPe7rI0zFv1INl7h8Qe28yq6gLNtqbroZFZxFe 322g== X-Gm-Message-State: AOAM530oH0V9zwTLK8smSe3lwGBpzV1mBZXrbXqY1M/c/mb7YWYUlc25 ZjpEj1dhZ81SRFBQlSYs0Fdiow== X-Google-Smtp-Source: ABdhPJz302R64nZsr6X4hBBXdZNBNNLSXzmTz4QcXG0Uwbg6floWrCYGTv76fDIfytz9m13o/JIIRw== X-Received: by 2002:a17:90b:4a4f:b0:1dc:79d9:8505 with SMTP id lb15-20020a17090b4a4f00b001dc79d98505mr11879646pjb.43.1652375273726; Thu, 12 May 2022 10:07:53 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:e892:f9c7:57f5:14db]) by smtp.gmail.com with ESMTPSA id 203-20020a6300d4000000b003c14af5062esm2215408pga.70.2022.05.12.10.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 10:07:53 -0700 (PDT) Date: Thu, 12 May 2022 10:07:50 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 4/4] Remove configure fno_unit_at_a_time Message-ID: <20220512170750.wyjd7tf45ygo7ga3@google.com> References: <20220512125931.523712-1-adhemerval.zanella@linaro.org> <20220512125931.523712-5-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220512125931.523712-5-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-27.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 17:07:59 -0000 On 2022-05-12, Adhemerval Zanella wrote: >Since it is not used any longer. Thanks for removing obsoleted GCC option:) Reviewed-by: Fangrui Song >--- > config.make.in | 1 - > configure | 32 -------------------------------- > configure.ac | 19 ------------------- > 3 files changed, 52 deletions(-) > >diff --git a/config.make.in b/config.make.in >index fff4c78dd0..d7c416cbea 100644 >--- a/config.make.in >+++ b/config.make.in >@@ -68,7 +68,6 @@ have-selinux = @have_selinux@ > have-libaudit = @have_libaudit@ > have-libcap = @have_libcap@ > have-cc-with-libunwind = @libc_cv_cc_with_libunwind@ >-fno-unit-at-a-time = @fno_unit_at_a_time@ > bind-now = @bindnow@ > use-default-link = @use_default_link@ > have-cxx-thread_local = @libc_cv_cxx_thread_local@ >diff --git a/configure b/configure >index 716dc041b6..ff2c406b3b 100755 >--- a/configure >+++ b/configure >@@ -620,7 +620,6 @@ libc_cv_cc_loop_to_function > libc_cv_cc_submachine > libc_cv_cc_nofma > libc_cv_mtls_dialect_gnu2 >-fno_unit_at_a_time > libc_cv_has_glob_dat > libc_cv_fpie > libc_cv_z_execstack >@@ -6226,37 +6225,6 @@ fi > $as_echo "$libc_cv_has_glob_dat" >&6; } > > >-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fno-toplevel-reorder -fno-section-anchors" >&5 >-$as_echo_n "checking for -fno-toplevel-reorder -fno-section-anchors... " >&6; } >-if ${libc_cv_fno_toplevel_reorder+:} false; then : >- $as_echo_n "(cached) " >&6 >-else >- cat > conftest.c <-int foo; >-EOF >-if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -S -fno-toplevel-reorder -fno-section-anchors >- conftest.c 1>&5' >- { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 >- (eval $ac_try) 2>&5 >- ac_status=$? >- $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 >- test $ac_status = 0; }; } >-then >- libc_cv_fno_toplevel_reorder=yes >-else >- libc_cv_fno_toplevel_reorder=no >-fi >-rm -f conftest* >-fi >-{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_fno_toplevel_reorder" >&5 >-$as_echo "$libc_cv_fno_toplevel_reorder" >&6; } >-if test $libc_cv_fno_toplevel_reorder = yes; then >- fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" >-else >- fno_unit_at_a_time=-fno-unit-at-a-time >-fi >- >- > { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -mtls-dialect=gnu2" >&5 > $as_echo_n "checking for -mtls-dialect=gnu2... " >&6; } > if ${libc_cv_mtls_dialect_gnu2+:} false; then : >diff --git a/configure.ac b/configure.ac >index d08ad4d64e..eb5bc6a131 100644 >--- a/configure.ac >+++ b/configure.ac >@@ -1383,25 +1383,6 @@ fi > rm -f conftest*]) > AC_SUBST(libc_cv_has_glob_dat) > >-AC_CACHE_CHECK(for -fno-toplevel-reorder -fno-section-anchors, libc_cv_fno_toplevel_reorder, [dnl >-cat > conftest.c <-int foo; >-EOF >-if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -S -fno-toplevel-reorder -fno-section-anchors >- conftest.c 1>&AS_MESSAGE_LOG_FD]) >-then >- libc_cv_fno_toplevel_reorder=yes >-else >- libc_cv_fno_toplevel_reorder=no >-fi >-rm -f conftest*]) >-if test $libc_cv_fno_toplevel_reorder = yes; then >- fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" >-else >- fno_unit_at_a_time=-fno-unit-at-a-time >-fi >-AC_SUBST(fno_unit_at_a_time) >- > AC_CACHE_CHECK([for -mtls-dialect=gnu2], libc_cv_mtls_dialect_gnu2, > [dnl > cat > conftest.c <-- >2.34.1 >