From: Fangrui Song <maskray@google.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Update RISC-V specific ELF definitions
Date: Thu, 12 May 2022 13:41:24 -0700 [thread overview]
Message-ID: <20220512204124.az75xwoxqxazj6rf@google.com> (raw)
In-Reply-To: <87czgubqc4.fsf@igel.home>
On 2022-05-03, Andreas Schwab wrote:
>The definitions are taken from the 1.0-rc2 version of the ELF psABI.
>---
> elf/elf.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/elf/elf.h b/elf/elf.h
>index 0195029188..648bf66c7d 100644
>--- a/elf/elf.h
>+++ b/elf/elf.h
>@@ -3927,6 +3927,8 @@ enum
> #define EF_RISCV_FLOAT_ABI_SINGLE 0x0002
> #define EF_RISCV_FLOAT_ABI_DOUBLE 0x0004
> #define EF_RISCV_FLOAT_ABI_QUAD 0x0006
>+#define EF_RISCV_RVE 0x0008
>+#define EF_RISCV_TSO 0x0010
>
> /* RISC-V relocations. */
> #define R_RISCV_NONE 0
>@@ -3987,6 +3989,18 @@ enum
>
> #define R_RISCV_NUM 59
>
>+/* RISC-V specific values for the st_other field. */
>+#define STO_RISCV_VARIANT_CC 0x80
I see that there is a precedent that STO_AARCH64_VARIANT_PCS calls this
"AArch64 specific values for the st_other field", but a descriptive
comment may be more useful, e.g. "Mark functions that do not follow the
standard calling convention for the ABI in use."
"RISC-V specific" can probably be removed as "RISCV" in the macro name
self explains.
>+/* RISC-V specific values for the sh_type field. */
>+#define SHT_RISCV_ATTRIBUTES (SHT_LOPROC + 3)
>+
>+/* RISC-V specific values for the p_type field. */
>+#define PT_RISCV_ATTRIBUTES (PT_LOPROC + 3)
>+
>+/* RISC-V specific values for the d_tag field. */
>+#define DT_RISCV_VARIANT_CC (DT_LOPROC + 1)
>+
> /* BPF specific declarations. */
>
> #define R_BPF_NONE 0 /* No reloc */
>--
>2.35.2
I have verified these values match
https://github.com/riscv-non-isa/riscv-elf-psabi-doc/releases/download/v1.0-rc2/riscv-abi.pdf
Reviewed-by: Fangrui Song <maskray@google.com>
prev parent reply other threads:[~2022-05-12 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 15:14 Andreas Schwab
2022-05-12 20:41 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512204124.az75xwoxqxazj6rf@google.com \
--to=maskray@google.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).