From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 1D3283858002 for ; Fri, 20 May 2022 22:50:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D3283858002 Received: by mail-pj1-x102c.google.com with SMTP id nk9-20020a17090b194900b001df2fcdc165so12686717pjb.0 for ; Fri, 20 May 2022 15:50:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8p7zidPapMFxZIuQaE8DowYVBmIXuR0f/gJ40zWg3F4=; b=nqW2LBOt+7cuihG74unyRZuj0TQIjd6Ft/l2MyTIu58hb2Rdv/+3cl313fTr8KSG9o aj4oFhzc8tm0MdqLUBax2yeZ/AWHkTE7YQ4hu/1FiTYmx5tk8MawQG9nB4MPHLcvd7Dm 1n7+M4xG7cOX6kfvRUmxkP0ir6fQJQ+dOUBfzB1JgM82AU3HIcjKqTpEMwd8Hme8iedo 4Y2ZlnofMmOEfoRH/5psrFai8ZeWsal/tNlG9n1/I3yUcUfU9uLBmCCSVJmpIyw42Nya QydAEqHqcB6hszFDY+LKiSTxb7OywlL6TawMu038Tx8F7CI39EJSPznLjVH3IGnZuvMt qqJQ== X-Gm-Message-State: AOAM532DPe87IHQ5/TbTH1/UJ2WPGT5j7p1zwcLlddHCmBJhy5UjGycA uO6SbAfdecOsU22dODpvaHtWp97hRD8TyQ== X-Google-Smtp-Source: ABdhPJwGbau1Z2mM4CGYUz2gHxPuzbCb0E4KEs6R5GKUOngON8fyXImCRsxzQg/KW4SeXnBdNHKSbA== X-Received: by 2002:a17:902:e404:b0:161:9e38:63c8 with SMTP id m4-20020a170902e40400b001619e3863c8mr11798494ple.148.1653087013877; Fri, 20 May 2022 15:50:13 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:17ca:6944:3c67:affc]) by smtp.gmail.com with ESMTPSA id c1-20020a170902d48100b0015e8d4eb29csm231100plg.230.2022.05.20.15.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 15:50:13 -0700 (PDT) Date: Fri, 20 May 2022 15:50:09 -0700 From: Fangrui Song To: Florian Weimer Cc: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH v2] Enable DT_RELR in glibc shared libraries and PIEs automatically Message-ID: <20220520225009.mfkzwang4spyznee@google.com> References: <20220516131714.37463-1-hjl.tools@gmail.com> <87h75psibt.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87h75psibt.fsf@oldenburg.str.redhat.com> X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 22:50:16 -0000 On 2022-05-16, Florian Weimer via Libc-alpha wrote: >* H. J. Lu via Libc-alpha: > >> Enable DT_RELR in glibc shared libraries and position independent >> executables (PIE) automatically if linker supports -z >> pack-relative-relocs. > >Thanks for updating the commit subject. > >Reviewed-by: Florian Weimer > >Florian > Thanks for the patch. Question: does gdb need DT_RELR support to debug such a shared object? `gdb elf/ld.so` will report BFD: path/to/elf/ld.so: unknown type [0x13] section `.relr.dyn' but I do not know whether any functionality is affected in the absence of SHT_RELR support.