From: Noah Goldstein <goldstein.w.n@gmail.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v5 3/8] Benchtests: Improve memrchr benchmarks
Date: Mon, 6 Jun 2022 21:05:24 -0700 [thread overview]
Message-ID: <20220607040529.2344473-3-goldstein.w.n@gmail.com> (raw)
In-Reply-To: <20220607040529.2344473-1-goldstein.w.n@gmail.com>
Add a second iteration for memrchr to set `pos` starting from the end
of the buffer.
Previously `pos` was only set relative to the begining of the
buffer. This isn't really useful for memrchr because the begining
of the search space is (buf + len).
---
benchtests/bench-memchr.c | 110 ++++++++++++++++++++++----------------
1 file changed, 65 insertions(+), 45 deletions(-)
diff --git a/benchtests/bench-memchr.c b/benchtests/bench-memchr.c
index 4d7212332f..0facda2fa0 100644
--- a/benchtests/bench-memchr.c
+++ b/benchtests/bench-memchr.c
@@ -76,7 +76,7 @@ do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, int c,
static void
do_test (json_ctx_t *json_ctx, size_t align, size_t pos, size_t len,
- int seek_char)
+ int seek_char, int invert_pos)
{
size_t i;
@@ -96,7 +96,10 @@ do_test (json_ctx_t *json_ctx, size_t align, size_t pos, size_t len,
if (pos < len)
{
- buf[align + pos] = seek_char;
+ if (invert_pos)
+ buf[align + len - pos] = seek_char;
+ else
+ buf[align + pos] = seek_char;
buf[align + len] = -seek_char;
}
else
@@ -109,6 +112,7 @@ do_test (json_ctx_t *json_ctx, size_t align, size_t pos, size_t len,
json_attr_uint (json_ctx, "pos", pos);
json_attr_uint (json_ctx, "len", len);
json_attr_uint (json_ctx, "seek_char", seek_char);
+ json_attr_uint (json_ctx, "invert_pos", invert_pos);
json_array_begin (json_ctx, "timings");
@@ -123,6 +127,7 @@ int
test_main (void)
{
size_t i;
+ int repeats;
json_ctx_t json_ctx;
test_init ();
@@ -142,53 +147,68 @@ test_main (void)
json_array_begin (&json_ctx, "results");
- for (i = 1; i < 8; ++i)
+ for (repeats = 0; repeats < 2; ++repeats)
{
- do_test (&json_ctx, 0, 16 << i, 2048, 23);
- do_test (&json_ctx, i, 64, 256, 23);
- do_test (&json_ctx, 0, 16 << i, 2048, 0);
- do_test (&json_ctx, i, 64, 256, 0);
-
- do_test (&json_ctx, getpagesize () - 15, 64, 256, 0);
+ for (i = 1; i < 8; ++i)
+ {
+ do_test (&json_ctx, 0, 16 << i, 2048, 23, repeats);
+ do_test (&json_ctx, i, 64, 256, 23, repeats);
+ do_test (&json_ctx, 0, 16 << i, 2048, 0, repeats);
+ do_test (&json_ctx, i, 64, 256, 0, repeats);
+
+ do_test (&json_ctx, getpagesize () - 15, 64, 256, 0, repeats);
#ifdef USE_AS_MEMRCHR
- /* Also test the position close to the beginning for memrchr. */
- do_test (&json_ctx, 0, i, 256, 23);
- do_test (&json_ctx, 0, i, 256, 0);
- do_test (&json_ctx, i, i, 256, 23);
- do_test (&json_ctx, i, i, 256, 0);
+ /* Also test the position close to the beginning for memrchr. */
+ do_test (&json_ctx, 0, i, 256, 23, repeats);
+ do_test (&json_ctx, 0, i, 256, 0, repeats);
+ do_test (&json_ctx, i, i, 256, 23, repeats);
+ do_test (&json_ctx, i, i, 256, 0, repeats);
#endif
- }
- for (i = 1; i < 8; ++i)
- {
- do_test (&json_ctx, i, i << 5, 192, 23);
- do_test (&json_ctx, i, i << 5, 192, 0);
- do_test (&json_ctx, i, i << 5, 256, 23);
- do_test (&json_ctx, i, i << 5, 256, 0);
- do_test (&json_ctx, i, i << 5, 512, 23);
- do_test (&json_ctx, i, i << 5, 512, 0);
-
- do_test (&json_ctx, getpagesize () - 15, i << 5, 256, 23);
- }
- for (i = 1; i < 32; ++i)
- {
- do_test (&json_ctx, 0, i, i + 1, 23);
- do_test (&json_ctx, 0, i, i + 1, 0);
- do_test (&json_ctx, i, i, i + 1, 23);
- do_test (&json_ctx, i, i, i + 1, 0);
- do_test (&json_ctx, 0, i, i - 1, 23);
- do_test (&json_ctx, 0, i, i - 1, 0);
- do_test (&json_ctx, i, i, i - 1, 23);
- do_test (&json_ctx, i, i, i - 1, 0);
-
- do_test (&json_ctx, getpagesize () - 15, i, i - 1, 23);
- do_test (&json_ctx, getpagesize () - 15, i, i - 1, 0);
-
- do_test (&json_ctx, getpagesize () - 15, i, i + 1, 23);
- do_test (&json_ctx, getpagesize () - 15, i, i + 1, 0);
+ }
+ for (i = 1; i < 8; ++i)
+ {
+ do_test (&json_ctx, i, i << 5, 192, 23, repeats);
+ do_test (&json_ctx, i, i << 5, 192, 0, repeats);
+ do_test (&json_ctx, i, i << 5, 256, 23, repeats);
+ do_test (&json_ctx, i, i << 5, 256, 0, repeats);
+ do_test (&json_ctx, i, i << 5, 512, 23, repeats);
+ do_test (&json_ctx, i, i << 5, 512, 0, repeats);
+
+ do_test (&json_ctx, getpagesize () - 15, i << 5, 256, 23, repeats);
+ }
+ for (i = 1; i < 32; ++i)
+ {
+ do_test (&json_ctx, 0, i, i + 1, 23, repeats);
+ do_test (&json_ctx, 0, i, i + 1, 0, repeats);
+ do_test (&json_ctx, i, i, i + 1, 23, repeats);
+ do_test (&json_ctx, i, i, i + 1, 0, repeats);
+ do_test (&json_ctx, 0, i, i - 1, 23, repeats);
+ do_test (&json_ctx, 0, i, i - 1, 0, repeats);
+ do_test (&json_ctx, i, i, i - 1, 23, repeats);
+ do_test (&json_ctx, i, i, i - 1, 0, repeats);
+
+ do_test (&json_ctx, getpagesize () / 2, i, i + 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () / 2, i, i + 1, 0, repeats);
+ do_test (&json_ctx, getpagesize () / 2 + i, i, i + 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () / 2 + i, i, i + 1, 0, repeats);
+ do_test (&json_ctx, getpagesize () / 2, i, i - 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () / 2, i, i - 1, 0, repeats);
+ do_test (&json_ctx, getpagesize () / 2 + i, i, i - 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () / 2 + i, i, i - 1, 0, repeats);
+
+ do_test (&json_ctx, getpagesize () - 15, i, i - 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () - 15, i, i - 1, 0, repeats);
+
+ do_test (&json_ctx, getpagesize () - 15, i, i + 1, 23, repeats);
+ do_test (&json_ctx, getpagesize () - 15, i, i + 1, 0, repeats);
+
#ifdef USE_AS_MEMRCHR
- /* Also test the position close to the beginning for memrchr. */
- do_test (&json_ctx, 0, 1, i + 1, 23);
- do_test (&json_ctx, 0, 2, i + 1, 0);
+ do_test (&json_ctx, 0, 1, i + 1, 23, repeats);
+ do_test (&json_ctx, 0, 2, i + 1, 0, repeats);
+#endif
+ }
+#ifndef USE_AS_MEMRCHR
+ break;
#endif
}
--
2.34.1
next prev parent reply other threads:[~2022-06-07 4:05 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 4:42 [PATCH v1 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-03 23:12 ` H.J. Lu
2022-06-03 23:33 ` Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 3/8] Benchtests: Improve memrchr benchmarks Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-03 20:04 ` [PATCH v2 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-03 23:09 ` [PATCH v2 1/8] x86: Create header for VEC classes in x86 strings library H.J. Lu
2022-06-03 23:49 ` Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 " Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-06 21:30 ` H.J. Lu
2022-06-06 22:38 ` Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 3/8] Benchtests: Improve memrchr benchmarks Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-03 23:49 ` [PATCH v3 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-03 23:50 ` [PATCH v3 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-03 23:50 ` [PATCH v3 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-07 2:45 ` H.J. Lu
2022-07-14 2:12 ` Sunil Pandey
2022-06-06 22:37 ` [PATCH v4 3/8] Benchtests: Improve memrchr benchmarks Noah Goldstein
2022-06-07 2:44 ` H.J. Lu
2022-06-07 4:10 ` Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-07 2:41 ` H.J. Lu
2022-06-07 4:09 ` Noah Goldstein
2022-06-07 4:12 ` Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-07 2:35 ` H.J. Lu
2022-06-07 4:06 ` Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-06 22:37 ` [PATCH v4 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-07 4:05 ` Noah Goldstein [this message]
2022-06-07 4:05 ` [PATCH v5 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-07 4:05 ` [PATCH v5 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-07 4:11 ` [PATCH v6 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
2022-06-07 4:11 ` [PATCH v6 2/8] x86: Add COND_VZEROUPPER that can replace vzeroupper if no `ret` Noah Goldstein
2022-06-07 4:11 ` [PATCH v6 3/8] Benchtests: Improve memrchr benchmarks Noah Goldstein
2022-06-07 18:03 ` H.J. Lu
2022-06-07 4:11 ` [PATCH v6 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-07 18:04 ` H.J. Lu
2022-07-14 2:19 ` Sunil Pandey
2022-06-07 4:11 ` [PATCH v6 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-07 18:21 ` H.J. Lu
2022-07-14 2:21 ` Sunil Pandey
2022-06-07 4:11 ` [PATCH v6 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-07 18:17 ` H.J. Lu
2022-07-14 2:26 ` Sunil Pandey
2022-07-14 2:43 ` Noah Goldstein
2022-06-07 4:11 ` [PATCH v6 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-07 18:18 ` H.J. Lu
2022-07-14 2:31 ` Sunil Pandey
2022-07-14 2:41 ` Noah Goldstein
2022-06-07 4:11 ` [PATCH v6 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-07 18:19 ` H.J. Lu
2022-07-14 2:32 ` Sunil Pandey
2022-06-07 18:04 ` [PATCH v6 1/8] x86: Create header for VEC classes in x86 strings library H.J. Lu
2022-07-14 2:07 ` Sunil Pandey
2022-06-03 4:42 ` [PATCH v1 3/8] Benchtests: Improve memrchr benchmarks Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 4/8] x86: Optimize memrchr-sse2.S Noah Goldstein
2022-06-03 4:47 ` Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 5/8] x86: Optimize memrchr-evex.S Noah Goldstein
2022-06-03 4:49 ` Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 6/8] x86: Optimize memrchr-avx2.S Noah Goldstein
2022-06-03 4:50 ` Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 7/8] x86: Shrink code size of memchr-avx2.S Noah Goldstein
2022-06-03 4:42 ` [PATCH v1 8/8] x86: Shrink code size of memchr-evex.S Noah Goldstein
2022-06-03 4:51 ` [PATCH v1 1/8] x86: Create header for VEC classes in x86 strings library Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607040529.2344473-3-goldstein.w.n@gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).