From: Noah Goldstein <goldstein.w.n@gmail.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v1 3/3] x86: Add sse42 implementation to strcmp's ifunc
Date: Tue, 14 Jun 2022 17:25:33 -0700 [thread overview]
Message-ID: <20220615002533.1741934-3-goldstein.w.n@gmail.com> (raw)
In-Reply-To: <20220615002533.1741934-1-goldstein.w.n@gmail.com>
This has been missing since the the ifuncs where added.
The performance of SSE4.2 is preferable to to SSE2.
Measured on Tigerlake with N = 20 runs.
Geometric Mean of all benchmarks SSE4.2 / SSE2: 0.906
---
sysdeps/x86_64/multiarch/strcmp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sysdeps/x86_64/multiarch/strcmp.c b/sysdeps/x86_64/multiarch/strcmp.c
index a248c2a6e6..9c1677724c 100644
--- a/sysdeps/x86_64/multiarch/strcmp.c
+++ b/sysdeps/x86_64/multiarch/strcmp.c
@@ -28,6 +28,7 @@
extern __typeof (REDIRECT_NAME) OPTIMIZE (sse2) attribute_hidden;
extern __typeof (REDIRECT_NAME) OPTIMIZE (sse2_unaligned) attribute_hidden;
+extern __typeof (REDIRECT_NAME) OPTIMIZE (sse42) attribute_hidden;
extern __typeof (REDIRECT_NAME) OPTIMIZE (avx2) attribute_hidden;
extern __typeof (REDIRECT_NAME) OPTIMIZE (avx2_rtm) attribute_hidden;
extern __typeof (REDIRECT_NAME) OPTIMIZE (evex) attribute_hidden;
@@ -52,6 +53,10 @@ IFUNC_SELECTOR (void)
return OPTIMIZE (avx2);
}
+ if (CPU_FEATURE_USABLE_P (cpu_features, SSE4_2)
+ && !CPU_FEATURES_ARCH_P (cpu_features, Slow_SSE4_2))
+ return OPTIMIZE (sse42);
+
if (CPU_FEATURES_ARCH_P (cpu_features, Fast_Unaligned_Load))
return OPTIMIZE (sse2_unaligned);
--
2.34.1
next prev parent reply other threads:[~2022-06-15 0:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 0:25 [PATCH v1 1/3] x86: Fix misordered logic for setting `rep_movsb_stop_threshold` Noah Goldstein
2022-06-15 0:25 ` [PATCH v1 2/3] x86: Cleanup bounds checking in large memcpy case Noah Goldstein
2022-06-15 1:07 ` H.J. Lu
2022-06-15 3:57 ` Noah Goldstein
2022-06-15 3:57 ` [PATCH v2] " Noah Goldstein
2022-06-15 14:52 ` H.J. Lu
2022-06-15 15:13 ` Noah Goldstein
2022-06-15 15:12 ` [PATCH v3] " Noah Goldstein
2022-06-15 16:48 ` H.J. Lu
2022-06-15 17:44 ` Noah Goldstein
2022-06-15 17:41 ` [PATCH v4 1/2] " Noah Goldstein
2022-06-15 17:41 ` [PATCH v4 2/2] x86: Add bounds `x86_non_temporal_threshold` Noah Goldstein
2022-06-15 18:22 ` H.J. Lu
2022-06-15 18:33 ` Noah Goldstein
2022-06-15 18:32 ` [PATCH v5 " Noah Goldstein
2022-06-15 18:43 ` H.J. Lu
2022-06-15 19:52 ` [PATCH v6 2/3] " Noah Goldstein
2022-06-15 20:27 ` H.J. Lu
2022-06-15 20:35 ` Noah Goldstein
2022-06-15 20:34 ` [PATCH v7 " Noah Goldstein
2022-06-15 20:48 ` H.J. Lu
2022-07-14 2:55 ` Sunil Pandey
2022-06-15 18:22 ` [PATCH v4 1/2] x86: Cleanup bounds checking in large memcpy case H.J. Lu
2022-07-14 2:57 ` Sunil Pandey
2022-06-15 0:25 ` Noah Goldstein [this message]
2022-06-15 1:08 ` [PATCH v1 3/3] x86: Add sse42 implementation to strcmp's ifunc H.J. Lu
2022-07-14 2:54 ` Sunil Pandey
2022-06-15 1:02 ` [PATCH v1 1/3] x86: Fix misordered logic for setting `rep_movsb_stop_threshold` H.J. Lu
2022-07-14 2:53 ` Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615002533.1741934-3-goldstein.w.n@gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).