* [PATCH] linux: Remove unnecessary nice.c and signal.c
@ 2022-06-29 14:06 Arjun Shankar
2022-06-29 16:24 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: Arjun Shankar @ 2022-06-29 14:06 UTC (permalink / raw)
To: libc-alpha
These files simply include the sysdeps/posix implementations which would
be used even in the absence of the files. They have been unnecessary
since 7b17aeda0c5e when nice and signal were removed from the
syscalls.list file.
---
sysdeps/unix/sysv/linux/nice.c | 1 -
sysdeps/unix/sysv/linux/signal.c | 3 ---
2 files changed, 4 deletions(-)
delete mode 100644 sysdeps/unix/sysv/linux/nice.c
delete mode 100644 sysdeps/unix/sysv/linux/signal.c
diff --git a/sysdeps/unix/sysv/linux/nice.c b/sysdeps/unix/sysv/linux/nice.c
deleted file mode 100644
index 3bcbb1e89a..0000000000
--- a/sysdeps/unix/sysv/linux/nice.c
+++ /dev/null
@@ -1 +0,0 @@
-#include <sysdeps/posix/nice.c>
diff --git a/sysdeps/unix/sysv/linux/signal.c b/sysdeps/unix/sysv/linux/signal.c
deleted file mode 100644
index bc4e4e8447..0000000000
--- a/sysdeps/unix/sysv/linux/signal.c
+++ /dev/null
@@ -1,3 +0,0 @@
-/* We need this file since otherwise `signal' would be handled as a
- system call. */
-#include <sysdeps/posix/signal.c>
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] linux: Remove unnecessary nice.c and signal.c
2022-06-29 14:06 [PATCH] linux: Remove unnecessary nice.c and signal.c Arjun Shankar
@ 2022-06-29 16:24 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2022-06-29 16:24 UTC (permalink / raw)
To: Arjun Shankar; +Cc: libc-alpha
> On 29 Jun 2022, at 11:06, Arjun Shankar via Libc-alpha <libc-alpha@sourceware.org> wrote:
>
> These files simply include the sysdeps/posix implementations which would
> be used even in the absence of the files. They have been unnecessary
> since 7b17aeda0c5e when nice and signal were removed from the
> syscalls.list file.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/nice.c | 1 -
> sysdeps/unix/sysv/linux/signal.c | 3 ---
> 2 files changed, 4 deletions(-)
> delete mode 100644 sysdeps/unix/sysv/linux/nice.c
> delete mode 100644 sysdeps/unix/sysv/linux/signal.c
>
> diff --git a/sysdeps/unix/sysv/linux/nice.c b/sysdeps/unix/sysv/linux/nice.c
> deleted file mode 100644
> index 3bcbb1e89a..0000000000
> --- a/sysdeps/unix/sysv/linux/nice.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -#include <sysdeps/posix/nice.c>
> diff --git a/sysdeps/unix/sysv/linux/signal.c b/sysdeps/unix/sysv/linux/signal.c
> deleted file mode 100644
> index bc4e4e8447..0000000000
> --- a/sysdeps/unix/sysv/linux/signal.c
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -/* We need this file since otherwise `signal' would be handled as a
> - system call. */
> -#include <sysdeps/posix/signal.c>
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 14:06 [PATCH] linux: Remove unnecessary nice.c and signal.c Arjun Shankar
2022-06-29 16:24 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).