From: Noah Goldstein <goldstein.w.n@gmail.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v4 1/2] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S
Date: Wed, 29 Jun 2022 20:08:37 -0700 [thread overview]
Message-ID: <20220630030838.3693807-1-goldstein.w.n@gmail.com> (raw)
In-Reply-To: <20220628152717.17838-1-goldstein.w.n@gmail.com>
Was missing to for the multiarch build rtld-strncmp-sse4_2.os was
being built and exporting symbols:
build/glibc/string/rtld-strncmp-sse4_2.os:
0000000000000000 T __strncmp_sse42
Introduced in:
commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed Jun 21 12:10:50 2017 -0700
x86-64: Implement strcmp family IFUNC selectors in C
---
sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
index 9773e5fc09..310a6dbe77 100644
--- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
+++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
@@ -16,6 +16,8 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
-#define STRCMP_SSE42 __strncmp_sse42
-#define USE_AS_STRNCMP
-#include "strcmp-sse42.S"
+#if IS_IN (libc)
+# define STRCMP_SSE42 __strncmp_sse42
+# define USE_AS_STRNCMP
+# include "strcmp-sse42.S"
+#endif
--
2.34.1
next prev parent reply other threads:[~2022-06-30 3:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 15:27 [PATCH v1 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 Noah Goldstein
2022-06-28 15:27 ` [PATCH v1 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-06-29 19:20 ` H.J. Lu
2022-06-29 22:07 ` Noah Goldstein
2022-06-29 18:53 ` [PATCH v1 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 H.J. Lu
2022-06-29 19:19 ` Noah Goldstein
2022-06-29 22:06 ` Noah Goldstein
2022-06-29 22:05 ` [PATCH v2 " Noah Goldstein
2022-06-29 22:05 ` [PATCH v2 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-06-29 22:15 ` H.J. Lu
2022-06-30 3:11 ` Noah Goldstein
2022-06-30 3:27 ` Noah Goldstein
2022-06-29 22:12 ` [PATCH v2 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 H.J. Lu
2022-06-30 3:09 ` Noah Goldstein
2022-06-30 3:08 ` Noah Goldstein [this message]
2022-06-30 3:08 ` [PATCH v4 2/2] " Noah Goldstein
2022-06-30 3:10 ` [PATCH v4 1/2] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S Noah Goldstein
2022-06-30 3:10 ` [PATCH v5 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 Noah Goldstein
2022-06-30 3:10 ` [PATCH v5 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-06-30 3:44 ` [PATCH v6 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 Noah Goldstein
2022-06-30 3:44 ` [PATCH v6 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-06-30 7:47 ` [PATCH v6 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 Andreas Schwab
2022-06-30 20:13 ` Noah Goldstein
2022-06-30 20:13 ` Noah Goldstein
2022-06-30 20:13 ` [PATCH v6 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-07-01 22:35 ` H.J. Lu
2022-06-30 23:20 ` [PATCH v6 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 H.J. Lu
2022-07-01 0:01 ` Noah Goldstein
2022-07-01 0:01 ` Noah Goldstein
2022-07-01 22:38 ` H.J. Lu
2022-07-01 22:52 ` Noah Goldstein
2022-07-03 18:00 ` H.J. Lu
2022-07-04 4:28 ` Noah Goldstein
2022-07-04 4:28 ` [PATCH v7 " Noah Goldstein
2022-07-04 4:28 ` [PATCH v7 2/2] x86: Add support for building str{c|p}{brk|spn} with explicit ISA level Noah Goldstein
2022-07-05 15:41 ` [PATCH v7 1/2] x86: Add comment explaining no Slow_SSE4_2 check in ifunc-sse4_2 H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630030838.3693807-1-goldstein.w.n@gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).