From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 38A2538582A7 for ; Sun, 10 Jul 2022 02:28:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38A2538582A7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=heitbaum.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=heitbaum.com Received: by mail-pl1-x629.google.com with SMTP id r1so1802154plo.10 for ; Sat, 09 Jul 2022 19:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heitbaum.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+RVU8RotUCD/sqyTUZynMiEKC1fSAATKuFIgTlSBFyE=; b=nhSKawlkFxpW5LZxhSWNl05GGyOkgwpII/A1tDwdKoxwjennkhaL6U939MIHhcTF6d C82Ds6PRYg5mVhXEhVj1TCSoP0F56tPMjtsePv2qYTjbE/Qn0Be1eMcy2/GdZ2UNQGuL VIoeWM/zJZJJ7RUX8eKZG35xp5h7C/hUnOcLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+RVU8RotUCD/sqyTUZynMiEKC1fSAATKuFIgTlSBFyE=; b=qT0I25YDBQvoUOiMA47abbuZARTUgqR65wNd1EdkTJLFsYIcOUyYiomuPy0OdFDIB7 OXLszs+tl1ZYP4EV5jFTuI8td55kCBVgJLnQLdGMbJz+kLqtr6ZDxE/yb4bwS7Ng3Fxo 6gMbzb1uUhDNKXcp/IyBmS8GgcXeDY5mnFENs0LmoELV0Tsk4Hvjdf5bgN7O0CDzKAlo nrf9FZdmpG1OCPsE6/g8P4vWLvd08ZQissid540rFcLlOIciGKnqyySwGOIcLqvQToAu WOURYNAAtCM1i30wlC86/1EvLYQviZCKLA+ToUGDI22iY7tKHPfrFGHhSSKOgcJ/74eI AtVg== X-Gm-Message-State: AJIora8Oxo0gTcTnQvfCAX2OeM3k/4rCWuSJSxowkcWfsjP4iz/LEdTu cCQCVlpCeGe/O7FhWucHPBwnlw== X-Google-Smtp-Source: AGRyM1ujTuHlD4rGV2bQ5B9GYfum+8AuVKgHoru+rtf7/0TccCvC0OmiRKHW7L1s8XpifS94ZI7r7A== X-Received: by 2002:a17:902:7d94:b0:168:f2b5:a989 with SMTP id a20-20020a1709027d9400b00168f2b5a989mr11752632plm.50.1657420091077; Sat, 09 Jul 2022 19:28:11 -0700 (PDT) Received: from 4928bf7262b9 ([203.220.223.63]) by smtp.gmail.com with ESMTPSA id v34-20020a631522000000b0040c52ff0ba9sm1774378pgl.37.2022.07.09.19.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 19:28:10 -0700 (PDT) Date: Sun, 10 Jul 2022 02:28:04 +0000 From: Rudi Heitbaum To: Adhemerval Zanella , schwab@suse.de, carlos@redhat.com, libc-alpha@sourceware.org Subject: Re: [PATCH v7 5/5] linux: Add mount_setattr Message-ID: <20220710022804.GA9@4928bf7262b9> References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-6-adhemerval.zanella@linaro.org> <0c64445d-a4f7-bb60-d165-e3c02d89549e@redhat.com> <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <6146A38B-2E47-46C1-BBFC-42646A8FF348@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jul 2022 02:28:14 -0000 I am facing the same issue compiling gcc-12.1.0. but since linux-Add-fsconfig.patch also facing the following error with systemd-251.2. I was successfully able to compile systemd-251.2 by reverting: - linux-Add-fsconfig.patch - linux-Add-fspick.patch - linux-Add-open_tree.patch - linux-Add-tst-mount-to-check-for-Linux-new-mount-API.patch - linux-Add-mount_setattr.patch - stdlib-Implement-mbrtoc8-c8rtomb-and-the-char8_t-typ.patch =66rom 2a5b4f7a715921a232f67f6810268c6cd6aa0af2 Executing (target): ninja=20 [100/868] Compiling C object src/basic/libbasic.a.p/chase-symlinks.c.o FAILED: src/basic/libbasic.a.p/chase-symlinks.c.o=20 /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0-= devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -Isrc/basic/libbasic.a.p= -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/sy= stemd -I../src/systemd -I. -I.. -I/var/media/DATA/home-rudi/LibreELEC.tv/bu= ild.LibreELEC-Generic.x86_64-11.0-devel/toolchain/x86_64-libreelec-linux-gn= u/sysroot/usr/include -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64= -Wall -Winvalid-pch -Wextra -std=3Dgnu11 -O0 -Wno-format-signedness -Wno-m= issing-field-initializers -Wno-unused-parameter -Wdate-time -Wendif-labels = -Werror=3Dformat=3D2 -Werror=3Dimplicit-function-declaration -Werror=3Dinco= mpatible-pointer-types -Werror=3Dint-conversion -Werror=3Doverflow -Werror= =3Doverride-init -Werror=3Dreturn-type -Werror=3Dshift-count-overflow -Werr= or=3Dshift-overflow=3D2 -Werror=3Dundef -Wfloat-equal -Wimplicit-fallthroug= h=3D5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -W= nested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Ws= hadow -Wstrict-aliasing=3D2 -Wstrict-prototypes -Wsuggest-attribute=3Dnoret= urn -Wunused-function -Wwrite-strings -Wno-unused-result -Werror=3Dmissing-= declarations -Werror=3Dmissing-prototypes -fdiagnostics-show-option -fno-co= mmon -fno-strict-aliasing -fstack-protector -fstack-protector-strong -fvisi= bility=3Dhidden --param=3Dssp-buffer-size=3D4 -ffunction-sections -fdata-se= ctions -Werror=3Dshadow -include config.h -march=3Dx86-64-v3 -Wall -pipe -O= 2 -fomit-frame-pointer -DNDEBUG -fno-schedule-insns -fno-schedule-insns2 -W= no-format-truncation -fPIC -pthread -fvisibility=3Ddefault -MD -MQ src/basi= c/libbasic.a.p/chase-symlinks.c.o -MF src/basic/libbasic.a.p/chase-symlinks= =2Ec.o.d -o src/basic/libbasic.a.p/chase-symlinks.c.o -c ../src/basic/chase= -symlinks.c In file included from ../src/basic/stat-util.h:13, from ../src/basic/chase-symlinks.h:7, from ../src/basic/chase-symlinks.c:6: =2E./src/basic/missing_stat.h:39:8: error: redefinition of 'struct statx_ti= mestamp' 39 | struct statx_timestamp { | ^~~~~~~~~~~~~~~ In file included from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELE= C-Generic.x86_64-11.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/us= r/include/bits/statx.h:31, from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELE= C-Generic.x86_64-11.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/us= r/include/sys/stat.h:465, from ../src/basic/stat-util.h:7: /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0-= devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/linux/stat.h= :56:8: note: originally defined here 56 | struct statx_timestamp { | ^~~~~~~~~~~~~~~ =2E./src/basic/missing_stat.h:45:8: error: redefinition of 'struct statx' 45 | struct statx STATX_DEFINITION; | ^~~~~ /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-11.0-= devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/linux/stat.h= :99:8: note: originally defined here 99 | struct statx { | ^~~~~ Regards Rudi On Wed, Jul 06, 2022 at 09:21:32AM -0300, Adhemerval Zanella wrote: >=20 > > On 6 Jul 2022, at 06:25, Andreas Schwab wrote: > >=20 > > This is causing a conflict with , breaking the build of > > gcc. > >=20 > > In file included from /usr/include/linux/fs.h:19, > > from ../../../../libsanitizer/sanitizer_common/sanitize= r_platform_limits_posix.cpp:76: > > /usr/include/linux/mount.h:95:6: error: multiple definition of 'enum fs= config_command' > > 95 | enum fsconfig_command { > > | ^~~~~~~~~~~~~~~~ > > In file included from ../../../../libsanitizer/sanitizer_common/sanitiz= er_platform_limits_posix.cpp:63: > > /usr/include/sys/mount.h:189:6: note: previous definition here > > 189 | enum fsconfig_command > > | ^~~~~~~~~~~~~~~~ > > /usr/include/linux/mount.h:129:8: error: redefinition of 'struct mount_= attr' > > 129 | struct mount_attr { > > | ^~~~~~~~~~ > > /usr/include/sys/mount.h:161:8: note: previous definition of 'struct mo= unt_attr' > > 161 | struct mount_attr > > | ^~~~~~~~~~ > > make[4]: *** [Makefile:617: sanitizer_platform_limits_posix.lo] Error 1 >=20 > I am not sure how to handle it, glibc sys/mount.h should be a standalone > header. Maybe check if _UAPI_LINUX_MOUNT_H is defined so to use the > kernel definition? Or check the kernel version and __has_include and use > kernel version instead? >=20 > >=20 > > --=20 > > Andreas Schwab, SUSE Labs, schwab@suse.de > > GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B= 9D7 > > "And now for something completely different." >=20