From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 2CE02385BADA for ; Mon, 11 Jul 2022 08:16:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CE02385BADA Received: by mail-pl1-x631.google.com with SMTP id z1so3830683plb.1 for ; Mon, 11 Jul 2022 01:16:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vox9xtFIlmd7cqLtX1rM9xgEaLRnZmRuXIxFYl/9dbU=; b=T9xRYyArCjmg4eZ/yGGIW7IrG0kFDci4nx+P1aXOp+RYOSbRa+Z1RI4DCvyz71dF2R Qt91OJPCO4xt84l8Wv1XYTam7qWDS5jBOdTh++FBZlzHeu5ehuxQxRRHVp9dME1BY1RZ RXmpo4yGaw2EgzQO4PB5lu7am4J1iO1nxyy6mU0wvnNKHKdOwRsYMldW8rLNuBwx3fKr 5dGiCnJUjyjRtZCOyaAkhMwgO1xF84FvYVzmx5Hei+kiIxQ0SM+KFxpzOWFmTPTQaPnS 48EzgWgRkBLElzwRyXjn/whVZkUYRKQuUzXpaUGzIAP4S/RblnxmMSr6r3YcA5H4HOMG dhPg== X-Gm-Message-State: AJIora/A8cezdIJR0+KBLNvzE6pSWfakvJrIzLSSOWpTzUAb5EyK8s9B aM+Rk0zKFyp1nRRgvKv0K7R3iJpo54CrOw== X-Google-Smtp-Source: AGRyM1t0YToz4l8Ek6ydU44p7LLdMWXCPaS1OsvF4LNP4nk9PIzNKphdk4SnR0H9g7myz4gYNvqQrA== X-Received: by 2002:a17:90b:1a84:b0:1ef:dc5c:3088 with SMTP id ng4-20020a17090b1a8400b001efdc5c3088mr16326403pjb.245.1657527388057; Mon, 11 Jul 2022 01:16:28 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:bbec:e06d:b778:f9bc]) by smtp.gmail.com with ESMTPSA id b73-20020a621b4c000000b0052ab7985e18sm4107567pfb.61.2022.07.11.01.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 01:16:27 -0700 (PDT) Date: Mon, 11 Jul 2022 01:16:24 -0700 From: Fangrui Song To: Carlos O'Donell Cc: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH v7 1/5] linux: Add fsconfig Message-ID: <20220711081624.ws7lhii2baq7efoe@google.com> References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-2-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 08:16:34 -0000 On 2022-07-04, Carlos O'Donell via Libc-alpha wrote: >On 6/24/22 15:59, Adhemerval Zanella wrote: >> It was added on Linux 5.2 (ecdab150fddb42fe6a739335257949220033b782) >> as a way to a configure filesystem creation context and trigger >> actions upon it, to be used in conjunction with fsopen, fspick and >> fsmount. >> >> The fsconfig_command commands are currently only defined as an enum, >> so they can't be checked on tst-mount-consts.py with current test >> support. > >LGTM. API uses const void * correctly and syscall wrapper signature matches. > >Reviewed-by: Carlos O'Donell https://sourceware.org/glibc/wiki/Synchronizing_Headers can be updated that #include #include no longer works. This led to a compiler-rt build failure which I am going to fix in https://reviews.llvm.org/D129471 (llvm-project 15.0 will be branched soon https://discourse.llvm.org/t/llvm-15-0-0-release-schedule/63495) Note: #include #include doesn't work for a long time /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant 35 | MS_RDONLY = 1, /* Mount read-only. */ | ^~~~~~~~~