From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH] stdlib: DIAG_IGNORE_NEEDS_COMMENT setenv.c
Date: Mon, 29 Aug 2022 16:00:21 -0300 [thread overview]
Message-ID: <20220829190021.946508-1-adhemerval.zanella@linaro.org> (raw)
Checked on x86_64-linux-gnu.
---
stdlib/setenv.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/stdlib/setenv.c b/stdlib/setenv.c
index 2176cbac31..2add8bfb41 100644
--- a/stdlib/setenv.c
+++ b/stdlib/setenv.c
@@ -19,12 +19,14 @@
# include <config.h>
#endif
+#if _LIBC
+# include <libc-diag.h>
/* Pacify GCC; see the commentary about VALLEN below. This is needed
at least through GCC 4.9.2. Pacify GCC for the entire file, as
there seems to be no way to pacify GCC selectively, only for the
- place where it's needed. Do not use DIAG_IGNORE_NEEDS_COMMENT
- here, as it's not defined yet. */
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+ place where it's needed. */
+DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
+#endif
#include <errno.h>
#if !_LIBC
--
2.34.1
next reply other threads:[~2022-08-29 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 19:00 Adhemerval Zanella [this message]
2022-08-30 7:15 ` Florian Weimer
2022-08-30 7:15 ` Florian Weimer
2022-09-19 14:05 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829190021.946508-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).