From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3B48C3858C62 for ; Thu, 15 Sep 2022 19:56:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B48C3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:51484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYuyj-0003Ow-HZ; Thu, 15 Sep 2022 15:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=FSHrgk7yOFp21MTM3YCi8mKsbOYaX4ZjB/YjhTA4w3A=; b=n034RNT1RKj4AtWD6l33 gNjXuzTAnvPgi0yRAbE+r6ctYtgtvM8IZqJfaM7kxsxbCWfwwCSn8ed3ig/f8WATotWfPRQxehoXu n6yKtwuRA/l0gI3HW/zaGTjKgLYooUgxXAR8rA4RmJ0A/cAqmgXfFqR5oyRZbqO3gut8eWo3CWUA7 X/4cN1PUKduz9YaT8bqi+Y29OQ4CKXFiG18BClhwiz24g1tMyfPSZGJqmXU1KQmTuza9+HfHjHhhH vRABDztgoDRLS+2XqiyYvHbgdgOmX2UUEFoUTHSu4zlZuDpDlTvf1hSLsmI+sPlzbt4jLChRYHi2T 5FYthYmSlS6oIQ==; Received: from [89.207.171.57] (port=54030 helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYuyj-00018V-1l; Thu, 15 Sep 2022 15:56:53 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1oYuya-001CkX-0q; Thu, 15 Sep 2022 21:56:44 +0200 Date: Thu, 15 Sep 2022 21:56:44 +0200 From: Samuel Thibault To: Andreas Schwab Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org Subject: Re: [hurd,commited] hurd: Fix readlink() hanging on fifo Message-ID: <20220915195644.ewv5ksmioip7lxlk@begin> References: <20220914165827.118893-1-samuel.thibault@ens-lyon.org> <87tu59hop7.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tu59hop7.fsf@igel.home> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_SBL_CSS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andreas Schwab, le mer. 14 sept. 2022 19:04:52 +0200, a ecrit: > On Sep 14 2022, Samuel Thibault wrote: > > diff --git a/sysdeps/mach/hurd/readlink.c b/sysdeps/mach/hurd/readlink.c > > index 770462714f..2d75ef7725 100644 > > --- a/sysdeps/mach/hurd/readlink.c > > +++ b/sysdeps/mach/hurd/readlink.c > > @@ -31,7 +31,7 @@ __readlink (const char *file_name, char *buf, size_t len) > > file_t file; > > struct stat64 st; > > > > - file = __file_name_lookup (file_name, O_READ | O_NOLINK, 0); > > + file = __file_name_lookup (file_name, O_NOLINK, 0); > > if (file == MACH_PORT_NULL) > > return -1; > > > > @@ -41,6 +41,9 @@ __readlink (const char *file_name, char *buf, size_t len) > > { > > char *rbuf = buf; > > > > + __mach_port_deallocate (__mach_task_self (), file); > > + file = __file_name_lookup (file_name, O_READ | O_NOLINK, 0); > > How do you know that file_name still points at the same thing? Righ, better make that atomic. I have pushed it so. Thanks, Samuel