From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by sourceware.org (Postfix) with ESMTPS id 69D9738582B0 for ; Thu, 15 Sep 2022 19:14:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69D9738582B0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=otheo.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=otheo.eu Received: (Authenticated sender: #01#@otheo.eu) by mail.gandi.net (Postfix) with ESMTPSA id 77F7D100007; Thu, 15 Sep 2022 19:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=otheo.eu; s=gm1; t=1663269252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sypmZiG4G4pksybrjwnaHhC9cAtT19Bim9J4TlvDb6E=; b=pyYEiLgf6+eVAhrh6XFq1q/Vuk1Jp5sSU6DmrGJ+Nm/bM6hranRwLWblODJ2tzJpxtdWQ9 9jINP2TNhR71jbHcdlH2czhf3beaU/p0SbKGzqLHCBnCw9X/am56YRhXb+ZhwU+bfdk+4P zTHdePcv/gWrVnCyCW/XlvtDsrHIBGzurFUEMrMDHuXwWPaNl5su7e5vZ26N65/vv5hvQc ghHKmbxmRUXCpGIXENFgJ3zWuKWTJjakJ4cqn2QnQHxwoVamPHlkf687LUvgzubLTYqw7S u2H0k0ej2LPNcL/yCYoTexoZ+xPebKt1cfzUFKet3TweH0FgDQA0+BJPhj0WYg== Date: Thu, 15 Sep 2022 21:12:54 +0200 From: Javier Pello To: Carlos O'Donell Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 6/6] elf: Simplify output of hwcap subdirectories in ld.so help Message-Id: <20220915211254.72539a4429fa369ba780305e@otheo.eu> In-Reply-To: References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu> <87h71l9crb.fsf@oldenburg.str.redhat.com> <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> <87h71i6rfa.fsf@oldenburg.str.redhat.com> <20220914200724.8e685fbbaf441c96d19011c6@otheo.eu> <20220914201509.1c642836df76f95d3c2a8f28@otheo.eu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 15 Sep 2022 04:42:36 -0400, Carlos O'Donell wrote: > On Wed, Sep 14, 2022 at 08:15:09PM +0200, Javier Pello wrote: > > The print_hwcap_1 machinery was useful for the legacy hwcaps > > subdirectories, but it is not worth the trouble now that they > > are gone. > > This fails pre-commit CI for i686: > https://patchwork.sourceware.org/project/glibc/patch/20220914201509.1c642836df76f95d3c2a8f28@otheo.eu/ And spectacularly so, it seems. > Which architectures have you tested this on? On i686, ironically. And the output from make check looks fine on my end. I am puzzled. The output from CI suggests that the compiled libc.so cannot be loaded, but the last patch only inlines two static functions, only used for the output of ld.so --help. I cannot see why the patch series would be fine after patch 5 but fail this way after patch 6. I will try to look into this. Javier