public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 6/6] x86: Fix -Os build (BZ #29576)
Date: Wed, 21 Sep 2022 10:51:08 -0300	[thread overview]
Message-ID: <20220921135108.3324737-7-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20220921135108.3324737-1-adhemerval.zanella@linaro.org>

The compiler might transform __stpcpy calls (which are routed to
__builtin_stpcpy as an optimization) to strcpy and x86_64 strcpy
multiarch implementation does not build any working symbol due
ISA_SHOULD_BUILD not being evaluated for IS_IN(rtld).

Checked on x86_64-linux-gnu.
---
 sysdeps/x86_64/multiarch/rtld-strcpy.S | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 sysdeps/x86_64/multiarch/rtld-strcpy.S

diff --git a/sysdeps/x86_64/multiarch/rtld-strcpy.S b/sysdeps/x86_64/multiarch/rtld-strcpy.S
new file mode 100644
index 0000000000..19439c553d
--- /dev/null
+++ b/sysdeps/x86_64/multiarch/rtld-strcpy.S
@@ -0,0 +1,18 @@
+/* Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include "../strcpy.S"
-- 
2.34.1


  parent reply	other threads:[~2022-09-21 13:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 13:51 [PATCH 0/6] Fix -Os build Adhemerval Zanella
2022-09-21 13:51 ` [PATCH 1/6] locale: prevent maybe-uninitialized errors with -Os [BZ #19444] Adhemerval Zanella
2022-10-05 13:39   ` Carlos O'Donell
2022-09-21 13:51 ` [PATCH 2/6] posix: Suppress -Os warnings on fnmatch Adhemerval Zanella
2022-10-05 13:47   ` Carlos O'Donell
2022-10-05 20:01     ` Paul Eggert
2022-09-21 13:51 ` [PATCH 3/6] posix: Suppress -Os may be used uninitialized warnings on regexec Adhemerval Zanella
2022-10-05 13:49   ` Carlos O'Donell
2022-09-21 13:51 ` [PATCH 4/6] rt: Initialize mq_send input on tst-mqueue{5,6} Adhemerval Zanella
2022-10-05 13:51   ` Carlos O'Donell
2022-09-21 13:51 ` [PATCH 5/6] sunrpc: Suppress GCC -Os warning on user2netname Adhemerval Zanella
2022-10-05 13:52   ` Carlos O'Donell
2022-09-21 13:51 ` Adhemerval Zanella [this message]
2022-10-05 14:10   ` [PATCH 6/6] x86: Fix -Os build (BZ #29576) Carlos O'Donell
2022-10-05 17:21     ` H.J. Lu
2022-10-05 17:38       ` Adhemerval Zanella Netto
2022-10-05 18:06         ` H.J. Lu
2022-10-05 20:43           ` Adhemerval Zanella Netto
2022-10-05 21:27             ` H.J. Lu
2022-10-05 13:40 ` [PATCH 0/6] Fix -Os build Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921135108.3324737-7-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).