From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id DC61B3858D28 for ; Wed, 28 Sep 2022 20:46:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC61B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-12803ac8113so18842775fac.8 for ; Wed, 28 Sep 2022 13:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date; bh=zLUIaulxjO1t5/REnp7qyUpmHUdNaDMGgfOfVBNh9Gs=; b=StsaOaEXT3561pAeNUzTWlh0Htzumk53aWiGCMvEKLvzDjhTrKrJHNwchkRvDY7YqJ xufQpAW525SLX1SyGH17ZK0mf+4h7EpnhSJCARkEOchrOzgjnsGX2NgIjIkR1V9JHumZ LC0p9J9dWX1fI28sYYCkrjOdx1thqaHXlIqAtrXPL/YjDvdfWgUPcnE2Vb7hgpz03EhS 9NXb9adkwr9w9kurcEYRUrI/AeaeOs/9Us5K/VmETTpALrBoue1R9NgraUclZ/7DnjSz q4MIQAvzSZaf9eQ/qTZfiQva2RsmQJI2lVysHGlsJSkWzHOjx3hhGd0JWfGi13ARJEGN 0itg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=zLUIaulxjO1t5/REnp7qyUpmHUdNaDMGgfOfVBNh9Gs=; b=FxzPtSSQQtmhi1hQ19GXoEs8Psk54e99qET5bJrlTEsak9srs1GwOtJWqAhkiD0hSv 2FE8jFh64XKqtcGxCgGLEi+/OHpj+Y5fS5LJ1b4L/fIN4HCttLg3oo+cjd7Frg9qdFJU p+SxvJk1PZyCT4LmXtCTRtIkctoNoDwyGL/S2BhdDyHs7WTvLj8yVbwR7mBsyxPMM9O4 8DR37j9CG5r7g2uQQLnDVl5FCT8NAMTXD3wj69sAqxLMSmaiHA3/j4LUWeXJH9+9Sa20 3EOlZP+dgpfiSftPAB2wn/mPDz1OQaQCio62hj9uUEow2yubsTjYkmT/uEV8vbRTaEOG 3QAA== X-Gm-Message-State: ACrzQf3vzyBPFAzYwCXK00QPzwMzfbvJrAivV8SpazmlCGyhxOz5xaqo NVMPDL6xo9t5zW8JdFjC1zmR3JUHl/+eRItd X-Google-Smtp-Source: AMsMyM45oEvtIaydBcUYfCw0jZDK8aocSdKhsr8n46hRFoMcXeQXuK/AKOoQeK+C8eQwbpDjHkl2NA== X-Received: by 2002:a05:6870:c1c7:b0:12b:91cb:914d with SMTP id i7-20020a056870c1c700b0012b91cb914dmr6479673oad.236.1664398003359; Wed, 28 Sep 2022 13:46:43 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:3f57:3c77:8813:789c]) by smtp.gmail.com with ESMTPSA id x4-20020a056870434400b0011bde9f5745sm3219345oah.23.2022.09.28.13.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 13:46:43 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH 4/7] aarch64: Add the clone3 wrapper Date: Wed, 28 Sep 2022 17:46:31 -0300 Message-Id: <20220928204634.3036650-5-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220928204634.3036650-1-adhemerval.zanella@linaro.org> References: <20220928204634.3036650-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It follow the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on aarch64-linux-gnu. --- sysdeps/unix/sysv/linux/aarch64/clone3.S | 90 ++++++++++++++++++++++++ sysdeps/unix/sysv/linux/aarch64/sysdep.h | 2 + 2 files changed, 92 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/aarch64/clone3.S diff --git a/sysdeps/unix/sysv/linux/aarch64/clone3.S b/sysdeps/unix/sysv/linux/aarch64/clone3.S new file mode 100644 index 0000000000..dba93430eb --- /dev/null +++ b/sysdeps/unix/sysv/linux/aarch64/clone3.S @@ -0,0 +1,90 @@ +/* The clone3 syscall wrapper. Linux/aarch64 version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#define _ERRNO_H 1 +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + x0: cl_args + x1: size + x2: func + x3: arg */ + + .text +ENTRY(__clone3) + PTR_ARG (0) + PTR_ARG (1) + PTR_ARG (3) + PTR_ARG (4) + /* Save args for the child. */ + mov x10, x0 /* cl_args */ + mov x11, x2 /* func */ + mov x12, x3 /* args */ + + /* Sanity check args. */ + mov x0, #-EINVAL + cbz x10, .Lsyscall_error /* No NULL cl_args pointer. */ + cbz x2, .Lsyscall_error /* No NULL function pointer. */ + + /* Do the system call, the kernel expects: + x8: system call number + x0: cl_args + x1: size */ + mov x0, x10 + mov x8, #SYS_ify(clone3) + svc 0x0 + + cmp x0, #0 + beq thread_start + blt .Lsyscall_error + RET +PSEUDO_END (__clone3) + + .align 4 + .type thread_start, %function +thread_start: + cfi_startproc + cfi_undefined (x30) + mov x29, 0 + + /* Align sp. */ + mov x0, sp + and x0, x0, -16 + mov sp, x0 + + /* Pick the function arg and execute. */ + mov x0, x12 + blr x11 + + /* We are done, pass the return value through x0. */ + mov x8, #SYS_ify(exit) + svc 0x0 + cfi_endproc + .size thread_start, .-thread_start + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h index f1853e012f..42bb22f5e6 100644 --- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h +++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h @@ -164,6 +164,8 @@ # define HAVE_CLOCK_GETTIME64_VSYSCALL "__kernel_clock_gettime" # define HAVE_GETTIMEOFDAY_VSYSCALL "__kernel_gettimeofday" +# define HAVE_CLONE3_WRAPPER 1 + # undef INTERNAL_SYSCALL_RAW # define INTERNAL_SYSCALL_RAW(name, nr, args...) \ ({ long _sys_result; \ -- 2.34.1