From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id D57EF3858437 for ; Wed, 28 Sep 2022 20:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D57EF3858437 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1319cf91d8aso4871138fac.5 for ; Wed, 28 Sep 2022 13:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date; bh=Yv0rDeh2vR817wK3VxpGxHCdi5O8Klh9ZGY/VAAhpjQ=; b=id845q94fFMz930AIr8iWUv34FBwuYJ7o83rhuFKxc3CADtR03Vsw8yu2W8CbtaHrE 0EzKeqfZZEBnanVsOV5r0AI5jKC6Mj9uw32DSAuStKBBd5fqljLc094rIbCKzrp4oyug z9C5qgShYi8GJhRXpF06tSk4Y8lsgFD6S0nCjwgMvipHohU+ZELB+Ip/h/7WSTLO5Y9c xgMiRTt2RR4Fi+hjWdc3u7dBSrV8DrCx8bcV/zlHdsTkn1HagEDdSfoH/yJ+u6SpRy9G 5tlMbrB2INJB8y4kZvqXygI+4dTGbxjBnF5zcad2hmvQeSTMahST9lGsIHQZdQJBIXT8 QO1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Yv0rDeh2vR817wK3VxpGxHCdi5O8Klh9ZGY/VAAhpjQ=; b=kx1kbArsFHKeoy3FosEfZNSlb8qhyj3K74cUB8OlyZs5CbqC3wHEE+N6mvPE9KiJYd H3UmDO/lf3b5nduEbO8+nMt4z3kzUEJN2oT0hVg0Py2W3VC5NuJIKHqviptp7yNoSHZ5 0WL/l9t4dsv6u6hkIuo/3mWeIjh1l3B9kht+i73e6jHfkhhcfxDG9OfSdz1ks5ftBF/y Ll/ohpFUiEshIlPlQx7r9ZZ3MS5j9lvQYg+CEPMCHonrCf0Cp34PJPF8v2QeOf0ue6oa oF2VYxh4lePUWM7kUESUdX31Md7FoWOgI0FK79BBSEDu2wingHcFiBxIBI0AWg/xffk/ HmNQ== X-Gm-Message-State: ACrzQf0eQ+c5r7tnoW6ME78t4vEGJaxLzXkeClPQyIun96yRzHet7TbN fz0fOV/kjCelvw3xH/gjoxRncMThtEjh3xPc X-Google-Smtp-Source: AMsMyM4wXO0CrasSLXGbkctwzfFCGAbMbBGv5YlVLzWBxBV8G0NK5Zwx/ZO3SL/90y2mUIAQVsOFPg== X-Received: by 2002:a05:6870:b508:b0:12d:1c59:90d9 with SMTP id v8-20020a056870b50800b0012d1c5990d9mr6484548oap.199.1664398006027; Wed, 28 Sep 2022 13:46:46 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:3f57:3c77:8813:789c]) by smtp.gmail.com with ESMTPSA id x4-20020a056870434400b0011bde9f5745sm3219345oah.23.2022.09.28.13.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 13:46:45 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH 6/7] riscv: Add the clone3 wrapper Date: Wed, 28 Sep 2022 17:46:33 -0300 Message-Id: <20220928204634.3036650-7-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220928204634.3036650-1-adhemerval.zanella@linaro.org> References: <20220928204634.3036650-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on riscv64-linux-gnu-rv64imafdc-lp64d. --- sysdeps/unix/sysv/linux/riscv/clone3.S | 83 ++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/riscv/sysdep.h | 1 + 2 files changed, 84 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/riscv/clone3.S diff --git a/sysdeps/unix/sysv/linux/riscv/clone3.S b/sysdeps/unix/sysv/linux/riscv/clone3.S new file mode 100644 index 0000000000..1e6e807aa0 --- /dev/null +++ b/sysdeps/unix/sysv/linux/riscv/clone3.S @@ -0,0 +1,83 @@ +/* The clone3 syscall wrapper. Linux/RISC-V version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + a0: cl_args + a1: size + a2: func + a3: arg */ + + .text +ENTRY(__clone3) + /* Sanity check args. */ + beqz a0, L(invalid) /* No NULL cl_args pointer. */ + beqz a2, L(invalid) /* No NULL function pointer. */ + + /* Do the system call, the kernel expects: + a7: system call number + a0: cl_args + a1: size */ + li a7, __NR_clone3 + scall + + bltz a0, L(error) + beqz a0, L(thread_start) + + ret + +L(invalid): + li a0, -EINVAL +L(error): + tail __syscall_error +END (__clone3) + +ENTRY(__thread_start_clone3) +L(thread_start): + /* Terminate call stack by noting ra is undefined. Use a dummy + .cfi_label to force starting the FDE. */ + .cfi_label .Ldummy + cfi_undefined (ra) + + /* Align stack to a 128-bit boundary as per RISC-V ABI. */ + andi sp, sp, ALMASK + + /* Restore the arg for user's function and call the user's + function. */ + mv a1, a2 /* Function pointer. */ + mv a0, a3 /* Argument pointer. */ + jalr a1 + + /* Call exit with the function's return value. */ + li a7, __NR_exit + scall +END(__thread_start_clone3) + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h index 9b03b10567..57523dc7b7 100644 --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h @@ -150,6 +150,7 @@ /* RV32 does not support the gettime VDSO syscalls. */ # endif +# define HAVE_CLONE3_WRAPPER 1 /* List of system calls which are supported as vsyscalls (for RV32 and RV64). */ -- 2.34.1