From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by sourceware.org (Postfix) with ESMTPS id 134E8385C409 for ; Thu, 29 Sep 2022 19:28:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 134E8385C409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vk1-xa35.google.com with SMTP id k14so1218756vkk.0 for ; Thu, 29 Sep 2022 12:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date; bh=QHKixklziLzlRkhf9DjHwcHz+BZBpCyzuaJuywYJOK8=; b=sxxF8tg3B40wBXCL3JJCcEy8wZ8x8DEcy5GEmnMHrUKdTvq4QS7jnOgRadKG7MKkoO fM35fip0H7nG7JBfpJZR5aPxaiBdfJ5cFM0v3uqD7G8IJvIduzczL7TRv5ATGOCkWIZE 1SCXageRUhtkIsbjikBeBO+ZTSWiULVfx2iMMhW/uDcjOcJqyzymI5sPWVLuRy/adh1y 1B6gPUGbr3aRMOpa5W5k9AJi1kkruBlXu+fkDD0dj/HgAxfJj5AWOJvxpx/KvP/2E83G wxgMedyPVqxIM+1Vz1QfF/PYeuolpUGNWxtajU7jmKuZVKrPIM+CLI9BS5s3wcuE3jYK YLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date; bh=QHKixklziLzlRkhf9DjHwcHz+BZBpCyzuaJuywYJOK8=; b=HRBPIU13PubhF8gxmlLwJQ8h0MH3p7bwLh2cbxO45gR644iSXlft7R3YsaQCK96XPS 1kCtgyiUOyojL4yFb09Qdb3i8v/09vYybpZ86cCSFL1ArZ9Q+cUpfF9JNeTJrThbzD4M TPm+JCLHu561ZXxWHwsffsoa+VXdIC3oIh/s40qyjJvS7qWAksbK+7u6or7uEivcQR9Q 9gQ6x+pm51faEXH4hgByhfwgEsMkIVBvxjG3CKlM9eYQcLQLvmtJXBuhg1PUgNy/Tvwh ovg/L6Lo0ZYwgFUv125J0XgIuRPH+QsDwLxioGODiHdDjrZDt9Sd6BQZor1WXoMQ+Qu1 cDjg== X-Gm-Message-State: ACrzQf04osqyitMYmhzncqZx1m9Z0gKczwwUG4b2z7WJ8CAQegDrhWkB VSn9FOEKjAna0swrUpjdxfvA+zQM3XiLkvNx X-Google-Smtp-Source: AMsMyM72Wn9o9lN5ue7RrPx1XE5EoDL5UiuhOVzVG8fDo/4Mcg8WyqRhw/ZeRDhzAojRUv1KfBhP5g== X-Received: by 2002:a1f:d042:0:b0:3a2:4c49:411e with SMTP id h63-20020a1fd042000000b003a24c49411emr2612315vkg.10.1664479680163; Thu, 29 Sep 2022 12:28:00 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:f485:5f41:e13d:4b46]) by smtp.gmail.com with ESMTPSA id y7-20020a1f3207000000b003a30e5de061sm395088vky.47.2022.09.29.12.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 12:27:59 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Wilco Dijkstra , Yu Chien Peter Lin Subject: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638) Date: Thu, 29 Sep 2022 16:27:55 -0300 Message-Id: <20220929192756.3310704-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Using an unsigned type prevents the fallback to be used if kernel does not support getrandom syscall. Checked on x86_64-linux-gnu. --- stdlib/arc4random.c | 2 +- sysdeps/unix/sysv/linux/not-cancel.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stdlib/arc4random.c b/stdlib/arc4random.c index e417ef624d..960a38f295 100644 --- a/stdlib/arc4random.c +++ b/stdlib/arc4random.c @@ -34,7 +34,7 @@ void __arc4random_buf (void *p, size_t n) { static int seen_initialized; - size_t l; + ssize_t l; int fd; if (n == 0) diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h index a263d294b1..cf35c8bfc9 100644 --- a/sysdeps/unix/sysv/linux/not-cancel.h +++ b/sysdeps/unix/sysv/linux/not-cancel.h @@ -68,7 +68,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt) INTERNAL_SYSCALL_CALL (writev, fd, iov, iovcnt); } -static inline int +static inline ssize_t __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags) { return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags); -- 2.34.1