From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by sourceware.org (Postfix) with ESMTPS id 442C138582B0 for ; Fri, 30 Sep 2022 19:26:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 442C138582B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vs1-xe32.google.com with SMTP id a129so5852248vsc.0 for ; Fri, 30 Sep 2022 12:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date; bh=jphfAatt3WwU8gTxwrDpXk7pbGPaIVKK7k1bbpEp4aA=; b=yrWeBo5FY2MECwAuQ7T7mOsYUbc+IStAzl64IF3xs6umeP+jikt7CifwxWhahgT+3i /xzAM7xAn7rP223rUQqCiTPxTRo3MtW+XoxkGzANRqze1rQGHjUmSAoqVi6QJhLkXk5X j78A33J/rV6/PhZz7sTIjj/6gpmhFm+KXZnERuatLvadoM1OGiYbaIzFXSYeRoP8/Fyr 17CrGN47T+kUEQpV5G3J9XWVMlxzmMBkd+PpUL5fX+QZXHeFmXjjYAqGUbik25D08na8 9KbvVh9cLUn7a0QJr0SPN+XRLgFCCspC9OGbNOBJe4c7Wx2dekQwT/tAcx5mRJbsdrrZ 3izA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=jphfAatt3WwU8gTxwrDpXk7pbGPaIVKK7k1bbpEp4aA=; b=g/Zo0shucU0etyKGMJwQKlhSjRDKNAP1FLG6mP6VQrAwdgO3FcozfrT6xsjJwKexZh WpGT2xVsmndZyhTXSBgVatM5nt5P1qu9EW/tdCdgQs44/rn8xjRmz0PNAyHMGed+r9oa bR/vQMeJn8rCZ4XQUfd8HyWyHRjCrpjCcp9jsasZKZsx2jJMNFDJXqAAP3/ZrCm+iUYP IJsITiZ5e+kmJpfUtxOMAZzf+fsE0n8undTWMUCrdKbI4ZdFxOQxOx3cP++Y/LiUNWCt fYlC8VLMTLLCrgFDB3eeAeR6Xx76GuVqFZtluTqHa7KA3Wz5oa08Trbmj4sh+5+b+zNj kWww== X-Gm-Message-State: ACrzQf170uM5X4uKns881pV/8mmrzlq7KWpckHBEvzX6iNPndFye0lhA FLAGQoBajnuHbPS5v0Cc5epX/NSZ5i0tsjX0 X-Google-Smtp-Source: AMsMyM6j5dKpvdQmMj/kISXwOlEHG5sjW0D0vhUDFpouUPUcSE8SwJY6xYBt3/FyiD1NRc7bSkni+g== X-Received: by 2002:a67:e085:0:b0:398:30a7:3be5 with SMTP id f5-20020a67e085000000b0039830a73be5mr5148007vsl.45.1664565986384; Fri, 30 Sep 2022 12:26:26 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:cce5:8b83:d63b:2954]) by smtp.gmail.com with ESMTPSA id h197-20020a1f21ce000000b0039ecbaa55d8sm2381545vkh.44.2022.09.30.12.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 12:26:25 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH v2 5/9] s390x: Add the clone3 wrapper Date: Fri, 30 Sep 2022 16:26:09 -0300 Message-Id: <20220930192613.3491147-6-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on s390x-linux-gnu. --- sysdeps/unix/sysv/linux/s390/s390-64/clone3.S | 84 +++++++++++++++++++ sysdeps/unix/sysv/linux/s390/sysdep.h | 1 + 2 files changed, 85 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/clone3.S diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S new file mode 100644 index 0000000000..d338acfc9c --- /dev/null +++ b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S @@ -0,0 +1,84 @@ +/* The clone3 syscall wrapper. Linux/s390x version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#define _ERRNO_H 1 +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + r2: cl_args + r3: size + r4: func + r5: arg */ + + .text +ENTRY(__clone3) + stg %r6, 48(%r15) + + /* Sanity check args. */ + ltgr %r2, %r2 + je error + ltgr %r6, %r4 + je error + + /* Do the system call, the kernel expects: + r1: system call number + r2: cl_args + r3: size */ + lghi %r1, SYS_ify(clone3) + svc 0 + ltgr %r2,%r2 /* check return code */ + jz thread_start + lg %r6, 48(%r15) + jgm SYSCALL_ERROR_LABEL + br %r14 +error: + lghi %r2,-EINVAL + jg SYSCALL_ERROR_LABEL +PSEUDO_END (__clone3) + + .align 4 + .type thread_start, %function +thread_start: + cfi_startproc + /* Mark r14 as undefined in order to stop unwinding here. */ + cfi_undefined (r14) + + /* Align stack. */ + nill %r15, 0xfff0 + + /* func is in gpr 6, arg in gpr 5. */ + lgr %r2, %r5 + aghi %r15, -160 + xc 0(8,%r15),0(%r15) + basr %r14, %r6 + + DO_CALL (exit, 1) + cfi_endproc + .size thread_start, .-thread_start + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/s390/sysdep.h b/sysdeps/unix/sysv/linux/s390/sysdep.h index 930d7efe03..366c797ef1 100644 --- a/sysdeps/unix/sysv/linux/s390/sysdep.h +++ b/sysdeps/unix/sysv/linux/s390/sysdep.h @@ -72,6 +72,7 @@ #ifdef __s390x__ #define HAVE_CLOCK_GETRES64_VSYSCALL "__kernel_clock_getres" #define HAVE_CLOCK_GETTIME64_VSYSCALL "__kernel_clock_gettime" +#define HAVE_CLONE3_WRAPPER 1 #else #define HAVE_CLOCK_GETRES_VSYSCALL "__kernel_clock_getres" #define HAVE_CLOCK_GETTIME_VSYSCALL "__kernel_clock_gettime" -- 2.34.1