From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by sourceware.org (Postfix) with ESMTPS id 5B2253854833 for ; Fri, 30 Sep 2022 19:26:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B2253854833 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vs1-xe30.google.com with SMTP id d187so5813924vsd.6 for ; Fri, 30 Sep 2022 12:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date; bh=Yv0rDeh2vR817wK3VxpGxHCdi5O8Klh9ZGY/VAAhpjQ=; b=HlyPuvuZr+dPnFLIw5H1LOLKYR3BLJG6hNUFhrbcwiFrTHh0KEYVVssXHkM/KzzTEC vfBLGBr08wvZkGl6fBrefFyulHM680pxoUxR2fn69ng3v91HxT7GbjDxE4rz5dYEMxcD IOHWAJxMeqz9dLAwu6JgfSyNiYd0+uUCZSKUIuwpXGNxOvw/JPRMZL+QUbc8Fom1s05Y f5mThCu0HGi8vP8YiGyQWwWWF9K0MMvMKudRnW3MlHBjKmNAQJxA+hZEivSpZyKtYxRn AYJaIzoGCuXzlIXECHI04BVva+UE16aCW33HFr4Z3JdT6aUZW013MgjSixQL7cF78xcY J0HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Yv0rDeh2vR817wK3VxpGxHCdi5O8Klh9ZGY/VAAhpjQ=; b=uJVN4pixQI4l1F99ziA+LYKk5TaunkpMhmJNgMkFgKO2VCQyL4c09DStBy0Sv23okV RNOUoNfdRqkn8mK70KAMhk58sdgUtwrczbucBaQSfHTqZLHphJt0sRXZIILCL28q2UTO ulUBZ4Xkaq/8BAqsdhwuRsZfSdpV6AgvWXXNI3GASYvJXS9IWZxtRpM/Xygx60oLftSY NEEmLbIMXNdb/6o9lt1wi4cEFY1CNQ8Bg3t8I31DGV+dEUuQaGji76o/kSNBmmZxjBXS UxZVfm9SzmXXxVy0pJlGBLMhPTkS7ABI5Mf/rnP6J2JbKOfQBWxp9l4VP4/9i3Oluaef +QHw== X-Gm-Message-State: ACrzQf0xykzR1Yl/7xlBgBhgFRFCIlLUTCdr0jFMX2S7QNPJpmpyQOqx PyabDUcHE6OYFQISqc58f8drczGIYhOMB0iQ X-Google-Smtp-Source: AMsMyM7SE3KA52cV3zh+KGzZHQrroGkyHW+ezoNNus2P/R+CAbctzv10vOeyVSTxDLzt/b1M779A2g== X-Received: by 2002:a67:c19e:0:b0:398:b82a:2378 with SMTP id h30-20020a67c19e000000b00398b82a2378mr4730374vsj.48.1664565987834; Fri, 30 Sep 2022 12:26:27 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:cce5:8b83:d63b:2954]) by smtp.gmail.com with ESMTPSA id h197-20020a1f21ce000000b0039ecbaa55d8sm2381545vkh.44.2022.09.30.12.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 12:26:27 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH v2 6/9] riscv: Add the clone3 wrapper Date: Fri, 30 Sep 2022 16:26:10 -0300 Message-Id: <20220930192613.3491147-7-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on riscv64-linux-gnu-rv64imafdc-lp64d. --- sysdeps/unix/sysv/linux/riscv/clone3.S | 83 ++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/riscv/sysdep.h | 1 + 2 files changed, 84 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/riscv/clone3.S diff --git a/sysdeps/unix/sysv/linux/riscv/clone3.S b/sysdeps/unix/sysv/linux/riscv/clone3.S new file mode 100644 index 0000000000..1e6e807aa0 --- /dev/null +++ b/sysdeps/unix/sysv/linux/riscv/clone3.S @@ -0,0 +1,83 @@ +/* The clone3 syscall wrapper. Linux/RISC-V version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + a0: cl_args + a1: size + a2: func + a3: arg */ + + .text +ENTRY(__clone3) + /* Sanity check args. */ + beqz a0, L(invalid) /* No NULL cl_args pointer. */ + beqz a2, L(invalid) /* No NULL function pointer. */ + + /* Do the system call, the kernel expects: + a7: system call number + a0: cl_args + a1: size */ + li a7, __NR_clone3 + scall + + bltz a0, L(error) + beqz a0, L(thread_start) + + ret + +L(invalid): + li a0, -EINVAL +L(error): + tail __syscall_error +END (__clone3) + +ENTRY(__thread_start_clone3) +L(thread_start): + /* Terminate call stack by noting ra is undefined. Use a dummy + .cfi_label to force starting the FDE. */ + .cfi_label .Ldummy + cfi_undefined (ra) + + /* Align stack to a 128-bit boundary as per RISC-V ABI. */ + andi sp, sp, ALMASK + + /* Restore the arg for user's function and call the user's + function. */ + mv a1, a2 /* Function pointer. */ + mv a0, a3 /* Argument pointer. */ + jalr a1 + + /* Call exit with the function's return value. */ + li a7, __NR_exit + scall +END(__thread_start_clone3) + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h index 9b03b10567..57523dc7b7 100644 --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h @@ -150,6 +150,7 @@ /* RV32 does not support the gettime VDSO syscalls. */ # endif +# define HAVE_CLONE3_WRAPPER 1 /* List of system calls which are supported as vsyscalls (for RV32 and RV64). */ -- 2.34.1