From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id 872543858C55 for ; Fri, 30 Sep 2022 19:26:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 872543858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vs1-xe29.google.com with SMTP id 63so5835699vse.2 for ; Fri, 30 Sep 2022 12:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date; bh=5UfYe9VAEJTDla1B+ic7B8Ed6Rayx6oYOv3v9aHpbNk=; b=AfPmfZT93dES4UCkm2RghXV+j78YS/39R/l58/6dyZhx56i5cfPpK+hg9JDWp+eS+1 YkFzISntVCfhkFowOdsmA1c/6uKJVaYcDpvhH8UOVpiPdP8381Vi2Sjpgx7D7w1pMnwJ XAnSXa9G0k43ifZ1+EJHR5NOSXYoRZt5bnF7dprCp2F51FC1XHwfT4N7OfPfoOcww8+k bWeUcfzwukO4tGQhshCJQI7ueXLSELn8dNLRSPELKvQ2gG7vRd2HoNI/bvGmljFtq6O1 08BTv24F6AZkOaaBrEP/PV+RkC8kzFKHQwvlsTgZTMd/P86wjWNDX7MyvsKk2W88rjOM YE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=5UfYe9VAEJTDla1B+ic7B8Ed6Rayx6oYOv3v9aHpbNk=; b=aRw3eT/2LJzTWehC8sfVyLNiqnS0GqjqLk1gFB6husEkAPvwTVB8s5yy9UtydKrpL1 bhY3OgztjFPbDTA2i+vKZo3vHnL3h9nPBeSqgKbLfKljmvGasyn27M2sJJTX0VX2j1L4 Qbz+5Llr1XLaRn/OBh3MMMvKeBHqCAiyLnIMTG/syTxUVw4GX6WDSN0wneHT9pYunqrH u4r2GUh6xnqozrSEb3A0aJWyJ1nvbs8tSJkbPKlnG2yS1cUQP/0UoeBBz1Uu/kuOmhaU CHa+epwzqNzRE7foh3mXQJ/jMIYG7hhx/f6DTuPavuUXoDqyL4nR1Vug3jVSQQIJSyqO bMuA== X-Gm-Message-State: ACrzQf0FzrZVGjnNRmV+pBdINfd9T9MxkmOW7E9QNLf3iUmKQKMrT3QY K+pspuTuPVw7J3rR1k93p//XQsJhZWwedwez X-Google-Smtp-Source: AMsMyM4LrMF1SBeV83pNwwDlikPlv7qxX1sxK4F3H7vkSC42BhizYGRHoNKzyS78hE8NshHTfKZYNw== X-Received: by 2002:a05:6102:3e1a:b0:398:905b:7b81 with SMTP id j26-20020a0561023e1a00b00398905b7b81mr4815579vsv.36.1664565990666; Fri, 30 Sep 2022 12:26:30 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:cce5:8b83:d63b:2954]) by smtp.gmail.com with ESMTPSA id h197-20020a1f21ce000000b0039ecbaa55d8sm2381545vkh.44.2022.09.30.12.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 12:26:30 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH v2 8/9] mips: Add the clone3 wrapper Date: Fri, 30 Sep 2022 16:26:12 -0300 Message-Id: <20220930192613.3491147-9-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on mips64el-linux-gnueabihf and mipsel-linux-gnu. --- sysdeps/unix/sysv/linux/mips/clone3.S | 147 ++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/mips/sysdep.h | 2 + 2 files changed, 149 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/mips/clone3.S diff --git a/sysdeps/unix/sysv/linux/mips/clone3.S b/sysdeps/unix/sysv/linux/mips/clone3.S new file mode 100644 index 0000000000..bd493e344b --- /dev/null +++ b/sysdeps/unix/sysv/linux/mips/clone3.S @@ -0,0 +1,147 @@ +/* The clone3 syscall wrapper. Linux/mips version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#define _ERRNO_H 1 +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + a0/$4: cl_args + a1/$5: size + a2/$6: func + a3/$7: arg */ + + .text + .set nomips16 +#if _MIPS_SIM == _ABIO32 +# define EXTRA_LOCALS 1 +#else +# define EXTRA_LOCALS 0 +#endif +#define FRAMESZ ((NARGSAVE*SZREG)+ALSZ)&ALMASK +GPOFF= FRAMESZ-(1*SZREG) +NESTED(__clone3, SZREG, sp) +#ifdef __PIC__ + SETUP_GP +#endif +#if FRAMESZ + PTR_SUBU sp, FRAMESZ + cfi_adjust_cfa_offset (FRAMESZ) +#endif + SETUP_GP64_STACK (GPOFF, __clone) +#ifdef __PIC__ + SAVE_GP (GPOFF) +#endif +#ifdef PROF + .set noat + move $1,ra + jal _mcount + .set at +#endif + + /* Sanity check args. */ + li v0, EINVAL + beqz a0, L(error) /* No NULL cl_args pointer. */ + beqz a2, L(error) /* No NULL function pointer. */ + + move $8, a3 /* a3 is set to 0/1 for syscall success/error + while a4/$8 is returned unmodified. */ + + /* Do the system call, the kernel expects: + v0: system call number + a0: cl_args + a1: size */ + li v0, __NR_clone3 + cfi_endproc + syscall + + bnez a3, L(error) + beqz v0, L(thread_start_clone3) + + /* Successful return from the parent */ + cfi_startproc +#if FRAMESZ + cfi_adjust_cfa_offset (FRAMESZ) +#endif + SETUP_GP64_STACK_CFI (GPOFF) + cfi_remember_state + RESTORE_GP64_STACK +#if FRAMESZ + PTR_ADDU sp, FRAMESZ + cfi_adjust_cfa_offset (-FRAMESZ) +#endif + ret + +L(error): + cfi_restore_state +#ifdef __PIC__ + PTR_LA t9,__syscall_error + RESTORE_GP64_STACK + PTR_ADDU sp, FRAMESZ + cfi_adjust_cfa_offset (-FRAMESZ) + jr t9 +#else + RESTORE_GP64_STACK + PTR_ADDU sp, FRAMESZ + cfi_adjust_cfa_offset (-FRAMESZ) + j __syscall_error +#endif +END (__clone3) + +/* Load up the arguments to the function. Put this block of code in + its own function so that we can terminate the stack trace with our + debug info. */ + +ENTRY(__thread_start_clone3) +L(thread_start_clone3): + cfi_undefined ($31) + /* cp is already loaded. */ + SAVE_GP (GPOFF) + /* The stackframe has been created on entry of clone3. */ + + /* Align stack to 8/16 bytes per the ABI. */ +#if _MIPS_SIM == _ABIO32 + li t1, -8 +#else + li t1, -16 +#endif + and sp, sp, t1 + + /* Restore the arg for user's function. */ + move t9, a2 /* Function pointer. */ + move a0, $8 /* Argument pointer. */ + + /* Call the user's function. */ + jal t9 + + move a0, v0 + li v0, __NR_exit + syscall +END(__thread_start_clone3) + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/mips/sysdep.h b/sysdeps/unix/sysv/linux/mips/sysdep.h index 2515dadc26..3f464925e7 100644 --- a/sysdeps/unix/sysv/linux/mips/sysdep.h +++ b/sysdeps/unix/sysv/linux/mips/sysdep.h @@ -28,3 +28,5 @@ #endif #define HAVE_GETTIMEOFDAY_VSYSCALL "__vdso_gettimeofday" #define HAVE_CLOCK_GETRES_VSYSCALL "__vdso_clock_getres" + +#define HAVE_CLONE3_WRAPPER 1 -- 2.34.1