From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by sourceware.org (Postfix) with ESMTPS id 789923858C52 for ; Tue, 4 Oct 2022 17:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 789923858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=otheo.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=otheo.eu Received: (Authenticated sender: #01#@otheo.eu) by mail.gandi.net (Postfix) with ESMTPSA id C6FB240003; Tue, 4 Oct 2022 17:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=otheo.eu; s=gm1; t=1664906040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+4KK71Sl+1N6uW6zSz4E9GWdSungTkbl3NpXgpicmYQ=; b=Nb6RVkqFPgNmqnPle4JAGOKiReQCPbD1Ovjpig5r2xo4XPlBHak+zVstesclBVMREYhnTC hClj0PGUCx0wImr40vdWH0kRREtB86XeTbHuYEO2uYob8oiYB8Vo0GYLX8fCPZnncSCdvF MFpCQaN0Hnvsmkax3/scogP6gF7f4HtwjjyJ2kRj8y1vEoqW+KaIuKGe0QAAU0AdH+sSjR z+BJQwioK49a8lF5VWoM9opXAicFKlC5+8IwzCdS2GOwNtXAxM4m55kGhe3RsNbvUXnWNY wIC8qtFpimstv8Czu8p85ZlUWevUowr8QYlAYFHXnZU8NDmTnFzdjA3tBcNSBg== Date: Tue, 4 Oct 2022 19:53:57 +0200 From: Javier Pello To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 1/8] x86_64: Remove platform directory library loading test Message-Id: <20221004195357.b823ddad7891dd29df4372ee@otheo.eu> In-Reply-To: References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu> <87h71l9crb.fsf@oldenburg.str.redhat.com> <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> <87h71i6rfa.fsf@oldenburg.str.redhat.com> <20220914200724.8e685fbbaf441c96d19011c6@otheo.eu> <20220917161748.2b76e1731a27eb78880ee57c@otheo.eu> <20220927200352.0424a12908a437fef9d3a7bc@otheo.eu> <20220927200515.8749a18ef6f13beede3f1a60@otheo.eu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 3 Oct 2022 11:56:47 -0300 Adhemerval Zanella Netto wrote: > On 27/09/22 15:05, Javier Pello wrote: > > This was to test loading of shared libraries from platform > > subdirectories, but this functionality is going away in the > > following commits. > > > > Signed-off-by: Javier Pello > > LGTM, although I think this patch should be move after the > functionality is removed. > > Reviewed-by: Adhemerval Zanella Thanks. I put this patch first because that is what Florian suggested, and I think that it makes sense to strive for the testsuite to pass at any intermediate commits (otherwise bisecting an unrelated bug may be harder), so the test should be removed before the functionality, but I am fine either way. Regards, Javier