From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 208DA3857379 for ; Thu, 20 Oct 2022 02:14:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 208DA3857379 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-131dda37dddso23016785fac.0 for ; Wed, 19 Oct 2022 19:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0mHS9/xkWKiXFayHijujAHbZadMDQIzEyovfi05Id4Q=; b=IVQeBEHFsS0F7o0Bn6TZAfLGq4BWgk56YE+r8yRtsybOzXHqLJMrqnn2fm+Sr13tze HPenUTt4d0ht+xQ8QA5dOJe+OnF2e6i86D2isWTx1bxbM3/GeGKGZe1rfT90Zh/fwk5c Kn6B7HDmjWRjC2JBKxPGOMLflPdVI3vSP3BqULM424FEDoskTNhMkVS4KHjzzrun/EXw OKy//PwfD+xb9gSbzBmTTvHQncCIJwW/n0Q6SsiQn2YsooXqp9Csh/j3XB8/NkPrjSXs AfgxQbsscWf2JgG3oOJkhY/iV15C8lK4VaH342FowPZgPa5gV1XMszwmaeSIS/SMFzt+ wjNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0mHS9/xkWKiXFayHijujAHbZadMDQIzEyovfi05Id4Q=; b=pchBTQBcxtccJEYNbsUAabOaa5fCdvznZrf2q48aKo/qcER3SprzciVYYIGwLVwvOD 04ooHN4OTJuSTvxj1JbJ9s7B8M1GMLvoWPsGj/jcDDTfgHijzK+dxhWizFZ2qnJOHDoe whAUXLfnOH7tw3ohzydEijRiLhXe1YNRWx4YFtApKy17OKvKChxNzxq7x/c7fSCWauI3 ugx4x9a8y4EQelvC1FXxLJvPuftzLyDjR8kOTKYJAh4getHQKkWNeUUSr8paxkj54Aaz fSCEoYPiV84b7DYWfBBFQRpI+kkagsGr0PecWcu1eGd36d553qoqJ5Wpe2ZO3AX7rGQW XJww== X-Gm-Message-State: ACrzQf04T3K3Wszo6HtglnKptitu7RrOwccCPRDaaWGo5a24eSE7m5uB BmPqaO2CKAV0ah+YMeU6NQBzySI2k7FzYw== X-Google-Smtp-Source: AMsMyM5FgiOUxYsaRvTePIHDxDnS2vfmT8uOHavlMyk8boHXd6wY5BzJV/ugqaFgSNRx+thhI4hFuA== X-Received: by 2002:a05:6870:c188:b0:136:faa7:dd66 with SMTP id h8-20020a056870c18800b00136faa7dd66mr7620640oad.47.1666232063169; Wed, 19 Oct 2022 19:14:23 -0700 (PDT) Received: from noah-tgl.lan (2603-8080-1301-76c6-bfae-083c-6dae-542c.res6.spectrum.com. [2603:8080:1301:76c6:bfae:83c:6dae:542c]) by smtp.gmail.com with ESMTPSA id q10-20020a056830440a00b00661a5ef58a0sm7843243otv.23.2022.10.19.19.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 19:14:22 -0700 (PDT) From: Noah Goldstein To: libc-alpha@sourceware.org Cc: goldstein.w.n@gmail.com, hjl.tools@gmail.com, carlos@systemhalted.org Subject: [PATCH v1 4/4] x86: Use `testb` for FSRM check in memmove-vec-unaligned-erms Date: Wed, 19 Oct 2022 19:13:38 -0700 Message-Id: <20221020021338.3394281-4-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221020021338.3394281-1-goldstein.w.n@gmail.com> References: <20221020021338.3394281-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: `testb` saves a bit of code size is the imm-operand can be encoded 1-bytes. Tested on x86-64. --- sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S index 5b758cae5e..f6d7f3e88b 100644 --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S @@ -616,7 +616,11 @@ L(movsb): jae L(large_memcpy_2x_check) # if AVOID_SHORT_DISTANCE_REP_MOVSB || ALIGN_MOVSB /* Only avoid short movsb if CPU has FSRM. */ +# if X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB < 256 + testb $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) +# else testl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) +# endif jz L(skip_short_movsb_check) # if AVOID_SHORT_DISTANCE_REP_MOVSB /* Avoid "rep movsb" if RCX, the distance between source and -- 2.34.1