From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id DC1B23858427 for ; Sat, 29 Oct 2022 00:32:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC1B23858427 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pl1-x631.google.com with SMTP id io19so6191394plb.8 for ; Fri, 28 Oct 2022 17:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LN35jEaSYVaGIMUMT7PoHNWY6YKwHDVNiTbobQwrpGI=; b=lUz965YzcvirswkANybpHwKvuvXHR0t+/XT41cpitK9jBfDkiStXukAj3gcTODueC8 +Eg71PjMqD8KISfJ0S9g9yL1nCNzXfqCoUw7PKvpB35ILXGdAAilhs/eyl8xFr8jrKql WqgFgs9aZ+FJ+o+j3BlEmJZNcW4OZUKgevLob/SwsjW3kzxzxB69Q92XI6ejTlHg40Kv D1hmTrSUBVQcRrJwvs19Lap6QfTS32MGziGzMQcGgFzxhoXmwA3XmjCxV3Y8SfaVmepo XeYLX/rTanQVIIwJdSnp6Id/3e9aWV0UGIM4nG9XO0Cuz98Z/0AyFnwEUPDs7R9Lea7Y Q16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LN35jEaSYVaGIMUMT7PoHNWY6YKwHDVNiTbobQwrpGI=; b=BNHlltv27Vc4xCGMeQYuUtGN72EVejdwBAA3BLJKSS7lMU63yYZ6WfeV0OmrQSf5q/ +1i3bEBcvk2Xf3ckn3qb93gJawuQUiTT+B3zM917bxyzpcKUN/09oxdqn8DERgr2TjMn +5CL01AYnTSbN01vXsPsKB2L1m1gWrGK5zz1m5eVRGh8/ay95TxnLzHupkWnCSvgzLEf FpLKZowqSL8zJv8m+2/zCmOIRBnBmMR0luSJqAcjxlAXeFs+uDlCToTdtG+ZWka7tkkX EnGSJ76otLrDO9vPlzwwj2fy8wgWCtncW65oq7NaPD2lJkwcjs7CfkFIOu9E1BKumLl9 oJGQ== X-Gm-Message-State: ACrzQf3oH95sn1Viur5Pxjb9tFgwyiG3W2SqwW2pXtkvTrZN3fgybgsp FOlESyCw0unPmVrn3KU8/0kbbXH29/mlQA== X-Google-Smtp-Source: AMsMyM6a1eqiwRBZ6YXLN+etOGjMstG2Z6f0fw80CN+ZTlh99Kceet/xxyANFCHfrrtW0AnfamPozw== X-Received: by 2002:a17:90b:3901:b0:20b:210d:d5d9 with SMTP id ob1-20020a17090b390100b0020b210dd5d9mr1963651pjb.83.1667003524822; Fri, 28 Oct 2022 17:32:04 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8981:f21e:b257:256]) by smtp.gmail.com with ESMTPSA id z15-20020a63c04f000000b00464aa9ea6fasm53256pgi.20.2022.10.28.17.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 17:32:03 -0700 (PDT) Date: Fri, 28 Oct 2022 17:32:00 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 09/11] alloc_buffer: Apply asm redirection before first use Message-ID: <20221029003200.y7tuyn55d6qpwv4z@google.com> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-10-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221028173532.876027-10-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >Compilers may not be able to apply asm redirections to functions after >these functions are used for the first time, e.g. clang 13. You may say "clang 15". (clang 15.0.x has been released and clang still doesn't support this. I think this is very difficult to support.... https://maskray.me/blog/2021-10-10-when-can-glibc-be-built-with-clang#asm-label-after-first-use "Clang's one-function-at-a-time parsing and code generation strategy.") Thanks. This fixed In file included from mntent.c:21: ../include/allocate_once.h:92:20: error: cannot apply asm label to function after its first use libc_hidden_proto (__libc_allocate_once_slow) ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ ./../include/libc-symbols.h:613:58: note: expanded from macro 'libc_hidden_proto' # define libc_hidden_proto(name, attrs...) hidden_proto (name, ##attrs) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~ ./../include/libc-symbols.h:513:19: note: expanded from macro 'hidden_proto' __hidden_proto (name, , __GI_##name, ##attrs) ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./../include/libc-symbols.h:519:33: note: expanded from macro '__hidden_proto' extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Reviewed-by: Fangrui Song