From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 0AAF43858D38 for ; Sat, 29 Oct 2022 00:34:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AAF43858D38 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pg1-x532.google.com with SMTP id s196so6187021pgs.3 for ; Fri, 28 Oct 2022 17:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+cszwvRwGXvb1xQNc9171ORedSsJpGFdnYokGyQAYfs=; b=KSOkr2ihVWyzKQB6gVcn9UgQulAZMRpfRkmzIngH0S5Tmx/hfbFqimRLZkw1HT25nA s00C7F8MvGh1JoIU7ZPt9PU4XjmpMBxwyCCUzHYx0jA8FxN7YH64Ez2tUn0RTgmuhzCp hsQPbuoCND8HG3vno5/s0I3L+ur0tjfkyx4j9WSrs1jJv5/X9RxXzhdcT4xRKx7QhT82 OZQMyiyYEpcTgMZcSQIrdnJbVhIuRjK0SqbSW/vy+i9gzN1B8YdsXpdTU2wDK9srI7Zw DcpaMYmkl/57lM4zSs2SgOF0CQdGid6erVd/oC1s81PT9zwLVXTAmLJauaaEq7N5MCKv /j8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+cszwvRwGXvb1xQNc9171ORedSsJpGFdnYokGyQAYfs=; b=J/67s8hWAloDeRf3GIPEtbRtdp07TtJA5nhPhloDnd3tza9BDX+Ml80cf9kLbkbXjd 5DE4iraTcM4wofTRuuSxJB9dJq8MJAPMXvNB3BDA9dj1o8KeOpCLr1j2hW8D5eiiFz95 ILyaqmR2uA6gugDcf97Gr+tC/95iUJYdtga5L6+qweiLIuRXflaXooOL0iTV76iXYRLD pnzM8Ts+WzAP1dKGRH1CRdYKBAQxrAXvCoGimcdLHMjtrYFtifHt5bxmbCP1YnofTazi f0X0JRnZEWMl1dI61881dGeKNvFFPVPMnZ97c3pHNgY+PPXr2cq0HvvIu5MS6f0vuWKL Y7ag== X-Gm-Message-State: ACrzQf0QoTfiaq8E9n8n9BRXtRWBUtWRKEwRPIepQBCxUdoKGJN0zVGk SHIkmRJDSuVHSZ9XzZwc6OaPZqYEAefdEA== X-Google-Smtp-Source: AMsMyM58bjxkurgubF6LtJfyMDfcOm/9SdqWh/FTgl4yzMPLWlkgws8QpnI5I7rng/k2ov1jNkUlEQ== X-Received: by 2002:a63:e211:0:b0:43b:f03e:3cc5 with SMTP id q17-20020a63e211000000b0043bf03e3cc5mr1961295pgh.256.1667003687969; Fri, 28 Oct 2022 17:34:47 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8981:f21e:b257:256]) by smtp.gmail.com with ESMTPSA id h15-20020a170902680f00b00186cf82717fsm47193plk.165.2022.10.28.17.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 17:34:47 -0700 (PDT) Date: Fri, 28 Oct 2022 17:34:43 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 10/11] allocate_once: Apply asm redirection before first use Message-ID: <20221029003443.nepgt6xxavgi4ttb@google.com> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-11-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221028173532.876027-11-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >Compilers may not be able to apply asm redirections to functions >after these functions are used for the first time, e.g. clang 13. Ditto. You may say 15. This fixed a dozen errors like: In file included from alloc_buffer_alloc_array.c:19: ../include/alloc_buffer.h:382:20: error: cannot apply asm label to function after its first use libc_hidden_proto (__libc_alloc_buffer_allocate) ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./../include/libc-symbols.h:613:58: note: expanded from macro 'libc_hidden_proto' # define libc_hidden_proto(name, attrs...) hidden_proto (name, ##attrs) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~ ./../include/libc-symbols.h:513:19: note: expanded from macro 'hidden_proto' __hidden_proto (name, , __GI_##name, ##attrs) ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./../include/libc-symbols.h:519:33: note: expanded from macro '__hidden_proto' extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from alloc_buffer_alloc_array.c:19: ../include/alloc_buffer.h:383:20: error: cannot apply asm label to function after its first use libc_hidden_proto (__libc_alloc_buffer_copy_bytes) ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./../include/libc-symbols.h:613:58: note: expanded from macro 'libc_hidden_proto' Reviewed-by: Fangrui Song