From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id ADF8B3858D20 for ; Sat, 29 Oct 2022 00:44:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADF8B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pg1-x532.google.com with SMTP id q1so6165986pgl.11 for ; Fri, 28 Oct 2022 17:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ywk9zAXpDtvXtkmnjzO0ClPZkjn12Fk30CTpSvPN/Wg=; b=L6+oDgcnjl4IFTBC9nXXNhfSCg28KwGpo+KwFmNckSwKFas0xAKpUcHnSLyrjwd1J4 /2PIrc187RPIXAVw7TQndb2e6V2mKd+N6UNaKQIQXQSlacx9FqOOKK008R+p2VzmCfrF kbqsDdb9FUbsVb8mas8xnhrR1E4g/aRgGqdF7PmDexN0X7s7758idSzjCLIia9SBIAJw 0t5vMkoaBg4/jaZfHKV8gNCdWXTooR56iuaKyP8cJmgvGgWDgagb7ZFfHIJV1+O9419G ENsvFAn+WvtWYZofZ3y7yfRgfBn4mNjJkeLJSAb08NDcBEtQYmEQ8p2weq0uC9jzTz6p ivhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ywk9zAXpDtvXtkmnjzO0ClPZkjn12Fk30CTpSvPN/Wg=; b=6+IopbRqj9K/mP331TMQNo28OVRJxJT5lDigxCVLp0Qbdald+WEGZiauJgFPOydzGc Bm0OeP/3VDuY9vM1tcgZZc0rcRIuk5qKFdUgV6NWT4aGJwZL7CKd1N9m49aoyMLMMiKL zrF/H9cKdhSO00hglFTgumEYvUyTSnXxKuOaIHsaFP0grBsqbyEpA0q4JlvMk30q+6qg vB1l4oJ5JCy04PNXdfU5eq7yt9y47Cggsz72Jk791vDDbpRPqEBPbNoKM183ovnKLHLN rsRBPssz4o8G5HwyNRRbMUYYgtdSdw5J4vIueOO7Lk2Cs226tjMS25lTcBXP2cvRInCt ZUvg== X-Gm-Message-State: ACrzQf11aN47ej32KIRHlnjuqSjYQkAGP1FO/CtedLRFP5iOS/WQ9BIA n9ZPhIWPFnzCtdukGYu05/RfdfQsDpWNCQ== X-Google-Smtp-Source: AMsMyM4B4+oulvDa+XqyqPAOZae01zNGX2XixcyY6YTid0IZNVSdg1PUins4RBn07yCPDqHImwUJ+w== X-Received: by 2002:a62:3281:0:b0:56d:385:149b with SMTP id y123-20020a623281000000b0056d0385149bmr1865217pfy.29.1667004279652; Fri, 28 Oct 2022 17:44:39 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8981:f21e:b257:256]) by smtp.gmail.com with ESMTPSA id e10-20020a170902784a00b00186ad73e2d5sm46749pln.208.2022.10.28.17.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 17:44:38 -0700 (PDT) Date: Fri, 28 Oct 2022 17:44:35 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Message-ID: <20221029004435.o6mhtrlsmugm7ufg@google.com> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-6-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221028173532.876027-6-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-26.4 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >Clang warns that '__gettextnerrs' set but not used: > > intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used > [-Werror,-Wunused-but-set-variable] > int yynerrs = 0; > ^ > >Since the file is auto-generated, suppress the warning with a compiler >flag. >--- > intl/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/intl/Makefile b/intl/Makefile >index 315c75a18f..1c3b2a2273 100644 >--- a/intl/Makefile >+++ b/intl/Makefile >@@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out > $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out > > CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \ >- -D'LOCALE_ALIAS_PATH="$(localedir)"' >+ -D'LOCALE_ALIAS_PATH="$(localedir)"' \ >+ -Wno-unused-but-set-variable > BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output > > $(inst_localedir)/locale.alias: locale.alias $(+force) >-- >2.34.1 > yynerrs is incremented but its value is unused. Clang 15 (https://reviews.llvm.org/D122271) -Wunused-but-set-variable gives a warning while GCC doesn't. -Wunused-but-set-variable is available in GCC 4.6, smaller than the minimum required version 6.2. Reviewed-by: Fangrui Song