From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 916BC385841E for ; Sat, 29 Oct 2022 04:19:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 916BC385841E Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pf1-x429.google.com with SMTP id b29so6349166pfp.13 for ; Fri, 28 Oct 2022 21:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rmTo98FKnMRZmxP0kiZjAwmUcM3C/XXcOja82/k7RTk=; b=VSEfifjydcD+3sT1YPqVMfh8EJb87RIonTrqm0VH+dpWyPkdobd3WWwNV8lly1INGY hfZLSZLHx6sB7Ns9pypurAwqGyu1AWhDoyz/ttlADDEyAF3I6gVJ+rjpoObiQ2f9VrXl pf4j89sgI3NMmugygr+SLwep2uzXq527XWW/dzB8pU5lIwCELW75/RR7K0FmouxqzN85 +VswODjpiBnNUkCwwvoSFj6eJ6IduqLJ8+crFY4NCxGPwochhsZ6qhMd5b8vDrBXcWnb EB5DrmBIaqRhfNwD+KHh/OSqTH4zFGtEH9bnM4UplqQejP5VrVjoH8BJnmGrNFGemX+C AUJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rmTo98FKnMRZmxP0kiZjAwmUcM3C/XXcOja82/k7RTk=; b=kEY+KdYyW65eGrZPIlVwHFC6dzuMSxBSlVhTyT3SL/s79I1Wha71DDae91QSNEnqOj 9vI5mHYklcYX1Cv8X7tALQW7Ts9/Zc4VzZtWQt4E0hM09dvwhJu8CPBIJJPVLERTvqA6 DzJOc/YFRRTcTjUoQnbIbAPJwYPHar74uSBUo+4zYwltJM2V8PXVUGeHjyEeJ3OBYUBr MllOqov3jtSzLT2DCRP1N4lmAMfV8UBwcSNQRGPSULxsCDX9WYqNzF0ToLFpq3Wd8xzY W+z8Gz5FnrH83CUe38DTc/7nSkjJS4EMB3ACXGEns4p6rK8A21ZTEm155dR0vDjml7JA zt2A== X-Gm-Message-State: ACrzQf0i1JppqI7HoNearJFLTnYSdfa1Mx36z0BhpwoVEyCHRWPX2c9m 3jF34r5odVBRRZGlD8m48asSbAr4eyoxNw== X-Google-Smtp-Source: AMsMyM7lGS1isa2xsDD27Vnrg9I1hatKXmB27VJ2zNQG4k4p1NOYhVOQXXH00ZuhJ+fAN75kz3h8tA== X-Received: by 2002:a63:fd57:0:b0:43c:9a42:74fb with SMTP id m23-20020a63fd57000000b0043c9a4274fbmr2567737pgj.174.1667017152407; Fri, 28 Oct 2022 21:19:12 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:8981:f21e:b257:256]) by smtp.gmail.com with ESMTPSA id k18-20020aa79d12000000b0056bbebbcafbsm256494pfp.100.2022.10.28.21.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 21:19:10 -0700 (PDT) Date: Fri, 28 Oct 2022 21:19:08 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 06/11] Disable use of -fsignaling-nans if compiler does not support it Message-ID: <20221029041908.sk3wkn6oemxszn7r@google.com> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-7-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221028173532.876027-7-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-26.7 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >--- > benchtests/Makefile | 6 ++--- > configure | 22 +++++++++++++++++ > configure.ac | 10 ++++++++ > math/Makefile | 19 ++++++++------- > math/libm-test-fpclassify.inc | 2 ++ > math/libm-test-isfinite.inc | 2 ++ > math/libm-test-isinf.inc | 2 ++ > math/libm-test-isnan.inc | 2 ++ > math/libm-test-isnormal.inc | 2 ++ > math/libm-test-issubnormal.inc | 2 ++ > math/libm-test-iszero.inc | 2 ++ > math/test-snan.c | 10 ++++++-- > sysdeps/powerpc/nofpu/Makefile | 24 +++++++++---------- > .../powerpc32/power4/fpu/multiarch/Makefile | 4 ++-- > .../powerpc64/be/fpu/multiarch/Makefile | 4 ++-- > .../powerpc64/le/fpu/multiarch/Makefile | 4 ++-- > 16 files changed, 86 insertions(+), 31 deletions(-) > >diff --git a/benchtests/Makefile b/benchtests/Makefile >index fc1cda7fc3..292976b26b 100644 >--- a/benchtests/Makefile >+++ b/benchtests/Makefile >@@ -268,9 +268,9 @@ CFLAGS-bench-trunc.c += -fno-builtin > CFLAGS-bench-truncf.c += -fno-builtin > CFLAGS-bench-roundeven.c += -fno-builtin > CFLAGS-bench-roundevenf.c += -fno-builtin >-CFLAGS-bench-isnan.c += -fsignaling-nans >-CFLAGS-bench-isinf.c += -fsignaling-nans >-CFLAGS-bench-isfinite.c += -fsignaling-nans >+CFLAGS-bench-isnan.c += $(config-cflags-signaling-nans) >+CFLAGS-bench-isinf.c += $(config-cflags-signaling-nans) >+CFLAGS-bench-isfinite.c += $(config-cflags-signaling-nans) >[...] > This looks fine to me. -fsignaling-nans is an ignored option in Clang. % fclang -fsyntax-only -fsignaling-nans -xc /dev/null clang-16: warning: optimization flag '-fsignaling-nans' is not % supported [-Wignored-optimization-argument] https://gcc.gnu.org/wiki/FloatingPointMath says > -fsignaling-nans is still experimental and may not disable all optimizations that affect signaling NaN behavior.