From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 44FC83857680 for ; Mon, 31 Oct 2022 20:01:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 44FC83857680 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pf1-x431.google.com with SMTP id b185so11599845pfb.9 for ; Mon, 31 Oct 2022 13:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vDgBWBZQuUTl7ZRVmTeR6z7BEq78WommNyd8zrLQgn4=; b=S5P1hkwdqqB/EgGFQ0MR6EmIYeotnUFNxK3ML/QlDLQzOXrcq3zZpc65BIph70wfUU bO0/bfR0tPxsVPx9QFjt5wBqbAO8rSc9RhAmGz6dD3CA8FHx4pe3ccDXDyK2rFxm37tM m7FbXC9+SIvr97Zo8nXTpKN6IJjmYi4XmWeKHbgfXMsDUnhZyNLurbswwcAYX8pFqIiD 84C5lSfuPXgbY06U4bzR9X5RQoEGQoG/U8KopE/O10c8Nmamcjdh61RUmpnXNwTllSiu NTJJiaUBlIU0IjZCn2gWJFsZtJfctJNhRmaL8GH3tzgkxeKWrL51RiMQu53Cna9dHZ2Z 10IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vDgBWBZQuUTl7ZRVmTeR6z7BEq78WommNyd8zrLQgn4=; b=gycoCvVMcl/k5DNEzSkRacnQO0tyLthZW+qTpEwGJwB3jcUM7dSbIWdgBtxWUTeKzd wGsa0TCw9HyEgW0BWlksZpRzXZ6WB3jiRABABlfD+ViGGm+09fpW4++3KrJcChxVwGgQ SA3D8u3zs1hWetEJ+/7qqGsvpT3y6VX7DC6Sj2hZumq1p49tU+gCFtJioxSUS/hW0Mxs dr4IDo+3fRsX2qZvz+QJwO1HCrXrl+yy0yZGwzRu+qHHR6akRu84M2V5he7wbs3s7Kbf Jee9s91NZHHobEXuJ5ZrwHA823K1A3s33FLmy4vFdBVsE/yMbiRZsRo8sYHHip3/gkhv wqqA== X-Gm-Message-State: ACrzQf2MPMwpBZRqD7x8+/CQlDNQcVV6fWptY0r5uz5IBSQ1TbtAnxBh cyDUMmv7y4iTZAvm4GB0ANEOVm+td+TQsw== X-Google-Smtp-Source: AMsMyM7d3uMamvsovFWlHqTsvo9t2Hmhs9XrUBZtY570aF0U7Q+DA3scts/vI/e9iTVdvSJ92XQZzQ== X-Received: by 2002:a63:d709:0:b0:461:be56:507e with SMTP id d9-20020a63d709000000b00461be56507emr14467099pgg.597.1667246506185; Mon, 31 Oct 2022 13:01:46 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:3c48:8136:92ed:9cbd]) by smtp.gmail.com with ESMTPSA id h23-20020aa796d7000000b0056d2e716e01sm4211236pfq.139.2022.10.31.13.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 13:01:45 -0700 (PDT) Date: Mon, 31 Oct 2022 13:01:41 -0700 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 06/11] Disable use of -fsignaling-nans if compiler does not support it Message-ID: <20221031200141.ihzupwhzaoyak3la@google.com> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-7-adhemerval.zanella@linaro.org> <20221029041908.sk3wkn6oemxszn7r@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221029041908.sk3wkn6oemxszn7r@google.com> X-Spam-Status: No, score=-27.4 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-28, Fangrui Song wrote: >On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >>--- >>benchtests/Makefile | 6 ++--- >>configure | 22 +++++++++++++++++ >>configure.ac | 10 ++++++++ >>math/Makefile | 19 ++++++++------- >>math/libm-test-fpclassify.inc | 2 ++ >>math/libm-test-isfinite.inc | 2 ++ >>math/libm-test-isinf.inc | 2 ++ >>math/libm-test-isnan.inc | 2 ++ >>math/libm-test-isnormal.inc | 2 ++ >>math/libm-test-issubnormal.inc | 2 ++ >>math/libm-test-iszero.inc | 2 ++ >>math/test-snan.c | 10 ++++++-- >>sysdeps/powerpc/nofpu/Makefile | 24 +++++++++---------- >>.../powerpc32/power4/fpu/multiarch/Makefile | 4 ++-- >>.../powerpc64/be/fpu/multiarch/Makefile | 4 ++-- >>.../powerpc64/le/fpu/multiarch/Makefile | 4 ++-- >>16 files changed, 86 insertions(+), 31 deletions(-) >> >>diff --git a/benchtests/Makefile b/benchtests/Makefile >>index fc1cda7fc3..292976b26b 100644 >>--- a/benchtests/Makefile >>+++ b/benchtests/Makefile >>@@ -268,9 +268,9 @@ CFLAGS-bench-trunc.c += -fno-builtin >>CFLAGS-bench-truncf.c += -fno-builtin >>CFLAGS-bench-roundeven.c += -fno-builtin >>CFLAGS-bench-roundevenf.c += -fno-builtin >>-CFLAGS-bench-isnan.c += -fsignaling-nans >>-CFLAGS-bench-isinf.c += -fsignaling-nans >>-CFLAGS-bench-isfinite.c += -fsignaling-nans >>+CFLAGS-bench-isnan.c += $(config-cflags-signaling-nans) >>+CFLAGS-bench-isinf.c += $(config-cflags-signaling-nans) >>+CFLAGS-bench-isfinite.c += $(config-cflags-signaling-nans) >>[...] >> > >This looks fine to me. -fsignaling-nans is an ignored option in Clang. > >% fclang -fsyntax-only -fsignaling-nans -xc /dev/null >clang-16: warning: optimization flag '-fsignaling-nans' is not % supported [-Wignored-optimization-argument] > >https://gcc.gnu.org/wiki/FloatingPointMath says > >>-fsignaling-nans is still experimental and may not disable all optimizations that affect signaling NaN behavior. Thanks:) Reviewed-by: Fangrui Song