From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 5D8673858C54 for ; Sun, 6 Nov 2022 23:31:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D8673858C54 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pg1-x536.google.com with SMTP id b62so9023934pgc.0 for ; Sun, 06 Nov 2022 15:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E6qVNJ7uI+rbaawPj5vMS+wzYGsvuUByUxa8YIA3UF4=; b=hEG0Q2mjClCPbof3PtxSwyAdSTjdVRTdEHnyYmUPRyYAluc+m2xBT8LXcbevYUIhWl oFKrE2AhwxtFJveaws8dtFK1wCJVI09kBhsf/pV4ODhLtQx+hUyxqYujcfHBWIedikki N+mNJlv1L7PWex4tEMMAt3dEIo5x4SYJ2M6QYRenXhJTo/9az6V64Cwc44K1PFp1WfrA 4cBHVUbe8Lol7/RHB+SFJ58E/AgwLKmFrWAcAfanvwxJ6cyug0mKpSmcY9eCCCRXzZu7 3201sMeo0oFNyX3AOtGjGdaCaMOTKJ2IMz74lwjRaIJxYxmLtRK+Fpc0KevhDwGi/nkQ prwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E6qVNJ7uI+rbaawPj5vMS+wzYGsvuUByUxa8YIA3UF4=; b=BXgaz+s4o15MblCeEIy5ig9Nn+ieJGYYS8HRNRCooLlOrb+fWhlVWtOcQkPDjIAVTJ RE0YbvAwKNd3guXBhy7DncIxyPUic7eLCEoZtQ0nuJP3XJE3XFIRRyv66B8MoZh0tRm2 Tly5vDomYoGufwm/jh7cw+D/fSbm5f/4ME5Znn5yFKhkBu2Lf6Pam8hs6cXmGVKMFukD GVNdovql8xwWTf4fDoBTnedgL6ypSblR5tfGzNuSSw562CfbM6q/dIzqYWvwF/v4dcvw PfIsyfRMkm/JHJn5x4sz2KCYagyOIqGnj6OmumfabzFzIVTp2uHSS/53jxJFS3bvWx3Q T1Cg== X-Gm-Message-State: ACrzQf0I/HNVYB8e44W46ZzibuEYEsVAmq1wXb8McuhhL2ABpNqgPTi8 UdX4510bfoTAfc4iFAL8kiaRNXZw/3LATA== X-Google-Smtp-Source: AMsMyM4DEWMzmeRCo8pTF9+7Z80dbp3o+crnDnzBao7eEnPqNmYWrZ4B7rEJl+0RtSrdeWxne8CyBA== X-Received: by 2002:aa7:942d:0:b0:56c:6e8c:6ff6 with SMTP id y13-20020aa7942d000000b0056c6e8c6ff6mr47425968pfo.67.1667777491280; Sun, 06 Nov 2022 15:31:31 -0800 (PST) Received: from google.com ([2620:15c:2ce:200:8836:d128:f95d:95f3]) by smtp.gmail.com with ESMTPSA id p2-20020a170902e74200b001869b988d93sm3587853plf.187.2022.11.06.15.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 15:31:29 -0800 (PST) Date: Sun, 6 Nov 2022 15:31:25 -0800 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac Message-ID: <20221106233125.zlhmacjbijsdp6vp@google.com> References: <20221102145559.1962008-1-adhemerval.zanella@linaro.org> <20221102145559.1962008-3-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221102145559.1962008-3-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-26.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-11-02, Adhemerval Zanella wrote: >With clang If the main file is , the first non-main-file >dependency is not listed in the -MP output. Although it was fixed >on clang-16 [1], this change adds portability for older version. s/If/if/ >[1] https://github.com/llvm/llvm-project/commit/ff9576f74514b836e1ba0268409a2ecb919d7118 >--- > configure | 4 ++-- > configure.ac | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/configure b/configure >index fc3d7842de..e23ea95a49 100755 >--- a/configure >+++ b/configure >@@ -5669,8 +5669,8 @@ fi > # copy of those headers in Makerules. > if test -n "$CXX"; then > find_cxx_header () { >- echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \ >- | sed -n "\,$1:,{s/:\$//;p}" >+ echo "#include <$1>" | $CXX -H -fsyntax-only -x c++ - 2>&1 \ >+ | awk '$1 == "."{print $2}' > } > CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)" > CXX_CMATH_HEADER="$(find_cxx_header cmath)" >diff --git a/configure.ac b/configure.ac >index 9fc1fb1c1c..7275b53345 100644 >--- a/configure.ac >+++ b/configure.ac >@@ -1137,8 +1137,8 @@ AC_SUBST(CXX_SYSINCLUDES) > # copy of those headers in Makerules. > if test -n "$CXX"; then > find_cxx_header () { >- echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \ >- | sed -n "\,$1:,{s/:\$//;p}" >+ echo "#include <$1>" | $CXX -H -fsyntax-only -x c++ - 2>&1 \ >+ | awk '$1 == "."{print $2}' > } > CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)" > CXX_CMATH_HEADER="$(find_cxx_header cmath)" >-- >2.34.1 > Thanks. Reviewed-by: Fangrui Song